security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00
Code Activity

gpg: drop import-clean from default keyserver import options

Browse Source 
* g10/gpg.c (main): drop IMPORT_CLEAN from the
default opt.keyserver_options.import_options
* doc/gpg.texi: reflect this change in the documentation

Given that SELF_SIGS_ONLY is already set, it's not clear what
additional benefit IMPORT_CLEAN provides.  Furthermore, IMPORT_CLEAN
means that receiving an OpenPGP certificate from a keyserver will
potentially delete data that is otherwise held in the local keyring,
which is surprising to users who expect retrieval from the keyservers
to be purely additive.

GnuPG-Bug-Id: 4628
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
This commit is contained in:
Daniel Kahn Gillmor 2019-07-15 16:24:35 -04:00
parent fb1c8978f5
commit be99eec2b1
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/gpg.texi
View File

@ -1933,7 +1933,7 @@ are available for all keyserver types, some common options are:
@end table @end table
The default list of options is: "self-sigs-only, import-clean, The default list of options is: "self-sigs-only,
repair-keys, repair-pks-subkey-bug, export-attributes, repair-keys, repair-pks-subkey-bug, export-attributes,
honor-pka-record". honor-pka-record".

3
g10/gpg.c
View File

@ -2425,8 +2425,7 @@ main (int argc, char **argv)
opt.export_options = EXPORT_ATTRIBUTES; opt.export_options = EXPORT_ATTRIBUTES;
opt.keyserver_options.import_options = (IMPORT_REPAIR_KEYS opt.keyserver_options.import_options = (IMPORT_REPAIR_KEYS
| IMPORT_REPAIR_PKS_SUBKEY_BUG | IMPORT_REPAIR_PKS_SUBKEY_BUG
| IMPORT_SELF_SIGS_ONLY | IMPORT_SELF_SIGS_ONLY);
| IMPORT_CLEAN);
opt.keyserver_options.export_options = EXPORT_ATTRIBUTES; opt.keyserver_options.export_options = EXPORT_ATTRIBUTES;
opt.keyserver_options.options = KEYSERVER_HONOR_PKA_RECORD; opt.keyserver_options.options = KEYSERVER_HONOR_PKA_RECORD;
opt.verify_options = (LIST_SHOW_UID_VALIDITY opt.verify_options = (LIST_SHOW_UID_VALIDITY