security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-06-14 18:31:03 +02:00
Code Activity

gpg: Enable the Issuer Fingerprint from rfc4880bis

Browse Source 
* g10/build-packet.c (build_sig_subpkt_from_sig): Always write the new
Issuer Fingerprint sub-packet.
* g10/mainproc.c (check_sig_and_print): Always consider that
sub-packet.
--

The specs for this sub-packet have been pushed to the OpenPGP WG's
repo today.

See-also: https://mailarchive.ietf.org/arch/msg/\
	openpgp/GvPo2eSL9GW9WcGhOocY7KBa9FY

Signed-off-by: Werner Koch <wk@gnupg.org>
This commit is contained in:
Werner Koch 2016-10-28 21:01:23 +02:00
parent 5a1f6a0062
commit b6f08dbb0b
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
g10/build-packet.c
View File

@ -1002,17 +1002,12 @@ build_sig_subpkt_from_sig (PKT_signature *sig, PKT_public_key *pksk)
build_sig_subpkt (sig, SIGSUBPKT_ISSUER, buf, 8); build_sig_subpkt (sig, SIGSUBPKT_ISSUER, buf, 8);
} }
/* For a future v5 keys we write the ISSUER_FPR subpacket. We /* Write the new ISSUER_FPR subpacket. */
* also write that for a v4 key is experimental support for fingerprint_from_pk (pksk, buf+1, &fprlen);
* RFC4880bis is requested. */ if (fprlen == 20)
if (pksk->version > 4 || opt.flags.rfc4880bis)
{ {
fingerprint_from_pk (pksk, buf+1, &fprlen); buf[0] = pksk->version;
if (fprlen == 20) build_sig_subpkt (sig, SIGSUBPKT_ISSUER_FPR, buf, 21);
{
buf[0] = pksk->version;
build_sig_subpkt (sig, SIGSUBPKT_ISSUER_FPR, buf, 21);
}
} }
/* Write the timestamp. */ /* Write the timestamp. */

3
g10/mainproc.c
View File

@ -1748,7 +1748,7 @@ check_sig_and_print (CTX c, kbnode_t node)
write_status_text (STATUS_NEWSIG, NULL); write_status_text (STATUS_NEWSIG, NULL);
astr = openpgp_pk_algo_name ( sig->pubkey_algo ); astr = openpgp_pk_algo_name ( sig->pubkey_algo );
if (opt.flags.rfc4880bis && (issuer_fpr = issuer_fpr_string (sig))) if ((issuer_fpr = issuer_fpr_string (sig)))
{ {
log_info (_("Signature made %s\n"), asctimestamp(sig->timestamp)); log_info (_("Signature made %s\n"), asctimestamp(sig->timestamp));
log_info (_(" using %s key %s\n"), log_info (_(" using %s key %s\n"),
@ -1853,7 +1853,6 @@ check_sig_and_print (CTX c, kbnode_t node)
* favor this over the WKD method (to be tried next), because an * favor this over the WKD method (to be tried next), because an
* arbitrary keyserver is less subject to web bug like monitoring. */ * arbitrary keyserver is less subject to web bug like monitoring. */
if (gpg_err_code (rc) == GPG_ERR_NO_PUBKEY if (gpg_err_code (rc) == GPG_ERR_NO_PUBKEY
&& opt.flags.rfc4880bis
&& (opt.keyserver_options.options&KEYSERVER_AUTO_KEY_RETRIEVE) && (opt.keyserver_options.options&KEYSERVER_AUTO_KEY_RETRIEVE)
&& keyserver_any_configured (c->ctrl)) && keyserver_any_configured (c->ctrl))
{ {