1
0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00

dirmngr: New option --ignore-crl-extensions.

* dirmngr/dirmngr.c (oIgnoreCRLExtension): New.
(opts): Add --ignore-crl-extension.
(parse_rereadable_options): Add to list/
* dirmngr/dirmngr.h (opt): Add ignored_crl_extensions.
* dirmngr/crlcache.c (crl_cache_insert): Implement option.
--

This option is is useful for debugging problems with new CRL
extensions.  It is similar to --ignore-cert-extension.

GnuPG-bug-id: 6545
This commit is contained in:
Werner Koch 2023-06-19 14:25:47 +02:00
parent 701a8b30f0
commit b1ecc8353a
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
4 changed files with 30 additions and 0 deletions

View File

@ -2356,10 +2356,19 @@ crl_cache_insert (ctrl_t ctrl, const char *url, ksba_reader_t reader)
for (idx=0; !(err=ksba_crl_get_extension (crl, idx, &oid, &critical, for (idx=0; !(err=ksba_crl_get_extension (crl, idx, &oid, &critical,
NULL, NULL)); idx++) NULL, NULL)); idx++)
{ {
strlist_t sl;
if (!critical if (!critical
|| !strcmp (oid, oidstr_authorityKeyIdentifier) || !strcmp (oid, oidstr_authorityKeyIdentifier)
|| !strcmp (oid, oidstr_crlNumber) ) || !strcmp (oid, oidstr_crlNumber) )
continue; continue;
for (sl=opt.ignored_crl_extensions;
sl && strcmp (sl->d, oid); sl = sl->next)
;
if (sl)
continue; /* Is in ignored list. */
log_error (_("unknown critical CRL extension %s\n"), oid); log_error (_("unknown critical CRL extension %s\n"), oid);
log_info ("(CRL='%s')\n", url); log_info ("(CRL='%s')\n", url);
if (!err2) if (!err2)

View File

@ -147,6 +147,7 @@ enum cmd_and_opt_values {
oHTTPWrapperProgram, oHTTPWrapperProgram,
oIgnoreCert, oIgnoreCert,
oIgnoreCertExtension, oIgnoreCertExtension,
oIgnoreCRLExtension,
oUseTor, oUseTor,
oNoUseTor, oNoUseTor,
oKeyServer, oKeyServer,
@ -224,6 +225,7 @@ static gpgrt_opt_t opts[] = {
ARGPARSE_s_n (oDisableCheckOwnSocket, "disable-check-own-socket", "@"), ARGPARSE_s_n (oDisableCheckOwnSocket, "disable-check-own-socket", "@"),
ARGPARSE_s_s (oIgnoreCert,"ignore-cert", "@"), ARGPARSE_s_s (oIgnoreCert,"ignore-cert", "@"),
ARGPARSE_s_s (oIgnoreCertExtension,"ignore-cert-extension", "@"), ARGPARSE_s_s (oIgnoreCertExtension,"ignore-cert-extension", "@"),
ARGPARSE_s_s (oIgnoreCRLExtension,"ignore-crl-extension", "@"),
ARGPARSE_header ("Network", N_("Network related options")), ARGPARSE_header ("Network", N_("Network related options")),
@ -706,6 +708,7 @@ parse_rereadable_options (gpgrt_argparse_t *pargs, int reread)
opt.ignored_certs = tmp; opt.ignored_certs = tmp;
} }
FREE_STRLIST (opt.ignored_cert_extensions); FREE_STRLIST (opt.ignored_cert_extensions);
FREE_STRLIST (opt.ignored_crl_extensions);
http_register_tls_ca (NULL); http_register_tls_ca (NULL);
FREE_STRLIST (hkp_cacert_filenames); FREE_STRLIST (hkp_cacert_filenames);
FREE_STRLIST (opt.keyserver); FREE_STRLIST (opt.keyserver);
@ -819,6 +822,10 @@ parse_rereadable_options (gpgrt_argparse_t *pargs, int reread)
add_to_strlist (&opt.ignored_cert_extensions, pargs->r.ret_str); add_to_strlist (&opt.ignored_cert_extensions, pargs->r.ret_str);
break; break;
case oIgnoreCRLExtension:
add_to_strlist (&opt.ignored_crl_extensions, pargs->r.ret_str);
break;
case oUseTor: case oUseTor:
tor_mode = TOR_MODE_FORCE; tor_mode = TOR_MODE_FORCE;
break; break;

View File

@ -132,6 +132,11 @@ struct
OID per string. */ OID per string. */
strlist_t ignored_cert_extensions; strlist_t ignored_cert_extensions;
/* A list of CRL extension OIDs which are ignored so that one can
* claim that a critical extension has been handled. One OID per
* string. */
strlist_t ignored_crl_extensions;
/* Allow expired certificates in the cache. */ /* Allow expired certificates in the cache. */
int debug_cache_expired_certs; int debug_cache_expired_certs;

View File

@ -598,6 +598,15 @@ won't be rejected due to an unknown critical extension. Use this
option with care because extensions are usually flagged as critical option with care because extensions are usually flagged as critical
for a reason. for a reason.
@item --ignore-crl-extension @var{oid}
@opindex ignore-crl-extension
Add @var{oid} to the list of ignored CRL extensions. The @var{oid} is
expected to be in dotted decimal form. Critical flagged CRL
extensions matching one of the OIDs in the list are treated as if they
are actually handled and thus the certificate won't be rejected due to
an unknown critical extension. Use this option with care because
extensions are usually flagged as critical for a reason.
@item --ignore-cert @var{fpr}|@var{file} @item --ignore-cert @var{fpr}|@var{file}
@opindex ignore-cert @opindex ignore-cert
Entirely ignore certificates with the fingerprint @var{fpr}. As an Entirely ignore certificates with the fingerprint @var{fpr}. As an