security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-07-02 22:46:30 +02:00
Code Activity

Two minor code cleanups and one NULL deref on error fix.

Browse source 
* common/estream.c (es_freopen): Remove useless check for STREAM.
* kbx/keybox-blob.c (_keybox_create_x509_blob): Remove useless check
for BLOB.
* tools/sockprox.c (run_proxy): Do not fclose(NULL).
--

Found by Hans-Christoph Steiner with cppcheck.
This commit is contained in:
Werner Koch 2014-04-15 16:40:48 +02:00
parent db3b528239
commit a34afa8f20
3 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
kbx/keybox-blob.c
View file

@ -948,12 +948,12 @@ _keybox_create_x509_blob (KEYBOXBLOB *r_blob, ksba_cert_t cert,
leave:
release_kid_list (blob->temp_kids);
blob->temp_kids = NULL;
if (blob && names)
if (names)
{
for (i=0; i < blob->nuids; i++)
xfree (names[i]);
xfree (names);
}
xfree (names);
if (rc)
{
_keybox_release_blob (blob);