security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00
Code Activity

tests: Fix a test which specifies expiration date.

Browse Source 
* tests/openpgp/quick-key-manipulation.scm: Fix expiration time
comparison.

--

This is a bug fix for Amelia Earhart who is probably in UTC-12.

When expiration date is specified, GnuPG interprets it as noon of the
date in local time.

Before this fix, the test compared the value by 2145916800 which is
2038-01-01 00:00:00 in UTC with allowance of 1 day.  When the test
was ran in UTC-12 timezone, it failed because of noon in the timezone
is midnight of the next day in UTC.

GnuPG-bug-id: 3393
Reported-by: Daniel Kahn Gillmor
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
This commit is contained in:
NIIBE Yutaka 2017-09-08 14:21:29 +09:00 committed by Werner Koch
parent 827abe01a7
commit a172759b50
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/openpgp/quick-key-manipulation.scm
View File

@ -178,11 +178,11 @@
(lambda (subkey) (lambda (subkey)
(assert (= 1 (:alg subkey))) (assert (= 1 (:alg subkey)))
(assert (string-contains? (:cap subkey) "s")) (assert (string-contains? (:cap subkey) "s"))
(assert (time-matches? 2145916800 ;; 2038-01-01 (assert (time-matches? 2145960000 ;; UTC 2038-01-01 12:00:00
;; 4260207600 ;; 2105-01-01 ;; 4260254400 ;; UTC 2105-01-01 12:00:00
(string->number (:expire subkey)) (string->number (:expire subkey))
;; This is off by 12h, but I guess it just ;; GnuPG choses the middle of the day (local time)
;; choses the middle of the day. ;; when no hh:mm:ss is specified
(days->seconds 1)))) (days->seconds 1))))
(lambda (subkey) (lambda (subkey)
(assert (= 1 (:alg subkey))) (assert (= 1 (:alg subkey)))