security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-05 12:31:50 +01:00
Code Activity

Do not use the pinentry's qualitybar

Browse Source 
* agent/genkey.c (agent_ask_new_passphrase): No qualitybar.
* g10/call-agent.c (agent_get_passphrase): Ditto.
* sm/call-agent.c (gpgsm_agent_ask_passphrase): Ditto.
--

The concept of a passphrase quality indicator is anyway questionable
because user are smart enough to trick them out and they also tend to
limit the actually used entropy.

Except for the red/green switching (to show whether constraints are
fulfilled) our qualitybar is pretty bad and thus worse than none.

Signed-off-by: Werner Koch <wk@gnupg.org>
This commit is contained in:
Werner Koch 2020-07-08 14:54:10 +02:00
parent 9ee975d588
commit 999d25d47d
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
agent/genkey.c
View File

@ -368,7 +368,7 @@ agent_ask_new_passphrase (ctrl_t ctrl, const char *prompt,
} }
pi->max_length = MAX_PASSPHRASE_LEN + 1; pi->max_length = MAX_PASSPHRASE_LEN + 1;
pi->max_tries = 3; pi->max_tries = 3;
pi->with_qualitybar = 1; pi->with_qualitybar = 0;
pi->with_repeat = 1; pi->with_repeat = 1;
pi2->max_length = MAX_PASSPHRASE_LEN + 1; pi2->max_length = MAX_PASSPHRASE_LEN + 1;
pi2->max_tries = 3; pi2->max_tries = 3;

2
g10/call-agent.c
View File

@ -1940,7 +1940,7 @@ agent_get_passphrase (const char *cache_id,
snprintf (line, DIM(line), snprintf (line, DIM(line),
"GET_PASSPHRASE --data --repeat=%d%s%s -- %s %s %s %s", "GET_PASSPHRASE --data --repeat=%d%s%s -- %s %s %s %s",
repeat, repeat,
((repeat && check) || newsymkey)? " --check --qualitybar":"", ((repeat && check) || newsymkey)? " --check":"",
(have_newsymkey && newsymkey)? " --newsymkey":"", (have_newsymkey && newsymkey)? " --newsymkey":"",
arg1? arg1:"X", arg1? arg1:"X",
arg2? arg2:"X", arg2? arg2:"X",

2
sm/call-agent.c
View File

@ -1322,7 +1322,7 @@ gpgsm_agent_ask_passphrase (ctrl_t ctrl, const char *desc_msg, int repeat,
return gpg_error_from_syserror (); return gpg_error_from_syserror ();
snprintf (line, DIM(line), "GET_PASSPHRASE --data%s -- X X X %s", snprintf (line, DIM(line), "GET_PASSPHRASE --data%s -- X X X %s",
repeat? " --repeat=1 --check --qualitybar":"", repeat? " --repeat=1 --check":"",
arg4); arg4);
xfree (arg4); xfree (arg4);