security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00
Code Activity

gpg: Fix minor memory leak during certain smartcard operations.

Browse Source 
* g10/keygen.c (card_store_key_with_backup): Fix memory leak on error.
This commit is contained in:
Werner Koch 2023-10-27 14:20:47 +02:00
parent a4fe307b55
commit 95b9a31f81
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
g10/keygen.c
View File

@ -5386,17 +5386,26 @@ card_store_key_with_backup (ctrl_t ctrl, PKT_public_key *sub_psk,
{ {
ecdh_param_str = ecdh_param_str_from_pk (sk); ecdh_param_str = ecdh_param_str_from_pk (sk);
if (!ecdh_param_str) if (!ecdh_param_str)
return gpg_error_from_syserror (); {
free_public_key (sk);
return gpg_error_from_syserror ();
}
} }
err = hexkeygrip_from_pk (sk, &hexgrip); err = hexkeygrip_from_pk (sk, &hexgrip);
if (err) if (err)
goto leave; {
xfree (ecdh_param_str);
free_public_key (sk);
goto leave;
}
memset(&info, 0, sizeof (info)); memset(&info, 0, sizeof (info));
rc = agent_scd_getattr ("SERIALNO", &info); rc = agent_scd_getattr ("SERIALNO", &info);
if (rc) if (rc)
{ {
xfree (ecdh_param_str);
free_public_key (sk);
err = (gpg_error_t)rc; err = (gpg_error_t)rc;
goto leave; goto leave;
} }