security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-03 12:11:33 +01:00
Code Activity

dirmngr: Make WKD_GET work even for servers not handling SRV RRs.

Browse Source 
* dirmngr/server.c (proc_wkd_get): Take care of DNS server failures
--

Unfortunately there are resolver setups which don't handle SRV records
but return a server error.  We let a not found error pass, because
that merely means the domain does not exists.

GnuPG-bug-id: 4729
This commit is contained in:
Werner Koch 2022-03-21 22:38:22 +01:00
parent e5ef5e3b91
commit 92c8ae720e
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dirmngr/server.c
View File

@ -924,7 +924,14 @@ proc_wkd_get (ctrl_t ctrl, assuan_context_t ctx, char *line)
err = get_dns_srv (ctrl, domain, "openpgpkey", NULL, &srvs, &srvscount); err = get_dns_srv (ctrl, domain, "openpgpkey", NULL, &srvs, &srvscount);
if (err) if (err)
goto leave; {
/* Ignore server failed becuase there are too many resolvers
* which do not work as expected. */
if (gpg_err_code (err) == GPG_ERR_SERVER_FAILED)
err = 0; /*(srvcount is guaranteed to be 0)*/
else
goto leave;
}
/* Check for rogue DNS names. */ /* Check for rogue DNS names. */
for (i = 0; i < srvscount; i++) for (i = 0; i < srvscount; i++)