security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-31 11:41:32 +01:00
Code Activity

agent: Fix an unitialized variable in an error path.

Browse Source 
* agent/findkey.c (agent_write_private_key): Init FP.
--

With
Fixes-commit: 3b69d8bf7146b8d10737d0cfea9c97affc60ad73
we took a shortcut but forgot to init FP which is usually set after
the new check.  At least in the AppImage this always triggered a segv
and gpg or Kleopatra had to restart the agent.  Not a problem in 2.4
becuase this code is a hack we don't need in 2.4 due to that new
ephemeral key storing feature.

GnuPG-bug-id: 6944
This commit is contained in:
Werner Koch 2024-08-08 17:13:47 +02:00
parent 62bd291dcc
commit 80f25fab90
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
agent/findkey.c
View File

@ -91,7 +91,7 @@ agent_write_private_key (const unsigned char *grip,
gpg_error_t err; gpg_error_t err;
char *oldfname = NULL; char *oldfname = NULL;
char *fname = NULL; char *fname = NULL;
estream_t fp; estream_t fp = NULL;
int newkey = 0; int newkey = 0;
nvc_t pk = NULL; nvc_t pk = NULL;
gcry_sexp_t key = NULL; gcry_sexp_t key = NULL;