security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-03-28 22:49:59 +01:00
Code Activity

g10: Simplify get_seckey_byname: it was never called with NAME not NULL.

Browse Source 
* g10/keydb.h (get_seckey_byname): Rename from this...
(get_seckey_default): ... to this.  Drop the parameter name.  Update
users.
* g10/getkey.c (get_seckey_byname): Rename from this...
(get_seckey_default): ... to this.  Drop the parameter name.  Drop the
code which assumed that NAME is not NULL.

--
Signed-off-by: Neal H. Walfield <neal@g10code.com>.
This commit is contained in:
Neal H. Walfield 2015-09-14 21:14:00 +02:00
parent dc69804ab0
commit 80dbf8006f
3 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
g10/getkey.c
View File

@ -1029,19 +1029,14 @@ get_pubkey_byfprint_fast (PKT_public_key * pk,
* the default key. This functions checks that a corresponding secret * the default key. This functions checks that a corresponding secret
* key is available. With no secret key it does not succeeed. */ * key is available. With no secret key it does not succeeed. */
gpg_error_t gpg_error_t
get_seckey_byname (PKT_public_key *pk, const char *name) get_seckey_default (PKT_public_key *pk)
{ {
gpg_error_t err; gpg_error_t err;
strlist_t namelist = NULL; strlist_t namelist = NULL;
int include_unusable = 1; int include_unusable = 1;
/* If we have no name, try to use the default secret key. If we if (opt.def_secret_key && *opt.def_secret_key)
have no default, we'll use the first usable one. */
if (!name && opt.def_secret_key && *opt.def_secret_key)
add_to_strlist (&namelist, opt.def_secret_key); add_to_strlist (&namelist, opt.def_secret_key);
else if (name)
add_to_strlist (&namelist, name);
else else
include_unusable = 0; include_unusable = 0;

2
g10/keydb.h
View File

@ -419,7 +419,7 @@ int get_pubkey_byfprint_fast (PKT_public_key *pk,
whether there is some secret key with the specified key id. */ whether there is some secret key with the specified key id. */
int have_secret_key_with_kid (u32 *keyid); int have_secret_key_with_kid (u32 *keyid);
gpg_error_t get_seckey_byname (PKT_public_key *pk, const char *name); gpg_error_t get_seckey_default (PKT_public_key *pk);
gpg_error_t get_seckey_byfprint (PKT_public_key *pk, gpg_error_t get_seckey_byfprint (PKT_public_key *pk,
const byte *fprint, size_t fprint_len); const byte *fprint, size_t fprint_len);

2
g10/pkclist.c
View File

@ -714,7 +714,7 @@ default_recipient(void)
if( !opt.def_recipient_self ) if( !opt.def_recipient_self )
return NULL; return NULL;
pk = xmalloc_clear( sizeof *pk ); pk = xmalloc_clear( sizeof *pk );
i = get_seckey_byname (pk, NULL); i = get_seckey_default (pk);
if( i ) { if( i ) {
free_public_key( pk ); free_public_key( pk );
return NULL; return NULL;