security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00
Code Activity

g10: Fix regression of card-edit/fetch.

Browse Source 
* g10/card-util.c (fetch_url): Call keyserver_fetch instead of
keyserver_import_fprint.

--
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
This commit is contained in:
NIIBE Yutaka 2016-06-23 12:12:43 +09:00
parent da63f15d98
commit 6f5ff1cfe4
1 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
g10/card-util.c
View File

@ -733,28 +733,18 @@ fetch_url (ctrl_t ctrl)
log_error("error retrieving URL from card: %s\n",gpg_strerror(rc)); log_error("error retrieving URL from card: %s\n",gpg_strerror(rc));
else else
{ {
struct keyserver_spec *spec=NULL;
rc=agent_scd_getattr("KEY-FPR",&info); rc=agent_scd_getattr("KEY-FPR",&info);
if(rc) if(rc)
log_error("error retrieving key fingerprint from card: %s\n", log_error("error retrieving key fingerprint from card: %s\n",
gpg_strerror(rc)); gpg_strerror(rc));
else if (info.pubkey_url && *info.pubkey_url) else if (info.pubkey_url && *info.pubkey_url)
{ {
spec = parse_keyserver_uri (info.pubkey_url, 1); strlist_t sl = NULL;
if(spec && info.fpr1valid)
{ add_to_strlist (&sl, info.pubkey_url);
/* This is not perfectly right. Currently, all card rc = keyserver_fetch (ctrl, sl);
fingerprints are 20 digits, but what about free_strlist (sl);
fingerprints for a future v5 key? We should get the }
length from somewhere lower in the code. In any
event, the fpr/keyid is not meaningful for straight
HTTP fetches, but using it allows the card to point
to HKP and LDAP servers as well. */
rc = keyserver_import_fprint (ctrl, info.fpr1, 20, spec);
free_keyserver_spec(spec);
}
}
else if (info.fpr1valid) else if (info.fpr1valid)
{ {
rc = keyserver_import_fprint (ctrl, info.fpr1, 20, opt.keyserver); rc = keyserver_import_fprint (ctrl, info.fpr1, 20, opt.keyserver);