security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-06-17 00:39:50 +02:00
Code Activity

mpi: Avoid data-dependent timing variations in mpi_powm.

Browse Source 
* include/mpi.h, mpi/mpiutils.c (mpi_set_cond): New.
* mpi/mpi-pow.c (SIZE_PRECOMP): Rename from SIZE_B_2I3.
(mpi_powm): Access all data in the table and use mpi_set_cond.

--

Access to the precomputed table was indexed by a portion of EXPO,
which could be mounted by a side channel attack.  This change fixes
this particular data-dependent access pattern.
This commit is contained in:
NIIBE Yutaka 2015-02-26 21:00:05 +09:00
parent 6186637cc9
commit 6cbc75e712
3 changed files with 82 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/mpi.h
View File

@ -81,6 +81,7 @@ void *mpi_get_opaque( MPI a, unsigned int *len );
void mpi_set_secure( MPI a ); void mpi_set_secure( MPI a );
void mpi_clear( MPI a ); void mpi_clear( MPI a );
void mpi_set( MPI w, MPI u); void mpi_set( MPI w, MPI u);
void mpi_set_cond( MPI w, MPI u, unsigned long set);
void mpi_set_ui( MPI w, ulong u); void mpi_set_ui( MPI w, ulong u);
MPI mpi_alloc_set_ui( unsigned long u); MPI mpi_alloc_set_ui( unsigned long u);
void mpi_m_check( MPI a ); void mpi_m_check( MPI a );

93
mpi/mpi-pow.c
View File

@ -344,7 +344,7 @@ mul_mod (mpi_ptr_t xp, mpi_size_t *xsize_p,
*xsize_p = rsize + ssize; *xsize_p = rsize + ssize;
} }
#define SIZE_B_2I3 ((1 << (5 - 1)) - 1) #define SIZE_PRECOMP ((1 << (5 - 1)))
/**************** /****************
* RES = BASE ^ EXPO mod MOD * RES = BASE ^ EXPO mod MOD
@ -375,11 +375,12 @@ mpi_powm (MPI res, MPI base, MPI expo, MPI mod)
mpi_ptr_t bp_marker = NULL; mpi_ptr_t bp_marker = NULL;
mpi_ptr_t ep_marker = NULL; mpi_ptr_t ep_marker = NULL;
mpi_ptr_t xp_marker = NULL; mpi_ptr_t xp_marker = NULL;
mpi_ptr_t b_2i3[SIZE_B_2I3]; /* Pre-computed array: BASE^3, ^5, ^7, ... */ mpi_ptr_t precomp[SIZE_PRECOMP]; /* Pre-computed array: BASE^1, ^3, ^5, ... */
mpi_size_t b_2i3size[SIZE_B_2I3]; mpi_size_t precomp_size[SIZE_PRECOMP];
mpi_size_t W; mpi_size_t W;
mpi_ptr_t base_u; mpi_ptr_t base_u;
mpi_size_t base_u_size; mpi_size_t base_u_size;
mpi_size_t max_u_size;
esize = expo->nlimbs; esize = expo->nlimbs;
msize = mod->nlimbs; msize = mod->nlimbs;
@ -493,7 +494,7 @@ mpi_powm (MPI res, MPI base, MPI expo, MPI mod)
/* Main processing. */ /* Main processing. */
{ {
mpi_size_t i, j; mpi_size_t i, j, k;
mpi_ptr_t xp; mpi_ptr_t xp;
mpi_size_t xsize; mpi_size_t xsize;
int c; int c;
@ -507,33 +508,29 @@ mpi_powm (MPI res, MPI base, MPI expo, MPI mod)
memset( &karactx, 0, sizeof karactx ); memset( &karactx, 0, sizeof karactx );
negative_result = (ep[0] & 1) && bsign; negative_result = (ep[0] & 1) && bsign;
/* Precompute B_2I3[], BASE^(2 * i + 3), BASE^3, ^5, ^7, ... */ /* Precompute PRECOMP[], BASE^(2 * i + 1), BASE^1, ^3, ^5, ... */
if (W > 1) /* X := BASE^2 */ if (W > 1) /* X := BASE^2 */
mul_mod (xp, &xsize, bp, bsize, bp, bsize, mp, msize, &karactx); mul_mod (xp, &xsize, bp, bsize, bp, bsize, mp, msize, &karactx);
for (i = 0; i < (1 << (W - 1)) - 1; i++) base_u = precomp[0] = mpi_alloc_limb_space (bsize, esec);
{ /* B_2I3[i] = BASE^(2 * i + 3) */ base_u_size = max_u_size = precomp_size[0] = bsize;
if (i == 0) MPN_COPY (precomp[0], bp, bsize);
{ for (i = 1; i < (1 << (W - 1)); i++)
base_u = bp; { /* PRECOMP[i] = BASE^(2 * i + 1) */
base_u_size = bsize;
}
else
{
base_u = b_2i3[i-1];
base_u_size = b_2i3size[i-1];
}
if (xsize >= base_u_size) if (xsize >= base_u_size)
mul_mod (rp, &rsize, xp, xsize, base_u, base_u_size, mul_mod (rp, &rsize, xp, xsize, base_u, base_u_size,
mp, msize, &karactx); mp, msize, &karactx);
else else
mul_mod (rp, &rsize, base_u, base_u_size, xp, xsize, mul_mod (rp, &rsize, base_u, base_u_size, xp, xsize,
mp, msize, &karactx); mp, msize, &karactx);
b_2i3[i] = mpi_alloc_limb_space (rsize, esec); base_u = precomp[i] = mpi_alloc_limb_space (rsize, esec);
b_2i3size[i] = rsize; base_u_size = precomp_size[i] = rsize;
MPN_COPY (b_2i3[i], rp, rsize); if (max_u_size < base_u_size)
max_u_size = base_u_size;
MPN_COPY (precomp[i], rp, rsize);
} }
base_u = mpi_alloc_limb_space (max_u_size, esec);
i = esize - 1; i = esize - 1;
/* Main loop. /* Main loop.
@ -619,17 +616,26 @@ mpi_powm (MPI res, MPI base, MPI expo, MPI mod)
rsize = xsize; rsize = xsize;
} }
if (e0 == 0) /*
* base_u <= precomp[e0]
* base_u_size <= precomp_size[e0];
*/
base_u_size = 0;
for (k = 0; k < (1<< (W - 1)); k++)
{ {
base_u = bp; struct gcry_mpi w, u;
base_u_size = bsize; w.alloced = w.nlimbs = precomp_size[k];
} u.alloced = u.nlimbs = precomp_size[k];
else w.nbits = w.nlimbs * BITS_PER_MPI_LIMB;
{ u.nbits = u.nlimbs * BITS_PER_MPI_LIMB;
base_u = b_2i3[e0 - 1]; w.sign = u.sign = 0;
base_u_size = b_2i3size[e0 -1]; w.flags = u.flags = 0;
} w.d = base_u;
u.d = precomp[k];
mpi_set_cond (&w, &u, k == e0);
base_u_size |= (precomp_size[k] & ((mpi_size_t)0 - (k == e0)) );
}
mul_mod (xp, &xsize, rp, rsize, base_u, base_u_size, mul_mod (xp, &xsize, rp, rsize, base_u, base_u_size,
mp, msize, &karactx); mp, msize, &karactx);
tp = rp; rp = xp; xp = tp; tp = rp; rp = xp; xp = tp;
@ -655,15 +661,21 @@ mpi_powm (MPI res, MPI base, MPI expo, MPI mod)
if (e != 0) if (e != 0)
{ {
if ((e>>1) == 0) base_u_size = 0;
for (k = 0; k < (1<< (W - 1)); k++)
{ {
base_u = bp; struct gcry_mpi w, u;
base_u_size = bsize; w.alloced = w.nlimbs = precomp_size[k];
} u.alloced = u.nlimbs = precomp_size[k];
else w.nbits = w.nlimbs * BITS_PER_MPI_LIMB;
{ u.nbits = u.nlimbs * BITS_PER_MPI_LIMB;
base_u = b_2i3[(e>>1) - 1]; w.sign = u.sign = 0;
base_u_size = b_2i3size[(e>>1) -1]; w.flags = u.flags = 0;
w.d = base_u;
u.d = precomp[k];
mpi_set_cond (&w, &u, k == (e>>1));
base_u_size |= (precomp_size[k] & ((mpi_size_t)0 - (k == (e>>1))) );
} }
mul_mod (xp, &xsize, rp, rsize, base_u, base_u_size, mul_mod (xp, &xsize, rp, rsize, base_u, base_u_size,
@ -713,8 +725,9 @@ mpi_powm (MPI res, MPI base, MPI expo, MPI mod)
MPN_NORMALIZE (rp, rsize); MPN_NORMALIZE (rp, rsize);
mpihelp_release_karatsuba_ctx (&karactx ); mpihelp_release_karatsuba_ctx (&karactx );
for (i = 0; i < (1 << (W - 1)) - 1; i++) for (i = 0; i < (1 << (W - 1)); i++)
mpi_free_limb_space (b_2i3[i]); mpi_free_limb_space (precomp[i]);
mpi_free_limb_space (base_u);
} }
/* Fixup for negative results. */ /* Fixup for negative results. */

28
mpi/mpiutil.c
View File

@ -432,6 +432,34 @@ mpi_set( MPI w, MPI u)
} }
void
mpi_set_cond( MPI w, MPI u, unsigned long set)
{
mpi_size_t i;
mpi_size_t nlimbs = u->alloced;
mpi_limb_t mask = ((mpi_limb_t)0) - !!set;
mpi_limb_t x;
if (w->alloced != u->alloced)
log_bug ("mpi_set_cond: different sizes\n");
for (i = 0; i < nlimbs; i++)
{
x = mask & (w->d[i] ^ u->d[i]);
w->d[i] = w->d[i] ^ x;
}
x = mask & (w->nlimbs ^ u->nlimbs);
w->nlimbs = w->nlimbs ^ x;
x = mask & (w->nbits ^ u->nbits);
w->nbits = w->nbits ^ x;
x = mask & (w->sign ^ u->sign);
w->sign = w->sign ^ x;
}
void void
mpi_set_ui( MPI w, unsigned long u) mpi_set_ui( MPI w, unsigned long u)
{ {