From 693e657ff04756737dce025203c0deba480ea8de Mon Sep 17 00:00:00 2001 From: NIIBE Yutaka Date: Fri, 21 Oct 2016 16:27:46 +0900 Subject: [PATCH] scd: Fix segfault changing key attr. * asc/app-openpgp.c (change_keyattr_from_string): Release after allocated. -- Signed-off-by: NIIBE Yutaka --- scd/app-openpgp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scd/app-openpgp.c b/scd/app-openpgp.c index 093109501..f909c6f2c 100644 --- a/scd/app-openpgp.c +++ b/scd/app-openpgp.c @@ -2987,7 +2987,6 @@ change_keyattr_from_string (app_t app, size_t oid_len; oidstr = openpgp_curve_to_oid (string+n, NULL); - gcry_mpi_release (oid); if (!oidstr) { err = gpg_error (GPG_ERR_INV_DATA); @@ -3005,6 +3004,7 @@ change_keyattr_from_string (app_t app, string[0] = algo; memcpy (string+1, oidbuf+1, oid_len-1); err = change_keyattr (app, keyno, string, oid_len, pincb, pincb_arg); + gcry_mpi_release (oid); } else err = gpg_error (GPG_ERR_PUBKEY_ALGO);