security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-21 14:47:03 +01:00
Code Activity

dirmngr: Only report hkps scheme when available

Browse Source 
* dirmngr/ks-engine-hkp.c (ks_hkp_help): Make use of TLS macros.

--
Only report support for the hkps scheme when GnuPG / dirmngr
has been built with a TLS library.

This helps debuging and enable the user to detect whether support
for hkps is included by doing a
`gpg-connect-agent --dirmngr 'keyserver --help' /bye`.
Currently hkps will be listed as a supported scheme but trying to
add a keyserver using it will silently fail.

As a digression, https is never listed as a valid scheme.
This commit is contained in:
Kristian Fiskerstrand 2014-11-25 19:24:18 +01:00 committed by Werner Koch
parent 1c2140346d
commit 68a7ccc0c8
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dirmngr/ks-engine-hkp.c
View File

@ -767,12 +767,20 @@ ks_hkp_help (ctrl_t ctrl, parsed_uri_t uri)
const char const data[] = const char const data[] =
"Handler for HKP URLs:\n" "Handler for HKP URLs:\n"
" hkp://\n" " hkp://\n"
#if HTTP_USE_GNUTLS || HTTP_USE_NTBTLS
" hkps://\n" " hkps://\n"
#endif
"Supported methods: search, get, put\n"; "Supported methods: search, get, put\n";
gpg_error_t err; gpg_error_t err;
#if HTTP_USE_GNUTLS || HTTP_USE_NTBTLS
const char data2[] = " hkp\n hkps";
#else
const char data2[] = " hkp";
#endif
if (!uri) if (!uri)
err = ks_print_help (ctrl, " hkp\n hkps"); err = ks_print_help (ctrl, data2);
else if (uri->is_http && (!strcmp (uri->scheme, "hkp") else if (uri->is_http && (!strcmp (uri->scheme, "hkp")
|| !strcmp (uri->scheme, "hkps"))) || !strcmp (uri->scheme, "hkps")))
err = ks_print_help (ctrl, data); err = ks_print_help (ctrl, data);