security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-03-28 22:49:59 +01:00
Code Activity

g10: Bring cache semantics closer to non-cache semantics.

Browse Source 
* g10/getkey.c (get_pubkey_fast): When reading from the cache, only
consider primary keys.

--
Signed-off-by: Neal H. Walfield <neal@g10code.com>.
This commit is contained in:
Neal H. Walfield 2015-09-16 13:13:46 +02:00
parent 3940f10af7
commit 5e233e12f5
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
g10/getkey.c
View File

@ -437,7 +437,10 @@ get_pubkey_fast (PKT_public_key * pk, u32 * keyid)
for (ce = pk_cache; ce; ce = ce->next) for (ce = pk_cache; ce; ce = ce->next)
{ {
if (ce->keyid[0] == keyid[0] && ce->keyid[1] == keyid[1]) if (ce->keyid[0] == keyid[0] && ce->keyid[1] == keyid[1]
/* Only consider primary keys. */
&& ce->pk->keyid[0] == ce->pk->main_keyid[0]
&& ce->pk->keyid[1] == ce->pk->main_keyid[1])
{ {
if (pk) if (pk)
copy_public_key (pk, ce->pk); copy_public_key (pk, ce->pk);
@ -463,9 +466,10 @@ get_pubkey_fast (PKT_public_key * pk, u32 * keyid)
} }
assert (keyblock && keyblock->pkt assert (keyblock && keyblock->pkt
&& (keyblock->pkt->pkttype == PKT_PUBLIC_KEY && keyblock->pkt->pkttype == PKT_PUBLIC_KEY);
|| keyblock->pkt->pkttype == PKT_PUBLIC_SUBKEY));
/* We return the primary key. If KEYID matched a subkey, then we
return an error. */
keyid_from_pk (keyblock->pkt->pkt.public_key, pkid); keyid_from_pk (keyblock->pkt->pkt.public_key, pkid);
if (keyid[0] == pkid[0] && keyid[1] == pkid[1]) if (keyid[0] == pkid[0] && keyid[1] == pkid[1])
copy_public_key (pk, keyblock->pkt->pkt.public_key); copy_public_key (pk, keyblock->pkt->pkt.public_key);