security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-03 12:11:33 +01:00
Code Activity

gpg: Put extra parens around bit tests.

Browse Source 
* g10/options.h (DBG_MPI): New.
* g10/gpg.c (set_debug): Use macro or extra parens for binary operator.
* g10/parse-packet.c (set_packet_list_mode): Use dbg macro.

Signed-off-by: Werner Koch <wk@gnupg.org>
This commit is contained in:
Werner Koch 2016-10-07 07:54:38 +02:00
parent fc0b392e76
commit 5d43d28aa3
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
4 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/HACKING
View File

@ -174,6 +174,8 @@ Note that such a comment will be removed if the git commit option
indicate a problem with the code.
- Never init static or file local variables to 0 to make sure they
end up in BSS.
- But extra parenthesis around terms with binary operators to make
it clear that the binary operator was indeed intended.
- Use --enable-maintainer-mode with configure so that all suitable
warnings are enabled.

10
g10/gpg.c
View File

@ -1190,15 +1190,15 @@ set_debug (const char *level)
g10_exit (2);
}
if (opt.debug & DBG_MEMORY_VALUE )
if ((opt.debug & DBG_MEMORY_VALUE))
memory_debug_mode = 1;
if (opt.debug & DBG_MEMSTAT_VALUE )
if ((opt.debug & DBG_MEMSTAT_VALUE))
memory_stat_debug_mode = 1;
if (opt.debug & DBG_MPI_VALUE)
if (DBG_MPI)
gcry_control (GCRYCTL_SET_DEBUG_FLAGS, 2);
if (opt.debug & DBG_CRYPTO_VALUE )
if (DBG_CRYPTO)
gcry_control (GCRYCTL_SET_DEBUG_FLAGS, 1);
if (opt.debug & DBG_IOBUF_VALUE )
if ((opt.debug & DBG_IOBUF_VALUE))
iobuf_debug_mode = 1;
gcry_control (GCRYCTL_SET_VERBOSITY, (int)opt.verbose);

3
g10/options.h
View File

@ -305,6 +305,7 @@ struct {
/* Tests for the debugging flags. */
#define DBG_PACKET (opt.debug & DBG_PACKET_VALUE)
#define DBG_MPI (opt.debug & DBG_MPI_VALUE)
#define DBG_CRYPTO (opt.debug & DBG_CRYPTO_VALUE)
#define DBG_FILTER (opt.debug & DBG_FILTER_VALUE)
#define DBG_CACHE (opt.debug & DBG_CACHE_VALUE)
@ -317,7 +318,7 @@ struct {
#define DBG_LOOKUP (opt.debug & DBG_LOOKUP_VALUE)
#define DBG_EXTPROG (opt.debug & DBG_EXTPROG_VALUE)
/* FIXME: We need to check whey we did not put this into opt. */
/* FIXME: We need to check why we did not put this into opt. */
#define DBG_MEMORY memory_debug_mode
#define DBG_MEMSTAT memory_stat_debug_mode

2
g10/parse-packet.c
View File

@ -220,7 +220,7 @@ set_packet_list_mode (int mode)
else
listfp = es_stderr;
if (opt.debug & DBG_MPI_VALUE)
if (DBG_MPI)
mpi_print_mode = 1;
}
return old;