security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-04-17 15:44:34 +02:00
Code Activity

scd: Debug output is only enabled with an option.

Browse Source 
* scd/command.c (pin_cb): Check if DBG_IPC for log_debug.
(send_client_notifications): Check opt.verbose to output a message.

--

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
This commit is contained in:
NIIBE Yutaka 2023-12-18 11:25:01 +09:00
parent 37fa36a329
commit 4e94b004a6
No known key found for this signature in database
GPG Key ID: 640114AF89DE6054
1 changed files with 22 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
scd/command.c
View File

@ -957,6 +957,7 @@ pin_cb (void *opaque, const char *info, char **retstr)
We ignore any value returned. */ We ignore any value returned. */
if (info) if (info)
{ {
if (DBG_IPC)
log_debug ("prompting for pinpad entry '%s'\n", info); log_debug ("prompting for pinpad entry '%s'\n", info);
rc = gpgrt_asprintf (&command, "POPUPPINPADPROMPT %s", info); rc = gpgrt_asprintf (&command, "POPUPPINPADPROMPT %s", info);
if (rc < 0) if (rc < 0)
@ -966,6 +967,7 @@ pin_cb (void *opaque, const char *info, char **retstr)
} }
else else
{ {
if (DBG_IPC)
log_debug ("dismiss pinpad entry prompt\n"); log_debug ("dismiss pinpad entry prompt\n");
rc = assuan_inquire (ctx, "DISMISSPINPADPROMPT", rc = assuan_inquire (ctx, "DISMISSPINPADPROMPT",
&value, &valuelen, MAXLEN_PIN); &value, &valuelen, MAXLEN_PIN);
@ -976,6 +978,7 @@ pin_cb (void *opaque, const char *info, char **retstr)
} }
*retstr = NULL; *retstr = NULL;
if (DBG_IPC)
log_debug ("asking for PIN '%s'\n", info); log_debug ("asking for PIN '%s'\n", info);
rc = gpgrt_asprintf (&command, "NEEDPIN %s", info); rc = gpgrt_asprintf (&command, "NEEDPIN %s", info);
@ -2989,10 +2992,14 @@ send_client_notifications (card_t card, int removal)
if (killed[kidx].handle == handle) if (killed[kidx].handle == handle)
break; break;
if (kidx < killidx) if (kidx < killidx)
{
if (opt.verbose)
log_info ("event %p already triggered for client\n", log_info ("event %p already triggered for client\n",
sl->event_signal); sl->event_signal);
}
else else
{ {
if (opt.verbose)
log_info ("triggering event %p for client\n", log_info ("triggering event %p for client\n",
sl->event_signal); sl->event_signal);
if (!SetEvent (handle)) if (!SetEvent (handle))
@ -3015,10 +3022,14 @@ send_client_notifications (card_t card, int removal)
&& killed[kidx].signo == signo) && killed[kidx].signo == signo)
break; break;
if (kidx < killidx) if (kidx < killidx)
{
if (opt.verbose)
log_info ("signal %d already sent to client %d\n", log_info ("signal %d already sent to client %d\n",
signo, (int)pid); signo, (int)pid);
}
else else
{ {
if (opt.verbose)
log_info ("sending signal %d to client %d\n", log_info ("sending signal %d to client %d\n",
signo, (int)pid); signo, (int)pid);
kill (pid, signo); kill (pid, signo);