security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-05 12:31:50 +01:00
Code Activity

2006-04-01 Moritz Schulte <moritz@g10code.com>

Browse Source 
* command-ssh.c (ssh_identity_register): Make KEY_GRIP_RAW be 20
	instead of 21 bytes long; do not fill KEY_GRIP_RAW[20] with NUL
	byte - KEY_GRIP_RAW is a raw binary string anyway.
This commit is contained in:
Moritz Schulte 2006-04-01 11:04:14 +00:00
parent 79f749fec9
commit 4a31738bd1
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
agent/ChangeLog
View File

@ -1,3 +1,9 @@
2006-04-01 Moritz Schulte <moritz@g10code.com>
* command-ssh.c (ssh_identity_register): Make KEY_GRIP_RAW be 20
instead of 21 bytes long; do not fill KEY_GRIP_RAW[20] with NUL
byte - KEY_GRIP_RAW is a raw binary string anyway.
2006-02-09 Werner Koch <wk@g10code.com> 2006-02-09 Werner Koch <wk@g10code.com>
* call-scd.c (struct scd_local_s): New field next_local. * call-scd.c (struct scd_local_s): New field next_local.

4
agent/command-ssh.c
View File

@ -2321,7 +2321,7 @@ static gpg_error_t
ssh_identity_register (ctrl_t ctrl, gcry_sexp_t key, int ttl) ssh_identity_register (ctrl_t ctrl, gcry_sexp_t key, int ttl)
{ {
gpg_error_t err; gpg_error_t err;
unsigned char key_grip_raw[21]; unsigned char key_grip_raw[20];
char key_grip[41]; char key_grip[41];
unsigned char *buffer = NULL; unsigned char *buffer = NULL;
unsigned int buffer_n; unsigned int buffer_n;
@ -2334,8 +2334,6 @@ ssh_identity_register (ctrl_t ctrl, gcry_sexp_t key, int ttl)
if (err) if (err)
goto out; goto out;
key_grip_raw[sizeof (key_grip_raw) - 1] = 0; /* FIXME: Why?? */
/* Check whether the key is already in our key storage. Don't do /* Check whether the key is already in our key storage. Don't do
anything then. */ anything then. */
if ( !agent_key_available (key_grip_raw) ) if ( !agent_key_available (key_grip_raw) )