From 3bd793256e2e4be52075d50ccf2df70c4a2e1a0f Mon Sep 17 00:00:00 2001 From: Andre Heinecke Date: Wed, 2 May 2018 14:01:33 +0200 Subject: [PATCH] common,w32: Hide spawned processes by default * common/exechelp-w32.c (gnupg_spawn_process): Use SW_HIDE instead of SW_MINIMIZE. -- Spawning minimized shows icons in the task bar so users see that background processes are started, which is unusual. I'm pretty sure that the intention of the code was to hide the window if not in spawn debug mode. This is also what GPGME does. This fixes dirmngr_ldap process windows and other spurious reports about e.g. a gpgv console window from loadswdb. GnuPG-Bug-Id: T3937 Signed-off-by: Andre Heinecke --- common/exechelp-w32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/exechelp-w32.c b/common/exechelp-w32.c index 2c44e2c75..da174508e 100644 --- a/common/exechelp-w32.c +++ b/common/exechelp-w32.c @@ -555,7 +555,7 @@ gnupg_spawn_process (const char *pgmname, const char *argv[], memset (&si, 0, sizeof si); si.cb = sizeof (si); si.dwFlags = STARTF_USESTDHANDLES | STARTF_USESHOWWINDOW; - si.wShowWindow = DEBUG_W32_SPAWN? SW_SHOW : SW_MINIMIZE; + si.wShowWindow = DEBUG_W32_SPAWN? SW_SHOW : SW_HIDE; si.hStdInput = inpipe[0] == INVALID_HANDLE_VALUE? nullhd[0] : inpipe[0]; si.hStdOutput = outpipe[1] == INVALID_HANDLE_VALUE? nullhd[1] : outpipe[1]; si.hStdError = errpipe[1] == INVALID_HANDLE_VALUE? nullhd[2] : errpipe[1];