security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-08 12:44:23 +01:00
Code Activity

tools: Fix FILE memory leak in gpg-connect-agent.

Browse Source 
* tools/gpg-connect-agent.c (do_open): dup the fileno and close the
stream.

GnuPG-bug-id: 4220
Signed-off-by: Werner Koch <wk@gnupg.org>
This commit is contained in:
Werner Koch 2018-10-24 20:04:52 +02:00
parent 793fd8d876
commit 378719f25f
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/gpg-connect-agent.c
View File

@ -983,7 +983,7 @@ do_open (char *line)
name, mode, strerror (errno)); name, mode, strerror (errno));
return; return;
} }
fd = fileno (fp); fd = dup (fileno (fp));
if (fd >= 0 && fd < DIM (open_fd_table)) if (fd >= 0 && fd < DIM (open_fd_table))
{ {
open_fd_table[fd].inuse = 1; open_fd_table[fd].inuse = 1;
@ -1030,8 +1030,10 @@ do_open (char *line)
else else
{ {
log_error ("can't put fd %d into table\n", fd); log_error ("can't put fd %d into table\n", fd);
close (fd); if (fd != -1)
close (fd); /* Table was full. */
} }
fclose (fp);
} }