security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00
Code Activity

Use the longest key ID available when talking to a HKP server.

Browse Source 
This is issue 1340.  Now that PKSD is dead, and SKS supports long key
IDs, this is safe to do.  Patch from Daniel Kahn Gillmor
<dkg@fifthhorseman.net>.
This commit is contained in:
David Shaw 2011-12-28 16:41:31 -05:00
parent 5a0ed4a2cc
commit 3005b0a6f4
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
keyserver/gpgkeys_hkp.c
View File

@ -241,9 +241,10 @@ static int
get_key(char *getkey) get_key(char *getkey)
{ {
CURLcode res; CURLcode res;
char request[MAX_URL+60]; char request[MAX_URL+92];
char *offset; char *offset;
struct curl_writer_ctx ctx; struct curl_writer_ctx ctx;
size_t keylen;
memset(&ctx,0,sizeof(ctx)); memset(&ctx,0,sizeof(ctx));
@ -269,14 +270,19 @@ get_key(char *getkey)
strcat(request,port); strcat(request,port);
strcat(request,opt->path); strcat(request,opt->path);
/* request is MAX_URL+55 bytes long - MAX_URL covers the whole URL, /* request is MAX_URL+55 bytes long - MAX_URL covers the whole URL,
including any supplied path. The 60 overcovers this /pks/... etc including any supplied path. The 92 overcovers this /pks/... etc
string plus the 8 bytes of key id */ string plus the 8, 16, or 40 bytes of key id/fingerprint */
append_path(request,"/pks/lookup?op=get&options=mr&search=0x"); append_path(request,"/pks/lookup?op=get&options=mr&search=0x");
/* fingerprint or long key id. Take the last 8 characters and treat /* send only fingerprint, long key id, or short keyid. see:
it like a short key id */ https://tools.ietf.org/html/draft-shaw-openpgp-hkp-00#section-3.1.1.1 */
if(strlen(getkey)>8) keylen = strlen(getkey);
offset=&getkey[strlen(getkey)-8]; if(keylen >= 40)
offset=&getkey[keylen-40];
else if(keylen >= 16)
offset=&getkey[keylen-16];
else if(keylen >= 8)
offset=&getkey[keylen-8];
else else
offset=getkey; offset=getkey;