security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-04-17 15:44:34 +02:00
Code Activity

card: Add password change menu for NKS cards.

Browse Source 
* tools/gpg-card.c (cmd_passwd): Add menu for NKS.  Add option
--reset.
--

Note that the resetting does not yet work due to some bug in
app-scd.c
This commit is contained in:
Werner Koch 2020-06-25 11:24:35 +02:00
parent 17a25c14f1
commit 28c069db3b
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 52 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
tools/gpg-card.c
View File

@ -2564,11 +2564,12 @@ cmd_passwd (card_info_t info, char *argstr)
if (!info) if (!info)
return print_help return print_help
("PASSWD [PINREF]\n\n" ("PASSWD [--reset] [PINREF]\n\n"
"Change or unblock the PINs. Note that in interactive mode\n" "Change or unblock the PINs. Note that in interactive mode\n"
"and without a PINREF a menu is presented for certain cards;\n" "and without a PINREF a menu is presented for certain cards;\n"
"in non-interactive and without a PINREF a default value is\n" "in non-interactive and without a PINREF a default value is\n"
"used for these cards.", "used for these cards. The option --reset is used with TCOS\n"
"cards to reset the PIN using the PUK or vice versa.\n",
0); 0);
if (opt.interactive || opt.verbose) if (opt.interactive || opt.verbose)
@ -2576,8 +2577,21 @@ cmd_passwd (card_info_t info, char *argstr)
app_type_string (info->apptype), app_type_string (info->apptype),
info->dispserialno? info->dispserialno : info->serialno); info->dispserialno? info->dispserialno : info->serialno);
if (*argstr)
pinref = argstr; if (has_option (argstr, "--reset"))
reset_mode = 1;
argstr = skip_options (argstr);
/* If --reset has been given we force non-interactive mode. */
if (*argstr || reset_mode)
{
pinref = argstr;
if (!*pinref)
{
err = gpg_error (GPG_ERR_MISSING_VALUE);
goto leave;
}
}
else if (opt.interactive && info->apptype == APP_TYPE_OPENPGP) else if (opt.interactive && info->apptype == APP_TYPE_OPENPGP)
{ {
menu_used = 1; menu_used = 1;
@ -2627,6 +2641,36 @@ cmd_passwd (card_info_t info, char *argstr)
pinref = "PIV.00"; pinref = "PIV.00";
} }
} }
else if (opt.interactive && info->apptype == APP_TYPE_NKS)
{
menu_used = 1;
while (!pinref)
{
xfree (answer);
answer = get_selection (" 1 - change Global PIN 1\n"
" 2 - change Global PUK\n"
" 3 - change SigG PIN 1\n"
" 4 - change SigG PUK\n"
"11 - reset Global PIN 1\n"
"12 - reset Global PUK\n"
"13 - reset Sig PIN\n"
"14 - reset Sig PUK\n"
" Q - quit\n");
if (!ascii_strcasecmp (answer, "q"))
goto leave;
else if (!strcmp (answer, "1") || !strcmp (answer, "11"))
pinref = "PW1.CH";
else if (!strcmp (answer, "2") || !strcmp (answer, "12"))
pinref = "PW2.CH";
else if (!strcmp (answer, "3") || !strcmp (answer, "13"))
pinref = "PW1.CH.SIG";
else if (!strcmp (answer, "4") || !strcmp (answer, "14"))
pinref = "PW2.CH.SIG";
/* Set reset mode for 11 to 14. */
if (pinref && strlen (answer) == 2)
reset_mode = 1;
}
}
else if (info->apptype == APP_TYPE_PIV) else if (info->apptype == APP_TYPE_PIV)
pinref = "PIV.80"; pinref = "PIV.80";
else else
@ -2648,6 +2692,8 @@ cmd_passwd (card_info_t info, char *argstr)
log_error ("Error setting the Reset Code.\n"); log_error ("Error setting the Reset Code.\n");
else if (!ascii_strcasecmp (pinref, "OPENPGP.3")) else if (!ascii_strcasecmp (pinref, "OPENPGP.3"))
log_error ("Error changing the Admin PIN.\n"); log_error ("Error changing the Admin PIN.\n");
else if (reset_mode)
log_error ("Error resetting the PIN.\n");
else else
log_error ("Error changing the PIN.\n"); log_error ("Error changing the PIN.\n");
} }
@ -2663,6 +2709,8 @@ cmd_passwd (card_info_t info, char *argstr)
log_info ("Reset Code set.\n"); log_info ("Reset Code set.\n");
else if (!ascii_strcasecmp (pinref, "OPENPGP.3")) else if (!ascii_strcasecmp (pinref, "OPENPGP.3"))
log_info ("Admin PIN changed.\n"); log_info ("Admin PIN changed.\n");
else if (reset_mode)
log_info ("PIN resetted.\n");
else else
log_info ("PIN changed.\n"); log_info ("PIN changed.\n");
} }