security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-04-17 15:44:34 +02:00
Code Activity

w32: Try more places to find an installed Pinentry.

Browse Source 
* common/homedir.c (get_default_pinentry_name): Re-implement to
support several choices for Windows.

Signed-off-by: Werner Koch <wk@gnupg.org>
This commit is contained in:
Werner Koch 2015-07-28 12:52:26 +02:00
parent 55e64f47a5
commit 18f1e627c6
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
2 changed files with 44 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
common/homedir.c
View File

@ -613,6 +613,26 @@ dirmngr_user_socket_name (void)
static const char * static const char *
get_default_pinentry_name (int reset) get_default_pinentry_name (int reset)
{ {
static struct {
const char *(*rfnc)(void);
const char *name;
} names[] = {
/* The first entry is what we return in case we found no
other pinentry. */
{ gnupg_bindir, DIRSEP_S "pinentry" EXEEXT_S },
#ifdef HAVE_W32_SYSTEM
/* Try Gpg4win directory (with bin and without.) */
{ w32_rootdir, "\\..\\Gpg4win\\bin\\pinentry.exe" },
{ w32_rootdir, "\\..\\Gpg4win\\pinentry.exe" },
/* Try old Gpgwin directory. */
{ w32_rootdir, "\\..\\GNU\\GnuPG\\pinentry.exe" },
/* Try a Pinentry from the common GNU dir. */
{ w32_rootdir, "\\..\\GNU\\bin\\pinentry.exe" },
#endif
/* Last chance is a pinentry-basic (which comes with the
GnuPG 2.1 Windows installer). */
{ gnupg_bindir, DIRSEP_S "pinentry-basic" EXEEXT_S }
};
static char *name; static char *name;
if (reset) if (reset)
@ -623,22 +643,27 @@ get_default_pinentry_name (int reset)
if (!name) if (!name)
{ {
name = xstrconcat (gnupg_bindir (), int i;
DIRSEP_S "pinentry" EXEEXT_S, NULL);
if (access (name, F_OK) && errno == ENOENT) for (i=0; i < DIM(names); i++)
{ {
char *name2; char *name2;
name2 = xstrconcat (gnupg_bindir (),
DIRSEP_S "pinentry-basic" EXEEXT_S, NULL); name2 = xstrconcat (names[i].rfnc (), names[i].name, NULL);
if (access (name2, F_OK)) if (!access (name2, F_OK))
xfree (name2); /* Does not exist. */
else /* Switch to pinentry-basic. */
{ {
/* Use that pinentry. */
xfree (name); xfree (name);
name = name2; name = name2;
break;
} }
if (!i) /* Store the first as fallback return. */
name = name2;
else
xfree (name2);
} }
} }
return name; return name;
} }

11
doc/gpg-agent.texi
View File

@ -403,6 +403,17 @@ installation dependent. With the default configuration the name of
the default pinentry is @file{pinentry}; if that file does not exist the default pinentry is @file{pinentry}; if that file does not exist
but a @file{pinentry-basic} exist the latter is used. but a @file{pinentry-basic} exist the latter is used.
On a Windows platform the default is to use the first existing program
from this list:
@file{bin\pinentry.exe},
@file{..\Gpg4win\bin\pinentry.exe},
@file{..\Gpg4win\pinentry.exe},
@file{..\GNU\GnuPG\pinentry.exe},
@file{..\GNU\bin\pinentry.exe},
@file{bin\pinentry-basic.exe}
where the file names are relative to the GnuPG installation directory.
@item --pinentry-touch-file @var{filename} @item --pinentry-touch-file @var{filename}
@opindex pinentry-touch-file @opindex pinentry-touch-file
By default the filename of the socket gpg-agent is listening for By default the filename of the socket gpg-agent is listening for