security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-02-01 16:33:02 +01:00
Code Activity

Fix bug#1307.

Browse Source
This commit is contained in:
Werner Koch 2011-01-10 19:35:10 +01:00
parent 344d72b2f7
commit 18936a1970
6 changed files with 35 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/ChangeLog
View File

@ -1,3 +1,9 @@
2011-01-10 Thomas Mraz <t8m@centrum.cz> (wk)
* pka.c (get_pka_info) [!USE_ADNS]: Turn ANSWER into a union to
avoid aliasing problems with modern compilers. See bug#1307.
Reported by Steve Grubb.
2011-01-10 Werner Koch <wk@g10code.com> 2011-01-10 Werner Koch <wk@g10code.com>
* session-env.c (update_var): Fix same value test. Fixes * session-env.c (update_var): Fix same value test. Fixes

22
common/pka.c
View File

@ -173,7 +173,11 @@ get_pka_info (const char *address, unsigned char *fpr)
return buffer; return buffer;
#else /*!USE_ADNS*/ #else /*!USE_ADNS*/
unsigned char answer[PACKETSZ]; union
{
signed char p[PACKETSZ];
HEADER h;
} answer;
int anslen; int anslen;
int qdcount, ancount, nscount, arcount; int qdcount, ancount, nscount, arcount;
int rc; int rc;
@ -192,11 +196,11 @@ get_pka_info (const char *address, unsigned char *fpr)
memcpy (name, address, domain - address); memcpy (name, address, domain - address);
strcpy (stpcpy (name + (domain-address), "._pka."), domain+1); strcpy (stpcpy (name + (domain-address), "._pka."), domain+1);
anslen = res_query (name, C_IN, T_TXT, answer, PACKETSZ); anslen = res_query (name, C_IN, T_TXT, answer.p, PACKETSZ);
xfree (name); xfree (name);
if (anslen < sizeof(HEADER)) if (anslen < sizeof(HEADER))
return NULL; /* DNS resolver returned a too short answer. */ return NULL; /* DNS resolver returned a too short answer. */
if ( (rc=((HEADER*)answer)->rcode) != NOERROR ) if ( (rc=answer.h.rcode) != NOERROR )
return NULL; /* DNS resolver returned an error. */ return NULL; /* DNS resolver returned an error. */
/* We assume that PACKETSZ is large enough and don't do dynmically /* We assume that PACKETSZ is large enough and don't do dynmically
@ -204,16 +208,16 @@ get_pka_info (const char *address, unsigned char *fpr)
if (anslen > PACKETSZ) if (anslen > PACKETSZ)
return NULL; /* DNS resolver returned a too long answer */ return NULL; /* DNS resolver returned a too long answer */
qdcount = ntohs (((HEADER*)answer)->qdcount); qdcount = ntohs (answer.h.qdcount);
ancount = ntohs (((HEADER*)answer)->ancount); ancount = ntohs (answer.h.ancount);
nscount = ntohs (((HEADER*)answer)->nscount); nscount = ntohs (answer.h.nscount);
arcount = ntohs (((HEADER*)answer)->arcount); arcount = ntohs (answer.h.arcount);
if (!ancount) if (!ancount)
return NULL; /* Got no answer. */ return NULL; /* Got no answer. */
p = answer + sizeof (HEADER); p = answer.p + sizeof (HEADER);
pend = answer + anslen; /* Actually points directly behind the buffer. */ pend = answer.p + anslen; /* Actually points directly behind the buffer. */
while (qdcount-- && p < pend) while (qdcount-- && p < pend)
{ {

11
g10/ChangeLog
View File

@ -1,3 +1,14 @@
2011-01-10 Werner Koch <wk@g10code.com>
* keygen.c (ask_user_id): Fix duplicate test for AMAIL by correct
ANAME. See bug#1307. Reported by Steve Grubb.
* import.c (import_keys_internal): Make loop code a bit more
readable. See bug#1307. Reported by Steve Grubb.
* sign.c (sign_file): Fix TEMP_HASHLEN computation. See bug#1307.
Reported by Steve Grubb.
2010-10-29 David Shaw <dshaw@jabberwocky.com> 2010-10-29 David Shaw <dshaw@jabberwocky.com>
* pkclist.c (select_algo_from_prefs): Make sure the scores can't * pkclist.c (select_algo_from_prefs): Make sure the scores can't

7
g10/import.c
View File

@ -175,10 +175,9 @@ import_keys_internal( IOBUF inp, char **fnames, int nnames,
rc = import( inp, "[stream]", stats, fpr, fpr_len, options); rc = import( inp, "[stream]", stats, fpr, fpr_len, options);
} }
else { else {
if( !fnames && !nnames ) int once = (!fnames && !nnames);
nnames = 1; /* Ohh what a ugly hack to jump into the loop */
for(i=0; i < nnames; i++ ) { for(i=0; once || i < nnames; once=0, i++ ) {
const char *fname = fnames? fnames[i] : NULL; const char *fname = fnames? fnames[i] : NULL;
IOBUF inp2 = iobuf_open(fname); IOBUF inp2 = iobuf_open(fname);
if( !fname ) if( !fname )
@ -201,8 +200,6 @@ import_keys_internal( IOBUF inp, char **fnames, int nnames,
log_error("import from `%s' failed: %s\n", fname, log_error("import from `%s' failed: %s\n", fname,
g10_errstr(rc) ); g10_errstr(rc) );
} }
if( !fname )
break;
} }
} }
if (!stats_handle) { if (!stats_handle) {

2
g10/keygen.c
View File

@ -2247,7 +2247,7 @@ ask_user_id (int mode, KBNODE keyblock)
xfree(answer); xfree(answer);
} }
xfree(answer); xfree(answer);
if( !amail && !acomment && !amail ) if( !aname && !acomment && !amail )
break; break;
xfree(uid); uid = NULL; xfree(uid); uid = NULL;
} }

4
g10/sign.c
View File

@ -867,8 +867,8 @@ sign_file( strlist_t filenames, int detached, strlist_t locusr,
{ {
if (sk_rover->sk->pubkey_algo == PUBKEY_ALGO_DSA) if (sk_rover->sk->pubkey_algo == PUBKEY_ALGO_DSA)
{ {
int temp_hashlen = gcry_mpi_get_nbits int temp_hashlen = (gcry_mpi_get_nbits
(sk_rover->sk->skey[1])+7/8; (sk_rover->sk->skey[1])+7)/8;
/* Pick a hash that is large enough for our /* Pick a hash that is large enough for our
largest q */ largest q */