security-and-privacy/gnupg
security-and-privacy
/
gnupg
mirror of git://git.gnupg.org/gnupg.git
1
0
Fork 0
Code Releases Activity

g10/plaintext: do_hash: use iobuf_read for higher performance 

* g10/plaintext.c (do_hash): Use iobuf_read instead of iobuf_get for
reading data; Use gcry_md_write instead of gcry_md_putc for hash data.
--

This patch reduces iobuf_read per byte processing overhead and speeds
up detached signature verifying.

Detached verifying speed on AMD Ryzen 5800X (4.3GiB file, SHA256):

         gpg process
         user time
 before: 9.410s
 after:  1.913s (4.9x faster)

GnuPG-bug-id: T5826
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>
(cherry picked from commit 4e27b9defc)
This commit is contained in:
Jussi Kivilinna 2022-02-10 19:53:53 +02:00 committed by Werner Koch
parent 11f3232716
commit 15b8d100c9
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
g10/plaintext.c
View File

@ -584,11 +584,16 @@ do_hash (gcry_md_hd_t md, gcry_md_hd_t md2, IOBUF fp, int textmode)
}
else
{
while ((c = iobuf_get (fp)) != -1)
byte *buffer = xmalloc (32768);
int ret;
while ((ret = iobuf_read (fp, buffer, 32768)) != -1)
{
if (md)
gcry_md_putc (md, c);
gcry_md_write (md, buffer, ret);
}
xfree (buffer);
}
}