From 13dc75a4e7cc2959003c08940fc53c6ece7b77e4 Mon Sep 17 00:00:00 2001 From: Andre Heinecke Date: Wed, 7 Jun 2017 15:30:14 +0200 Subject: [PATCH] speedo: Fix a minor memleak in the installer * build-aux/speedo/w32/g4wihelp.c (path_remove): Free path_new on early return. -- It's a weird condition in a once run function in a throwaway process but -- yeah. It's a memleak and static analysis can see it. GnuPG-Bug-Id: T3197 Signed-off-by: Andre Heinecke --- build-aux/speedo/w32/g4wihelp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build-aux/speedo/w32/g4wihelp.c b/build-aux/speedo/w32/g4wihelp.c index d62d03647..626f3f12c 100644 --- a/build-aux/speedo/w32/g4wihelp.c +++ b/build-aux/speedo/w32/g4wihelp.c @@ -1159,7 +1159,10 @@ path_remove (HWND hwndParent, int string_size, char *variables, free (path); if (! changed) - return; + { + free (path_new); + return; + } /* Set a key for our CLSID. */ RegCreateKey (root_key, env_reg, &key_handle);