mirror of
git://git.gnupg.org/gnupg.git
synced 2024-06-20 01:02:44 +02:00
dirmngr: Remove un-needed check.
* dirmngr/crlfetch.c (crl_fetch): Check that URL is not NULL. -- Reported-by: Joshua Rogers <git@internot.info> "Remove un-needed check. If 'url' were not to be true, http_parse_uri(parse_uri(do_parse_uri))) would fail, leaving 'err' false." In addition I added an explicit check for the URL arg not beeing NULL. Signed-off-by: Werner Koch <wk@gnupg.org>
This commit is contained in:
parent
abd5f6752d
commit
0d5cb55402
|
@ -163,10 +163,13 @@ crl_fetch (ctrl_t ctrl, const char *url, ksba_reader_t *reader)
|
||||||
|
|
||||||
*reader = NULL;
|
*reader = NULL;
|
||||||
|
|
||||||
|
if (!url)
|
||||||
|
return gpg_error (GPG_ERR_INV_ARG);
|
||||||
|
|
||||||
once_more:
|
once_more:
|
||||||
err = http_parse_uri (&uri, url, 0);
|
err = http_parse_uri (&uri, url, 0);
|
||||||
http_release_parsed_uri (uri);
|
http_release_parsed_uri (uri);
|
||||||
if (err && url && !strncmp (url, "https:", 6))
|
if (err && !strncmp (url, "https:", 6))
|
||||||
{
|
{
|
||||||
/* Our HTTP code does not support TLS, thus we can't use this
|
/* Our HTTP code does not support TLS, thus we can't use this
|
||||||
scheme and it is frankly not useful for CRL retrieval anyway.
|
scheme and it is frankly not useful for CRL retrieval anyway.
|
||||||
|
|
Loading…
Reference in New Issue
Block a user