security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-04-17 15:44:34 +02:00
Code Activity

* sign.c (do_sign): Accept a truncated hash even for DSA1 keys (be liberal

Browse Source 
in what you accept, etc).
This commit is contained in:
David Shaw 2006-06-22 19:17:21 +00:00
parent acbac61bff
commit 059c67ca6d
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
g10/ChangeLog
View File

@ -1,8 +1,13 @@
2006-06-22 David Shaw <dshaw@jabberwocky.com>
* sign.c (do_sign): Accept a truncated hash even for DSA1 keys (be
liberal in what you accept, etc).
2006-06-12 David Shaw <dshaw@jabberwocky.com> 2006-06-12 David Shaw <dshaw@jabberwocky.com>
* import.c (import_one): Add a flag (from_sk) so we don't check * import.c (import_one): Add a flag (from_sk) so we don't check
prefs on an autoconverted public key. The check should only prefs on an autoconverted public key. The check should only
happen on the sk size. Noted by Dirk Traulsen. happen on the sk side. Noted by Dirk Traulsen.
2006-06-09 David Shaw <dshaw@jabberwocky.com> 2006-06-09 David Shaw <dshaw@jabberwocky.com>

7
g10/sign.c
View File

@ -319,6 +319,12 @@ do_sign( PKT_secret_key *sk, PKT_signature *sig,
} }
else else
{ {
#if 0
/* Disabled for now. It seems reasonable to accept a
truncated hash for a DSA1 key, even though we don't
generate it without --enable-dsa2. Be liberal in what you
accept, etc. */
/* If it's a DSA key, and q is 160 bits, it might be an /* If it's a DSA key, and q is 160 bits, it might be an
old-style DSA key. If the hash doesn't match the q, fail old-style DSA key. If the hash doesn't match the q, fail
unless --enable-dsa2 is set. If the q isn't 160 bits, then unless --enable-dsa2 is set. If the q isn't 160 bits, then
@ -333,6 +339,7 @@ do_sign( PKT_secret_key *sk, PKT_signature *sig,
log_error(_("DSA requires the use of a 160 bit hash algorithm\n")); log_error(_("DSA requires the use of a 160 bit hash algorithm\n"));
return G10ERR_GENERAL; return G10ERR_GENERAL;
} }
#endif
frame = encode_md_value( NULL, sk, md, digest_algo ); frame = encode_md_value( NULL, sk, md, digest_algo );
if (!frame) if (!frame)