From 05277262bc2d4ebc42eb8ae76f5922010a36665a Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Fri, 5 Jan 2007 11:49:19 +0000 Subject: [PATCH] Add subjectAltName to the list of known critical extensions --- sm/ChangeLog | 4 ++++ sm/certchain.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/sm/ChangeLog b/sm/ChangeLog index a4807bf20..f249c73af 100644 --- a/sm/ChangeLog +++ b/sm/ChangeLog @@ -1,3 +1,7 @@ +2007-01-05 Werner Koch + + * certchain.c (unknown_criticals): Add subjectAltName. + 2006-12-21 Werner Koch * gpgsm.c: Comment mtrace feature. diff --git a/sm/certchain.c b/sm/certchain.c index 2745129eb..d4147b3f7 100644 --- a/sm/certchain.c +++ b/sm/certchain.c @@ -137,6 +137,12 @@ unknown_criticals (ksba_cert_t cert, int listmode, FILE *fp) { static const char *known[] = { "2.5.29.15", /* keyUsage */ + "2.5.29.17", /* subjectAltName + Japanese DoCoMo certs mark them as critical. PKIX + only requires them as critical if subjectName is + empty. I don't know whether our code gracefully + handles such empry subjectNames but that is + another story. */ "2.5.29.19", /* basic Constraints */ "2.5.29.32", /* certificatePolicies */ "2.5.29.37", /* extendedKeyUsage - handled by certlist.c */