security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-03 12:11:33 +01:00
Code Activity

scd:p15: Add pre-check for ascii-numeric PINs.

Browse Source 
* scd/app-p15.c (verify_pin): acii-numerix is different than BCD.
This commit is contained in:
Werner Koch 2021-06-18 18:02:08 +02:00
parent 544ec7872a
commit 029924a46e
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scd/app-p15.c
View File

@ -5145,7 +5145,6 @@ verify_pin (app_t app,
switch (aodf->pintype) switch (aodf->pintype)
{ {
case PIN_TYPE_BCD: case PIN_TYPE_BCD:
case PIN_TYPE_ASCII_NUMERIC:
for (s=pinvalue; digitp (s); s++) for (s=pinvalue; digitp (s); s++)
; ;
if (*s) if (*s)
@ -5154,6 +5153,15 @@ verify_pin (app_t app,
err = gpg_error (GPG_ERR_BAD_PIN); err = gpg_error (GPG_ERR_BAD_PIN);
} }
break; break;
case PIN_TYPE_ASCII_NUMERIC:
for (s=pinvalue; *s && !(*s & 0x80); s++)
;
if (*s)
{
errstr = "Non-ascii characters found in PIN";
err = gpg_error (GPG_ERR_BAD_PIN);
}
break;
case PIN_TYPE_UTF8: case PIN_TYPE_UTF8:
break; break;
case PIN_TYPE_HALF_NIBBLE_BCD: case PIN_TYPE_HALF_NIBBLE_BCD: