diff --git a/agent/gpg-agent.c b/agent/gpg-agent.c index e721d8a00..8c71e0d41 100644 --- a/agent/gpg-agent.c +++ b/agent/gpg-agent.c @@ -908,8 +908,10 @@ main (int argc, char **argv ) case oXauthority: default_xauthority = xstrdup (pargs.r.ret_str); break; - case oUseStandardSocket: /* dummy */ break; - case oNoUseStandardSocket: /* dummy */ break; + case oUseStandardSocket: + case oNoUseStandardSocket: + obsolete_option (configname, configlineno, "use-standard-socket"); + break; case oFakedSystemTime: { @@ -945,7 +947,9 @@ main (int argc, char **argv ) /* Only used by the first stage command line parser. */ break; - case oWriteEnvFile: /* dummy */ break; + case oWriteEnvFile: + obsolete_option (configname, configlineno, "write-env-file"); + break; default : pargs.err = configfp? 1:2; break; } diff --git a/common/miscellaneous.c b/common/miscellaneous.c index a0dae8fb1..8e71071f0 100644 --- a/common/miscellaneous.c +++ b/common/miscellaneous.c @@ -104,6 +104,7 @@ setup_libgcrypt_logging (void) gcry_set_outofcore_handler (my_gcry_outofcore_handler, NULL); } + /* A wrapper around gcry_cipher_algo_name to return the string "AES-128" instead of "AES". Given that we have an alias in libgcrypt for it, it does not harm to too much to return this other @@ -122,6 +123,19 @@ gnupg_cipher_algo_name (int algo) } +void +obsolete_option (const char *configname, unsigned int configlineno, + const char *name) +{ + if (configname) + log_info (_("%s:%u: obsolete option \"%s\" - it has no effect\n"), + configname, configlineno, name); + else + log_info (_("WARNING: \"%s%s\" is an obsolete option - it has no effect\n"), + "--", name); +} + + /* Decide whether the filename is stdout or a real filename and return * an appropriate string. */ const char * diff --git a/common/util.h b/common/util.h index 0e585df54..82e9887d6 100644 --- a/common/util.h +++ b/common/util.h @@ -370,6 +370,9 @@ char *xtryasprintf (const char *fmt, ...) GPGRT_GCC_A_PRINTF(1,2); /* Replacement for gcry_cipher_algo_name. */ const char *gnupg_cipher_algo_name (int algo); +void obsolete_option (const char *configname, unsigned int configlineno, + const char *name); + const char *print_fname_stdout (const char *s); const char *print_fname_stdin (const char *s); void print_utf8_buffer3 (estream_t fp, const void *p, size_t n, diff --git a/g10/main.h b/g10/main.h index 9370ae591..f4bf17f00 100644 --- a/g10/main.h +++ b/g10/main.h @@ -134,8 +134,6 @@ char *pct_expando(const char *string,struct expando_args *args); void deprecated_warning(const char *configname,unsigned int configlineno, const char *option,const char *repl1,const char *repl2); void deprecated_command (const char *name); -void obsolete_option (const char *configname, unsigned int configlineno, - const char *name); void obsolete_scdaemon_option (const char *configname, unsigned int configlineno, const char *name); diff --git a/g10/misc.c b/g10/misc.c index 654908d37..9134b2823 100644 --- a/g10/misc.c +++ b/g10/misc.c @@ -1012,19 +1012,6 @@ deprecated_command (const char *name) } -void -obsolete_option (const char *configname, unsigned int configlineno, - const char *name) -{ - if(configname) - log_info (_("%s:%u: obsolete option \"%s\" - it has no effect\n"), - configname, configlineno, name); - else - log_info (_("WARNING: \"%s%s\" is an obsolete option - it has no effect\n"), - "--", name); -} - - void obsolete_scdaemon_option (const char *configname, unsigned int configlineno, const char *name)