From ec1c5ae7d8302eca6a8444886e0b3ee274a0def8 Mon Sep 17 00:00:00 2001 From: kkapsner Date: Tue, 7 Nov 2017 19:51:49 +0100 Subject: [PATCH] Minor cleanups --- lib/main.js | 2 +- lib/settings.js | 3 ++- test/test.js | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/main.js b/lib/main.js index 4145fc3..bba2533 100644 --- a/lib/main.js +++ b/lib/main.js @@ -122,7 +122,7 @@ // hide page action when a tab is refreshed browser.tabs.onUpdated.addListener(function(tabId, data){ - if (data.status === "loading"){ + if (data.status && data.status === "loading"){ browser.pageAction.hide(tabId); } }); diff --git a/lib/settings.js b/lib/settings.js index cf8a331..725477b 100644 --- a/lib/settings.js +++ b/lib/settings.js @@ -74,7 +74,8 @@ name, { get: settingDefinition.get, - set: settingDefinition.set + set: settingDefinition.set, + enumerable: true } ); }); diff --git a/test/test.js b/test/test.js index 74fecce..e0b5244 100644 --- a/test/test.js +++ b/test/test.js @@ -1,4 +1,4 @@ - +/* eslint no-console: off */ (function(){ "use strict";