diff --git a/lib/frame.js b/lib/frame.js index 9b4dc84..cd37dce 100644 --- a/lib/frame.js +++ b/lib/frame.js @@ -45,6 +45,10 @@ message("open port to background script"); var port = browser.runtime.connect(); + if (window === window.top){ + message("Is top level window -> tab had navigation -> clear page action"); + port.postMessage({"canvasBlocker-clear-page-action": true}); + } var tabId; port.onMessage.addListener(function(data){ message("Got data from port", data); diff --git a/lib/main.js b/lib/main.js index ac184dc..2c3b804 100644 --- a/lib/main.js +++ b/lib/main.js @@ -64,6 +64,10 @@ browser.pageAction.show(port.sender.tab.id); } } + if (data.hasOwnProperty("canvasBlocker-clear-page-action")){ + notice("Hide page action for tab", port.sender.tab.id); + browser.pageAction.hide(port.sender.tab.id); + } verbose("got data", data, "from port", port); }); }); @@ -80,13 +84,6 @@ }); } }); - - // hide page action when a tab is refreshed - browser.tabs.onUpdated.addListener(function(tabId, data){ - if (data.status && data.status === "loading"){ - browser.pageAction.hide(tabId); - } - }); }); browser.runtime.onInstalled.addListener(function(){ diff --git a/releaseNotes.txt b/releaseNotes.txt index a041a35..a913079 100644 --- a/releaseNotes.txt +++ b/releaseNotes.txt @@ -9,7 +9,7 @@ Version 0.4.3: - fixes: - - + - page action was not always showing Version 0.4.2 new features: