From 6dc08534a60104ca1ab479cf085f2f443461e402 Mon Sep 17 00:00:00 2001
From: kkapsner <github@mail.kkapsner.de>
Date: Thu, 12 Jul 2018 01:18:49 +0200
Subject: [PATCH] Improved logging on settings storage.

---
 lib/settings.js | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/lib/settings.js b/lib/settings.js
index cc6d1c9..f1d2ebf 100644
--- a/lib/settings.js
+++ b/lib/settings.js
@@ -139,17 +139,25 @@
 				return true;
 			};
 			const storeValue = function storeValue(newValue){
+				logging.verbose("Trying to store new value for %s", name, newValue);
 				settings[name] = newValue;
 				if (!settingDefinition.transient){
 					var storeObject = {};
 					storeObject[name] = newValue;
-					browser.storage.local.set(storeObject);
+					browser.storage.local.set(storeObject).then(function(){
+						logging.verbose("New value stored for %s:", name, newValue);
+					}, function(err){
+						logging.warning("Unable to store new value for %s:", name, newValue, err);
+					});
+				}
+				else {
+					logging.warning("Transient setting %s cannot be stored.", name);
 				}
 			};
 			
 			if (settingDefinition.urlSpecific){
 				return function setValue(newValue, url){
-					logging.verbose("New value for %s:", name, newValue);
+					logging.verbose("New value for %s (%s):", name, url, newValue);
 					if (isValid(newValue)){
 						if (url){
 							var urlContainerValue = urlContainer.get();
@@ -169,6 +177,9 @@
 							storeValue(newValue);
 						}
 					}
+					else{
+						logging.warning("Invalid value for %s (%s):", name, url, newValue);
+					}
 				};
 			}
 			else {
@@ -177,6 +188,9 @@
 					if (isValid(newValue)){
 						storeValue(newValue);
 					}
+					else{
+						logging.warning("Invalid value for %s:", name, newValue);
+					}
 				};
 			}
 		}