From 4a043b2c788ae779ea82fac412138ce29ccebe84 Mon Sep 17 00:00:00 2001
From: kkapsner <github@mail.kkapsner.de>
Date: Wed, 22 Aug 2018 22:16:49 +0200
Subject: [PATCH] Typos and linting

---
 .../addon description/de/description.txt      |  2 +-
 .vscode/settings.json                         | 25 +++++++++
 _locales/de/messages.json                     | 48 ++++++++---------
 _locales/en/messages.json                     | 52 +++++++++----------
 lib/dataUrls.js                               |  2 +-
 lib/frame.js                                  |  4 +-
 lib/intercept.js                              |  4 +-
 lib/settingDefinitions.js                     |  2 +-
 lib/settings.js                               |  4 +-
 options/settingsDisplay.js                    |  1 +
 pageAction/domainNotification.js              |  2 +-
 pageAction/gui.js                             |  2 +-
 pageAction/notification.js                    |  2 +-
 pageAction/pageAction.css                     | 18 +++----
 releaseNotes.txt                              |  2 +-
 test/audioTest.js                             |  6 +--
 16 files changed, 101 insertions(+), 75 deletions(-)
 create mode 100644 .vscode/settings.json

diff --git a/.documentation/addon description/de/description.txt b/.documentation/addon description/de/description.txt
index 9e6381e..948a3a4 100644
--- a/.documentation/addon description/de/description.txt	
+++ b/.documentation/addon description/de/description.txt	
@@ -2,7 +2,7 @@ Dieses Add-on ermöglicht es Nutzern, Webseiten davon abzuhalten, sie über die
 
 Die verschiedenen Blockiermodi sind:
 <ul>
-<li>Auslese-API blockieren: Alle Webseiten, die nicht auf der Whitelist oder Blacklist gelistet sind, können die canvas-API zur Darstellung verwenden, aber die Auslese-API darf nicht verwendet werden. Dies kann das korrekte Funktionieren von Webseiten wie z.B. Google Maps verhinden.</li>
+<li>Auslese-API blockieren: Alle Webseiten, die nicht auf der Whitelist oder Blacklist gelistet sind, können die canvas-API zur Darstellung verwenden, aber die Auslese-API darf nicht verwendet werden. Dies kann das korrekte Funktionieren von Webseiten wie z.B. Google Maps verhindern.</li>
 <li>Auslese-API vortäuschen: Standardeinstellung und mein Favorit! Alle Webseiten, die nicht auf der Whitelist oder Blacklist gelistet sind, können die canvas-API zur Darstellung verwenden, aber die Auslese-API gibt zufällige Werte zurück, sodass das Fingerprinting immer einen anderen Wert liefert.</li>
 <li>Bei Ausgabe vortäuschen: Bei der Darstellung von Text werden die beschriebenen Pixel leicht verändert. Dies erschwert die Detektion des Add-ons, aber ist weniger sicher. Bei WebGL-Canvas ist das Verhalten identisch zu "Auslese-API vortäuschen".</li>
 <li>bei Auslese-API um Erlaubnis fragen: Alle Webseiten, die nicht auf der Whitelist oder Blacklist gelistet sind, können die canvas-API zur Darstellung verwenden, aber der Nutzer wird jedes Mal um Erlaubnis gefragt, wenn die Webseite die Readout-API verwenden möchte.</li>
diff --git a/.vscode/settings.json b/.vscode/settings.json
new file mode 100644
index 0000000..2e8407f
--- /dev/null
+++ b/.vscode/settings.json
@@ -0,0 +1,25 @@
+{
+	"cSpell.words": [
+		"Blockiermodi",
+		"Blockiermodus",
+		"Ignorierliste",
+		"Maleficient",
+		"Nachfrageverweigerungsmodus",
+		"Oakenpants",
+		"PDFs",
+		"Spoofer",
+		"Thorin",
+		"Vortäuschaktion",
+		"Vortäuschgröße",
+		"Vortäuschrate",
+		"Waterfox",
+		"collapser",
+		"fakeable",
+		"fragmenter",
+		"ignorelist",
+		"onloaded",
+		"prefs",
+		"webgl"
+	],
+	"cSpell.language": "en,de"
+}
\ No newline at end of file
diff --git a/_locales/de/messages.json b/_locales/de/messages.json
index d381102..fbef2d4 100644
--- a/_locales/de/messages.json
+++ b/_locales/de/messages.json
@@ -309,7 +309,7 @@
 	},
 	
 	"rng_description": {
-		"message": "nichts (komplett weiß): es wird immer ein weißes Bild zurückgegeben. Hierbei sollte die Option \"Alpha-Kanal auch vortäuchen\" aktiviert werden. ACHTUNG: Nicht im Modus \"Bei Ausgabe vortäuschen\" verwenden.\nnicht persistent: die Zufallszahlen werden bei jeder Vortäuschaktion neu bestimmt.\nkonstant: innerhalb einer Webseite wird eine Farbe immer gleich verändert.\npersistent: für jede Domain werden die Zufallszahlen nur einmal bestimmt.",
+		"message": "nichts (komplett weiß): es wird immer ein weißes Bild zurückgegeben. Hierbei sollte die Option \"Alpha-Kanal auch vortäuschen\" aktiviert werden. ACHTUNG: Nicht im Modus \"Bei Ausgabe vortäuschen\" verwenden.\nnicht persistent: die Zufallszahlen werden bei jeder Vortäuschaktion neu bestimmt.\nkonstant: innerhalb einer Webseite wird eine Farbe immer gleich verändert.\npersistent: für jede Domain werden die Zufallszahlen nur einmal bestimmt.",
 		"description": ""
 	},
 	"rng_options.persistent": {
@@ -680,79 +680,79 @@
 		"description": ""
 	},
 	
-	"protectaudio_title": {
+	"protectAudio_title": {
 		"message": "Audio-API beschützen",
 		"description": ""
 	},
-	"protectaudio_description": {
+	"protectAudio_description": {
 		"message": "Ob die Audio-API auch beschützt werden soll.",
 		"description": ""
 	},
-	"audiofakerate_title": {
+	"audioFakeRate_title": {
 		"message": "Buffer Vortäuschrate",
 		"description": ""
 	},
-	"audiofakerate_description": {
+	"audioFakeRate_description": {
 		"message": "Wie viele Werte pro Leseanfrage vorgetäuscht werden sollen.",
 		"description": ""
 	},
-	"audiofakerate_options.1": {
+	"audioFakeRate_options.1": {
 		"message": "1 Wert",
 		"description": ""
 	},
-	"audiofakerate_options.10": {
+	"audioFakeRate_options.10": {
 		"message": "10 Werte",
 		"description": ""
 	},
-	"audiofakerate_options.100": {
+	"audioFakeRate_options.100": {
 		"message": "100 Werte",
 		"description": ""
 	},
-	"audiofakerate_options.1000": {
+	"audioFakeRate_options.1000": {
 		"message": "1000 Werte",
 		"description": ""
 	},
-	"audiofakerate_options.0.1%": {
+	"audioFakeRate_options.0.1%": {
 		"message": "0.1% der Werte",
 		"description": ""
 	},
-	"audiofakerate_options.1%": {
+	"audioFakeRate_options.1%": {
 		"message": "1% der Werte",
 		"description": ""
 	},
-	"audiofakerate_options.10%": {
+	"audioFakeRate_options.10%": {
 		"message": "10% der Werte",
 		"description": ""
 	},
-	"audiofakerate_options.100%": {
+	"audioFakeRate_options.100%": {
 		"message": "100% der Werte",
 		"description": ""
 	},
-	"audionoiselevel_title": {
+	"audioNoiseLevel_title": {
 		"message": "Rauschlevel",
 		"description": ""
 	},
-	"audionoiselevel_description": {
+	"audioNoiseLevel_description": {
 		"message": "",
 		"description": ""
 	},
-	"audionoiselevel_options.minimal": {
+	"audioNoiseLevel_options.minimal": {
 		"message": "minimal",
 		"description": ""
 	},
-	"audionoiselevel_options.low": {
+	"audioNoiseLevel_options.low": {
 		"message": "niedrig",
 		"description": ""
 	},
-	"audionoiselevel_options.medium": {
+	"audioNoiseLevel_options.medium": {
 		"message": "mittel",
 		"description": ""
 	},
-	"audionoiselevel_options.high": {
+	"audioNoiseLevel_options.high": {
 		"message": "hoch",
 		"description": ""
 	},
-	"audionoiselevel_options.maximal": {
+	"audioNoiseLevel_options.maximal": {
 		"message": "maximal",
 		"description": ""
 	},
@@ -764,19 +764,19 @@
 		"message": "Aktiviert den Audio-Zwischenspeicher. Dies kann die Detektion des Addons verhindern aber reduziert die Geschwindigkeit des Addons.",
 		"description": ""
 	},
-	"audiousefixedindices_title": {
+	"audioUseFixedIndices_title": {
 		"message": "Feste Indizes verwenden",
 		"description": ""
 	},
-	"audiousefixedindices_description": {
+	"audioUseFixedIndices_description": {
 		"message": "Ob einige der Indizes immer vorgetäuscht werden sollen.",
 		"description": ""
 	},
-	"audiofixedindices_title": {
+	"audioFixedIndices_title": {
 		"message": "Feste Indizes",
 		"description": ""
 	},
-	"audiofixedindices_description": {
+	"audioFixedIndices_description": {
 		"message": "Die Indizes, die immer vorgetäuscht werden sollen. Kommasepariert eingeben.",
 		"description": ""
 	},
diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index 0dc71c0..f305508 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -169,7 +169,7 @@
 		"description": ""
 	},
 	"askOnlyOnce_description": {
-		"message": "When Canvas Blocker's Block mode is set to 'ask permission' or 'ask permission for readout API', a confirm message will appear every time a page tries to access the API or readout API. This setting tries to display the confirm message only once for each page regardless of how many times the page tries to access the API. Nevertheless, multiple confirm messages may still be displayed on some pages.\nNo: asking every time\nIndividual: each API-type (context, input, readout) has to be confirmed seperately\ncombined: all API-types get confirmed together",
+		"message": "When Canvas Blocker's Block mode is set to 'ask permission' or 'ask permission for readout API', a confirm message will appear every time a page tries to access the API or readout API. This setting tries to display the confirm message only once for each page regardless of how many times the page tries to access the API. Nevertheless, multiple confirm messages may still be displayed on some pages.\nNo: asking every time\nIndividual: each API-type (context, input, readout) has to be confirmed separately\ncombined: all API-types get confirmed together",
 		"description": ""
 	},
 	"askOnlyOnce_options.no": {
@@ -680,103 +680,103 @@
 		"description": ""
 	},
 	
-	"protectaudio_title": {
+	"protectAudio_title": {
 		"message": "Protect audio API",
 		"description": ""
 	},
-	"protectaudio_description": {
+	"protectAudio_description": {
 		"message": "If the audio API should be protected as well",
 		"description": ""
 	},
-	"audiofakerate_title": {
+	"audioFakeRate_title": {
 		"message": "Buffer fake rate",
 		"description": ""
 	},
-	"audiofakerate_description": {
+	"audioFakeRate_description": {
 		"message": "How many of the values per read request should be faked.",
 		"description": ""
 	},
-	"audiofakerate_options.1": {
+	"audioFakeRate_options.1": {
 		"message": "1 value",
 		"description": ""
 	},
-	"audiofakerate_options.10": {
+	"audioFakeRate_options.10": {
 		"message": "10 values",
 		"description": ""
 	},
-	"audiofakerate_options.100": {
+	"audioFakeRate_options.100": {
 		"message": "100 values",
 		"description": ""
 	},
-	"audiofakerate_options.1000": {
+	"audioFakeRate_options.1000": {
 		"message": "1000 values",
 		"description": ""
 	},
-	"audiofakerate_options.0.1%": {
+	"audioFakeRate_options.0.1%": {
 		"message": "0.1% of the values",
 		"description": ""
 	},
-	"audiofakerate_options.1%": {
+	"audioFakeRate_options.1%": {
 		"message": "1% of the values",
 		"description": ""
 	},
-	"audiofakerate_options.10%": {
+	"audioFakeRate_options.10%": {
 		"message": "10% of the values",
 		"description": ""
 	},
-	"audiofakerate_options.100%": {
+	"audioFakeRate_options.100%": {
 		"message": "100% of the values",
 		"description": ""
 	},
-	"audionoiselevel_title": {
+	"audioNoiseLevel_title": {
 		"message": "Noise level",
 		"description": ""
 	},
-	"audionoiselevel_description": {
+	"audioNoiseLevel_description": {
 		"message": "",
 		"description": ""
 	},
-	"audionoiselevel_options.minimal": {
+	"audioNoiseLevel_options.minimal": {
 		"message": "minimal",
 		"description": ""
 	},
-	"audionoiselevel_options.low": {
+	"audioNoiseLevel_options.low": {
 		"message": "low",
 		"description": ""
 	},
-	"audionoiselevel_options.medium": {
+	"audioNoiseLevel_options.medium": {
 		"message": "medium",
 		"description": ""
 	},
-	"audionoiselevel_options.high": {
+	"audioNoiseLevel_options.high": {
 		"message": "high",
 		"description": ""
 	},
-	"audionoiselevel_options.maximal": {
+	"audioNoiseLevel_options.maximal": {
 		"message": "maximal",
 		"description": ""
 	},
-	"useaudiocache_title": {
+	"useAudioCache_title": {
 		"message": "Use audio cache",
 		"description": ""
 	},
-	"useaudiocache_description": {
+	"useAudioCache_description": {
 		"message": "Enables the audio cache. This can prevent detection but decreases the performance.",
 		"description": ""
 	},
-	"audiousefixedindices_title": {
+	"audioUseFixedIndices_title": {
 		"message": "Use fixed indices",
 		"description": ""
 	},
-	"audiousefixedindices_description": {
+	"audioUseFixedIndices_description": {
 		"message": "If some of the used indices should be always faked.",
 		"description": ""
 	},
-	"audiofixedindices_title": {
+	"audioFixedIndices_title": {
 		"message": "Fixed indices",
 		"description": ""
 	},
-	"audiofixedindices_description": {
+	"audioFixedIndices_description": {
 		"message": "The indices that are always faked. Enter separated by comma.",
 		"description": ""
 	},
diff --git a/lib/dataUrls.js b/lib/dataUrls.js
index 1c90e53..0f9b11c 100644
--- a/lib/dataUrls.js
+++ b/lib/dataUrls.js
@@ -50,7 +50,7 @@
 					setHeader(headers, {
 						name: "Content-Security-Policy",
 						value: `object-src ${cspMatch}; frame-src ${cspMatch}`
-							// + "; report-to https://canvasblocker.invalid/; report-uri https://canvasblocker.invalid/"
+						//	+ "; report-to https://canvasblocker.invalid/; report-uri https://canvasblocker.invalid/"
 					});
 				}
 				return {
diff --git a/lib/frame.js b/lib/frame.js
index 56390e3..849140a 100644
--- a/lib/frame.js
+++ b/lib/frame.js
@@ -108,7 +108,7 @@
 				"contentWindow",
 				{
 					enumerable: true,
-					configureable: true,
+					configurable: true,
 					get: exportFunction(function(){
 						var window = oldContentWindowGetter.call(this);
 						if (window){
@@ -124,7 +124,7 @@
 				"contentDocument",
 				{
 					enumerable: true,
-					configureable: true,
+					configurable: true,
 					get: exportFunction(function(){
 						var document = oldContentDocumentGetter.call(this);
 						if (document){
diff --git a/lib/intercept.js b/lib/intercept.js
index 8f69d4e..4f15371 100644
--- a/lib/intercept.js
+++ b/lib/intercept.js
@@ -66,7 +66,7 @@
 			scope.intercept({subject: window}, apis);
 		}
 		else  {
-			logging.message("settings not loaded -> need to pre intercep");
+			logging.message("settings not loaded -> need to pre intercept");
 			let forceLoad = true;
 			let preIntercepted = false;
 			let intercepted = false;
@@ -97,7 +97,7 @@
 							name,
 							{
 								enumerable: true,
-								configureable: true,
+								configurable: true,
 								get: exportFunction(function(){
 									if (forceLoad){
 										logging.warning("force load the settings. Calling stack:", (new Error()).stack);
diff --git a/lib/settingDefinitions.js b/lib/settingDefinitions.js
index 3f1a1fe..30a0353 100644
--- a/lib/settingDefinitions.js
+++ b/lib/settingDefinitions.js
@@ -86,7 +86,7 @@
 				"fillText", "strokeText",
 				{name: "webGL", level: 2},
 				"readPixels",
-				{name: "Audio-API", leve: 1},
+				{name: "Audio-API", level: 1},
 				"getFloatFrequencyData", "getByteFrequencyData", "getFloatTimeDomainData", "getByteTimeDomainData",
 				"getChannelData", "copyFromChannel",
 				"getFrequencyResponse"
diff --git a/lib/settings.js b/lib/settings.js
index 18134d0..5f10b62 100644
--- a/lib/settings.js
+++ b/lib/settings.js
@@ -376,7 +376,7 @@
 			return foundDefinition.set(...args);
 		}
 		else {
-			logging.error("Try to set unkown setting:", name);
+			logging.error("Try to set unknown setting:", name);
 		}
 	};
 	scope.get = function(name, ...args){
@@ -385,7 +385,7 @@
 			return foundDefinition.get(...args);
 		}
 		else {
-			logging.error("Try to get unkown setting:", name);
+			logging.error("Try to get unknown setting:", name);
 		}
 	};
 
diff --git a/options/settingsDisplay.js b/options/settingsDisplay.js
index 5620adc..638d024 100644
--- a/options/settingsDisplay.js
+++ b/options/settingsDisplay.js
@@ -1,6 +1,7 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+/* eslint max-lines: off*/
 (function(){
 	"use strict";
 	var settingsDisplay = [
diff --git a/pageAction/domainNotification.js b/pageAction/domainNotification.js
index 119f01e..148391b 100644
--- a/pageAction/domainNotification.js
+++ b/pageAction/domainNotification.js
@@ -49,7 +49,7 @@
 
 	DomainNotification.prototype.node = function node(){
 		const node = document.createElement("li");
-		node.className = "domainPrints collapsable collapsed";
+		node.className = "domainPrints collapsible collapsed";
 		node.appendChild(this.textNode());
 		node.appendChild(document.createElement("br"));
 		createCollapser(node);
diff --git a/pageAction/gui.js b/pageAction/gui.js
index 021f791..a3cc3bd 100644
--- a/pageAction/gui.js
+++ b/pageAction/gui.js
@@ -30,7 +30,7 @@
 			collapser.addEventListener("click", function(){
 				container.classList.toggle("collapsed");
 			});
-			container.classList.add("collapsable");
+			container.classList.add("collapsible");
 			container.classList.add("collapsed");
 		};
 	}();
diff --git a/pageAction/notification.js b/pageAction/notification.js
index 8fcafba..9f41158 100644
--- a/pageAction/notification.js
+++ b/pageAction/notification.js
@@ -25,7 +25,7 @@
 			node.appendChild(document.createTextNode(this.timestamp.toLocaleString() + ": "));
 			node.appendChild(this.textNode());
 			if (this.dataURL){
-				node.className = "notification collapsable collapsed";
+				node.className = "notification collapsible collapsed";
 				node.appendChild(document.createElement("br"));
 				createCollapser(node);
 				const img = document.createElement("img");
diff --git a/pageAction/pageAction.css b/pageAction/pageAction.css
index 59ab0b2..c59286a 100644
--- a/pageAction/pageAction.css
+++ b/pageAction/pageAction.css
@@ -84,40 +84,40 @@ button.action img {
 	padding: 0 0 20px 1em;
 }
 
-.collapsable {
+.collapsible {
 	position: relative;
 	margin: 0;
 }
-.collapsable.collapsed .collapser {
+.collapsible.collapsed .collapser {
 	display: inline-block;
 	width: 20px;
 	height: 20px;
 	line-height: 20px;
 	box-sizing: border-box;
 }
-.collapsable .collapser {
+.collapsible .collapser {
 	cursor: pointer;
 	color: blue;
 	text-decoration: underline;
 }
-.collapsable .collapser .more {
+.collapsible .collapser .more {
 	display: none;
 }
-.collapsable.collapsed .collapser .more {
+.collapsible.collapsed .collapser .more {
 	display: inline;
 }
-.collapsable.collapsed .collapser .less {
+.collapsible.collapsed .collapser .less {
 	display: none;
 }
-.collapsable .collapser .less {
+.collapsible .collapser .less {
 	display: inline;
 }
-.collapsable.collapsed .collapsing {
+.collapsible.collapsed .collapsing {
 	height: 0px;
 	overflow: hidden;
 	padding: 0;
 }
-.collapsable .collapsing {
+.collapsible .collapsing {
 	height: initial;
 	width: 100%;
 	box-sizing: border-box;
diff --git a/releaseNotes.txt b/releaseNotes.txt
index 3fc9160..d8f01ae 100644
--- a/releaseNotes.txt
+++ b/releaseNotes.txt
@@ -280,7 +280,7 @@ Version 0.4.0:
 	
 	fixes:
 		- ask mode did not work for input types
-		- allow page scripts to overwrite the faked funtions
+		- allow page scripts to overwrite the faked functions
 		- getImageData also faked when using fakeInput mode
 
 Version 0.3.8:
diff --git a/test/audioTest.js b/test/audioTest.js
index 68734bb..57d7244 100644
--- a/test/audioTest.js
+++ b/test/audioTest.js
@@ -39,11 +39,11 @@
 		// Start audio processing
 		pxi_oscillator.start(0);
 		context.startRendering();
-		context.oncomplete = function(evnt) {
+		context.oncomplete = function(event) {
 			var str = "";
 			var copyTest = new Float32Array(44100);
-			evnt.renderedBuffer.copyFromChannel(copyTest, 0);
-			var getTest = evnt.renderedBuffer.getChannelData(0);
+			event.renderedBuffer.copyFromChannel(copyTest, 0);
+			var getTest = event.renderedBuffer.getChannelData(0);
 			Promise.all([
 				crypto.subtle.digest("SHA-256", getTest),
 				crypto.subtle.digest("SHA-256", copyTest),