From 2c1756ff07d0c8bd1d4424aba27040ff0bfb688a Mon Sep 17 00:00:00 2001
From: kkapsner <github@mail.kkapsner.de>
Date: Wed, 17 Jun 2020 16:18:56 +0200
Subject: [PATCH] Avoid useless URL specific setting in whitelist inspection

Fixes #483
---
 options/whitelist.js | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/options/whitelist.js b/options/whitelist.js
index 195fa77..2874278 100644
--- a/options/whitelist.js
+++ b/options/whitelist.js
@@ -102,6 +102,7 @@
 		
 		const table = document.createElement("table");
 		whitelistSettings.forEach(function(setting){
+			const settingDefinition = settings.getDefinition(setting.name);
 			const row = document.createElement("tr");
 			setting.row = row;
 			const name = document.createElement("td");
@@ -110,11 +111,13 @@
 			setting.input = document.createElement("input");
 			setting.input.type = "checkbox";
 			setting.input.addEventListener("change", function(){
-				settings.set(
-					setting.name,
-					this.checked? setting.protectedValue: setting.whitelistValue,
-					setSelect.value
-				);
+				const value = this.checked? setting.protectedValue: setting.whitelistValue;
+				if (settingDefinition.get() === value){
+					settingDefinition.reset(setSelect.value);
+				}
+				else {
+					settingDefinition.set(value, setSelect.value);
+				}
 			});
 			const input = document.createElement("td");
 			input.appendChild(setting.input);