1
0
mirror of https://github.com/kkapsner/CanvasBlocker synced 2024-09-22 17:41:41 +02:00

Do not struggle on unknown settings.

Fixes #169
Fixes #168
Fixes #164
Fixes #170
This commit is contained in:
kkapsner 2017-12-19 23:04:03 +01:00
parent 4348c71b55
commit 19a7a32e0f

View File

@ -338,23 +338,25 @@
const resetSymbol = Symbol("reset"); const resetSymbol = Symbol("reset");
function changeValue(name, newValue){ function changeValue(name, newValue){
var settingDefinition = scope.getDefinition(name); var settingDefinition = scope.getDefinition(name);
var oldValue = settings[name]; if (settingDefinition){
if (newValue === resetSymbol){ var oldValue = settings[name];
newValue = settingDefinition.defaultValue; if (newValue === resetSymbol){
} newValue = settingDefinition.defaultValue;
settings[name] = newValue; }
((eventHandler[name] || {})[defaultSymbol] || []).forEach(function(callback){ settings[name] = newValue;
callback({name, newValue, oldValue}); ((eventHandler[name] || {})[defaultSymbol] || []).forEach(function(callback){
}); callback({name, newValue, oldValue});
if (settingDefinition.urlSpecific){
urlContainer.get().forEach(function(entry){
if (!entry.hasOwnProperty(name)){
((eventHandler[name] || {})[entry.url] || []).forEach(function(callback){
callback({name, newValue, oldValue, url: entry.url});
});
}
}); });
if (settingDefinition.urlSpecific){
urlContainer.get().forEach(function(entry){
if (!entry.hasOwnProperty(name)){
((eventHandler[name] || {})[entry.url] || []).forEach(function(callback){
callback({name, newValue, oldValue, url: entry.url});
});
}
});
}
} }
} }