mirror of https://github.com/meilisearch/MeiliSearch synced 2024-11-29 16:24:26 +01:00

2745: Config file support r=curquiza a=mlemesle

# Pull Request

## What does this PR do?
Fixes #2558

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


2789: Fix typos r=Kerollmops a=kianmeng

# Pull Request

## What does this PR do?

Found via `codespell -L crate,nam,hart`.

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


2814: Skip dashboard test if mini-dashboard feature is disabled r=Kerollmops a=jirutka

Fixes #2813

Fixes the following error:

    cargo test --no-default-features
    ...
    error: couldn't read target/debug/build/meilisearch-http-ec029d8c902cf2cb/out/generated.rs: No such file or directory (os error 2)
     --> meilisearch-http/tests/dashboard/mod.rs:8:9
      |
    8 |         include!(concat!(env!("OUT_DIR"), "/generated.rs"));
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `include` (in Nightly builds, run with -Z macro-backtrace for more info)

    error: could not compile `meilisearch-http` due to previous error

2826: Rename receivedDocumentIds into matchedDocuments r=Kerollmops a=Ugzuzg

# Pull Request

## What does this PR do?

Fixes #2799 
Changes DocumentDeletion task details response.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Tested with curl:
```
curl \
  -X POST 'http://localhost:7700/indexes/movies/documents/delete-batch' \
  -H 'Content-Type: application/json' \
  --data-binary '[
    23488,
    153738,
    437035,
    363869
  ]'

{"taskUid":1,"indexUid":"movies","status":"enqueued","type":"documentDeletion","enqueuedAt":"2022-10-01T20:06:37.105416054Z"}%

curl \
  -X GET 'http://localhost:7700/tasks/1'

{"uid":1,"indexUid":"movies","status":"succeeded","type":"documentDeletion","details":{"matchedDocuments":4,"deletedDocuments":2},"duration":"PT0.005708322S","enqueuedAt":"2022-10-01T20:06:37.105416054Z","startedAt":"2022-10-01T20:06:37.115562733Z","finishedAt":"2022-10-01T20:06:37.121271055Z"}
```

Co-authored-by: mlemesle <lemesle.martin@hotmail.fr>
Co-authored-by: Kian-Meng Ang <kianmeng@cpan.org>
Co-authored-by: Jakub Jirutka <jakub@jirutka.cz>
Co-authored-by: Jarasłaŭ Viktorčyk <ugzuzg@gmail.com>

2022-10-03 09:48:34 +00:00

6.9 KiB

Raw Blame History

Contributing

First, thank you for contributing to Meilisearch! The goal of this document is to provide everything you need to start contributing to Meilisearch.

Remember that there are many ways to contribute other than writing code: writing tutorials or blog posts, improving the documentation, submitting bug reports and feature requests...

The code in this repository is only concerned with managing multiple indexes, handling the update store, and exposing an HTTP API. Search and indexation are the domain of our core engine, milli, while tokenization is handled by our charabia library.

If Meilisearch does not offer optimized support for your language, please consider contributing to charabia by following the CONTRIBUTING.md file and integrating your intended normalizer/segmenter.

Hacktoberfest 2022
Assumptions
How to Contribute
Development Workflow
Git Guidelines
Release Process (for internal team only)

Hacktoberfest 2022

It's Hacktoberfest month! 🥳

Thanks so much for participating with Meilisearch this year!

We will follow the quality standards set by the organizers of Hacktoberfest (see detail on their website). Our reviewers will not consider any PR that doesn’t match that standard.
PRs reviews will take place from Monday to Thursday, during usual working hours, CEST time. If you submit outside of these hours, there’s no need to panic; we will get around to your contribution.
There will be no issue assignment as we don’t want people to ask to be assigned specific issues and never return, discouraging the volunteer contributors from opening a PR to fix this issue. We take the liberty to choose the PR that best fixes the issue, so we encourage you to get to it as soon as possible and do your best!

Assumptions

You're familiar with GitHub and the Pull Requests(PR) workflow.
You've read the Meilisearch documentation.
You know about the Meilisearch community. Please use this for help.

How to Contribute

Ensure your change has an issue! Find an existing issue or open a new issue.
- This is where you can get a feel if the change will be accepted or not.
Once approved, fork the Meilisearch repository in your own GitHub account.
Create a new Git branch
Review the Development Workflow section that describes the steps to maintain the repository.
Make your changes on your branch.
Submit the branch as a Pull Request pointing to the main branch of the Meilisearch repository. A maintainer should comment and/or review your Pull Request within a few days. Although depending on the circumstances, it may take longer.

Development Workflow

Setup and run Meilisearch

cargo run --release

We recommend using the --release flag to test the full performance of Meilisearch.

Test

cargo test

This command will be triggered to each PR as a requirement for merging it.

If you get a "Too many open files" error you might want to increase the open file limit using this command:

ulimit -Sn 3000

Git Guidelines

Git Branches

All changes must be made in a branch and submitted as PR.

We do not enforce any branch naming style, but please use something descriptive of your changes.

Git Commits

As minimal requirements, your commit message should:

be capitalized
not finish by a dot or any other punctuation character (!,?)
start with a verb so that we can read your commit message this way: "This commit will ...", where "..." is the commit message. e.g.: "Fix the home page button" or "Add more tests for create_index method"

We don't follow any other convention, but if you want to use one, we recommend the Chris Beams one.

GitHub Pull Requests

Some notes on GitHub PRs:

All PRs must be reviewed and approved by at least one maintainer.
The PR title should be accurate and descriptive of the changes.
Convert your PR as a draft if your changes are a work in progress: no one will review it until you pass your PR as ready for review.
The draft PRs are recommended when you want to show that you are working on something and make your work visible.
The branch related to the PR must be up-to-date with main before merging. Fortunately, this project uses Bors to automatically enforce this requirement without the PR author having to rebase manually.

Release Process (for internal team only)

Meilisearch tools follow the Semantic Versioning Convention.

Automation to rebase and Merge the PRs

This project integrates a bot that helps us manage pull requests merging.
Read more about this.

How to Publish a new Release

The full Meilisearch release process is described in this guide. Please follow it carefully before doing any release.

Release assets

For each release, the following assets are created:

Binaries for different platforms (Linux, MacOS, Windows and ARM architectures) are attached to the GitHub release
Binaries are pushed to HomeBrew and APT (not published for RC)
Docker tags are created/updated:
- vX.Y.Z
- vX.Y (not published for RC)
- latest (not published for RC)

Thank you again for reading this through, we can not wait to begin to work with you if you made your way through this contributing guide ❤️

6.9 KiB Raw Blame History Unescape Escape