154 Commits

Author SHA1 Message Date
bors[bot]
f564a9ce51
Merge #849
849: Update nbHits count with filtered documents r=MarinPostma a=balajisivaraman

Closes #764 
close #1039

After discussing with @MarinPostma on Slack, this is my first attempt at implementing this for the basic flow that will go through `bucket_sort_with_distinct`.

A few thoughts here: 

- For getting the count of filtered documents alone, I originally thought of using `filter_map.values().filter(|&&v| !v).count()`. In a few cases, this was the same as what I have now implemented. But I realised I couldn't do something similar for `distinct`. So for being consistent, I have implemented both in a similar fashion.
- I also needed the `contains_key` check to ensure we're not counting the same document ID twice.

@MarinPostma also mentioned that this will be an approximation since the sort is lazy. In the test example that I've updated, the actual filtered count will be just 19 (for `male` records), but due to the `limit` in play, it returns 32 (filtering out 11 records overall).

Please let me know if this is the kind of fix we are looking for, and I can implement it in the placeholder search also.

Co-authored-by: Balaji Sivaraman <balaji@balajisivaraman.com>
2020-11-26 09:53:13 +00:00
Balaji Sivaraman
75e22fc7f5 feat(search): update nbHits count with filtered docs for placeholder search 2020-11-19 21:02:47 +05:30
Balaji Sivaraman
43df4a56c4 feat(search): update nbHits count with filtered docs for core flow 2020-11-19 19:35:37 +05:30
mpostma
0645a6568e add test clear all documents 2020-11-19 14:13:27 +01:00
mpostma
a8ab15d65d Revert "Merge #1001"
This reverts commit 690eab4a253bf25d6e457953182a86fb5ba8ee8b, reversing
changes made to 086020e543d422237121949656d43358a7f93ff0.

update changelog
2020-11-02 15:10:09 +01:00
mpostma
190b78b7be Revert "Merge #1037"
This reverts commit 257f9fb2b2b69045bff01a093e6ce15440af1bed, reversing
changes made to 9bae7a35bf98ee79370be422292fd71f5e884015.
2020-10-27 17:27:47 +01:00
mpostma
d35a104ad3 requested changes 2020-10-27 11:53:24 +01:00
mpostma
91363daeaa add tests 2020-10-26 17:48:13 +01:00
many
53b1483e71
fix pr comments 2020-10-22 16:12:55 +02:00
many
a0eafea200
fix tests 2020-10-22 15:46:20 +02:00
many
834f3cc192
rename folder to dir 2020-10-22 15:46:20 +02:00
many
e049aead16
improve dump status 2020-10-22 15:46:20 +02:00
many
5a842ec94a
clean PR #946 2020-10-19 17:16:25 +02:00
frbimo
6465a3f549 refactor /health on meilisearch-http that complies:
1. NEEDS to ensure that service is completely up if it returns 204
2. DOES NOT block service process (write transaction)
3. NEEDS to use the less network bandwidth as possible when it's triggered
4. NEEDS to use the less service resources as possible when it's triggered
5. DOES NOT NEED any authentication
6. MAY be named /health
2020-10-19 14:30:43 +08:00
mpostma
dc2e5ceed2 fix bug 2020-10-16 14:16:12 +02:00
many
1639a7338d add test to reproduce #891 bug report
fix bug
2020-10-16 13:35:11 +02:00
bors[bot]
29b8810db8
Merge #914
914: lazily create an index on documents push r=LegendreM a=qdequele

Create an index if it's possible when a user trying to send data to a non-existing index. https://github.com/meilisearch/MeiliSearch/issues/918

Co-authored-by: qdequele <quentin@meilisearch.com>
Co-authored-by: qdequele <quentin@dequelen.me>
2020-10-15 09:37:15 +00:00
qdequele
a5a47911d1 add tests 2020-10-15 09:43:54 +02:00
bors[bot]
7bf6a3d7b2
Merge #984
984: Add test search r=LegendreM a=LegendreM

- Get an error if the index does not exist
- Get an error if a parameter is not expected (e.g.: "lol")
- Check a basic search with no parameter
- Check a basic search with only a q parameter

isssue #814 

Co-authored-by: many <maxime@meilisearch.com>
2020-10-14 16:22:10 +00:00
qdequele
0a67248bfe cargo fmt 2020-10-13 10:54:02 +02:00
qdequele
2644f087d0 add tests 2020-10-13 10:54:02 +02:00
many
10c56d9919
Add test on search
related to SEARCH part in #814
2020-10-13 10:38:22 +02:00
gorogoroumaru
eb240c8b60 update test 2020-10-10 06:13:27 +00:00
gorogoroumaru
c3bcd7a410 Merge branch 'issue943' of https://github.com/gorogoroumaru/MeiliSearch into issue943 2020-10-10 02:58:16 +00:00
gorogoroumaru
26124e6436 update test 2020-10-10 02:56:44 +00:00
gorogoroumaru
3cd6f5c7ea
Merge branch 'master' into issue943 2020-10-10 11:50:45 +09:00
gorogoroumaru
7c646e031c update test 2020-10-10 02:43:09 +00:00
many
afc3b0915b
fix backups
* pluralize variable `backup_folder` -> `backups_folder`
* change env case `MEILI_backup_folder` -> `MEILI_BACKUPS_FOLDER`
* add miliseconds to backup ID to reduce colisions
* fix forgoten stats synchronization
2020-09-30 13:20:40 +02:00
bors[bot]
32f6a9a457
Merge #976
976: Revert 944 r=MarinPostma a=MarinPostma

revert #944 
@bidoubiwa  @curquiza @eskombro, this was a misunderstanding from our side. Doing this would in fact be an error, and would prevent us to do this: https://github.com/meilisearch/MeiliSearch/issues/945#issuecomment-685526678, which is what we are really after. We are resetting this to its default behaviour before it goes in prodution. Sorry for the confusion.

Co-authored-by: mpostma <postma.marin@protonmail.com>
2020-09-28 13:38:46 +00:00
bors[bot]
099a0802fc
Merge #916
916: Considere an empty query search as a placeholder search r=MarinPostma a=qdequele

Fix #856; Relative tracking issue: #729

Co-authored-by: qdequele <quentin@meilisearch.com>
2020-09-28 13:13:47 +00:00
bors[bot]
e258e0b2c2
Merge #887
887: backup r=Kerollmops a=LegendreM

[Tracking Issue](https://github.com/meilisearch/MeiliSearch/issues/840)
[Documentation PR](https://github.com/meilisearch/documentation/pull/468)
[Other relevant issue](https://github.com/meilisearch/MeiliSearch/issues/884)

Co-authored-by: many <maxime@meilisearch.com>
2020-09-28 12:47:08 +00:00
many
c254320860
Implement backups
* trigger backup importation via http route
* follow backup advancement with status route
* import backup via a command line
* let user choose batch size of documents to import (command lines)

closes #884
closes #840
2020-09-28 14:40:06 +02:00
qdequele
51fd849852 cargo fmt 2020-09-28 14:23:32 +02:00
qdequele
ab170ce4fd add test 2020-09-28 14:19:45 +02:00
mpostma
030bcd8b05 Revert "facet count more tests"
This reverts commit 954f572e79c63e9b594cbda39597e3673d478aec.
2020-09-24 16:40:18 +02:00
mpostma
63260e6443 add tests for documents 2020-09-22 16:05:40 +02:00
mpostma
a794970b72 additional tests for index 2020-09-22 10:51:34 +02:00
mpostma
954f572e79 facet count more tests 2020-09-01 10:27:50 +02:00
mpostma
4ecaf99047 fix test option test 2020-08-24 14:14:11 +02:00
many
94b3e8e56e
fix bug and add tests
- add tests about updates
- fix select bug

fix #896
2020-08-19 09:51:57 +02:00
mpostma
afacdbc7a0 update tests for facets distribution case 2020-08-12 10:31:11 +02:00
mpostma
d114250ebb requested changes 2020-07-16 16:19:15 +02:00
mpostma
4b5437a882 fix displayed attrs empty array bug 2020-07-15 19:25:24 +02:00
mpostma
de4caef468 test reset attributes to wildcard 2020-07-15 18:56:19 +02:00
mpostma
36b763b84e test setting attributes before adding documents 2020-07-15 18:56:19 +02:00
mpostma
c06dd35af1 fix tests 2020-07-15 18:56:19 +02:00
mpostma
51d7c84e73 better exit on error
Update meilisearch-core/src/database.rs

Co-authored-by: Clément Renault <renault.cle@gmail.com>

Update meilisearch-core/src/database.rs

Co-authored-by: Clément Renault <renault.cle@gmail.com>
2020-07-13 16:06:28 +02:00
bors[bot]
308630c094
Merge #841
841: Unique docid bugfix r=LegendreM a=MarinPostma

fix #827 

Co-authored-by: mpostma <postma.marin@protonmail.com>
2020-07-13 13:36:32 +00:00
mpostma
f54397e0cf test unique document id bug 2020-07-13 15:14:07 +02:00
mpostma
99e8d4adae fix missing primary key 2020-07-13 14:54:25 +02:00