Tamo
50f84d43f5
init commit
2024-02-08 15:03:32 +01:00
Tamo
f76cc0806e
WIP: first draft at introducing a new log route
2024-02-08 15:03:32 +01:00
Tamo
2f1abd2c03
nelson is not used anymore
2024-02-08 15:03:32 +01:00
Louis Dureuil
dedc91e2cf
use json lines
2024-02-08 15:03:32 +01:00
Louis Dureuil
a61d8c59ff
Add span stats processor
2024-02-08 15:03:32 +01:00
Louis Dureuil
6e23040464
Use with tokio channel in Meilisearch
2024-02-08 15:03:32 +01:00
Louis Dureuil
8febbf64ce
Switch to tokio channel
2024-02-08 15:03:32 +01:00
Louis Dureuil
b141c82a04
Support Events in trace layer
2024-02-08 15:03:32 +01:00
Louis Dureuil
cc79cd0b04
Switch to a single view indicating current usage
2024-02-08 15:03:32 +01:00
Louis Dureuil
256538ccb9
Refactor memory handling and add markers
2024-02-08 15:03:31 +01:00
Clément Renault
ca8990394e
Remove the stats_alloc from the default features
2024-02-08 15:03:31 +01:00
Clément Renault
83fb2949c3
Give the allocator to the tracer when necessary
2024-02-08 15:03:31 +01:00
Louis Dureuil
6cf703387d
Format the bytes as human readable bytes
...
Uses the same `byte_unit` version as `meilisearch`
2024-02-08 15:03:31 +01:00
Clément Renault
771861599b
Logging the memory usage over time
2024-02-08 15:03:31 +01:00
Louis Dureuil
7e47cea0c4
Add tracing to Meilisearch
2024-02-08 15:03:31 +01:00
Louis Dureuil
5d7061682e
Add tracing to milli
2024-02-08 15:03:31 +01:00
Louis Dureuil
02e6c8a440
Add tracing to index-scheduler
2024-02-08 15:03:31 +01:00
Louis Dureuil
89401d097b
Add tracing-trace
2024-02-08 15:03:30 +01:00
meili-bors[bot]
72ebac1fbb
Merge #4388
...
4388: Cap the maximum memory of the grenad sorters r=curquiza a=Kerollmops
This PR clamps the memory usage of the grenad sorters to a reasonable maximum. Grenad sorters are opened on multiple threads at a time. This can result in higher memory usage than expected, even though it shouldn't consume more than the memory available.
Fixes #4152 .
Co-authored-by: Clément Renault <clement@meilisearch.com>
2024-02-08 13:19:28 +00:00
meili-bors[bot]
a616a1d37b
Merge #4389
...
4389: Stabilize scoreDetails r=dureuill a=dureuill
# Pull Request
## Related issue
Fixes #4359
## What does this PR do?
### User standpoint
- Users no longer need to enable the `scoreDetails` experimental feature to use `showRankingScoreDetails` in search queries.
- ⚠️ **Breaking change**: sending an object containing the key `"scoreDetails"` to the `/experimental-features` route is now an error. However, importing a dump of a database where that feature was enabled completes successfully.
### Implementation standpoint
- remove `scoreDetails` from the experimental features
- remove check on the experimental feature `scoreDetails` before accepting `showRankingScoreDetails`
- remove `scoreDetails` from the accepted fields in the `/experimental-features` route
- fix tests accordingly
## Manual tests
1. exported a dump with the `scoreDetails` feature enabled on `main`
- tried to import the dump after the changes in this PR
- the dump imported successfully
2. tried to make a search with `showRankingScoreDetails: true`
- the ranking score details are displayed
- an automated test case also exists and passes
3. tried to enable the `scoreDetails` in `/experimental-features`
- get error message
```
Unknown field `scoreDetails`: expected one of `vectorStore`, `metrics`, `exportPuffinReports`
```
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
2024-02-08 10:40:00 +00:00
meili-bors[bot]
3e120619fa
Merge #4375
...
4375: Feat: add new OpenAI models and ability to override dimensions r=dureuill a=Gosti
# Pull Request
Fixes #4394
## Related discussion
https://github.com/orgs/meilisearch/discussions/677#discussioncomment-8306384
## What does this PR do?
- Add text-embedding-3-small
- Add text-embedding-3-large
- Add optional dimensions parameter for both new models
## Note
As the dimensions option is not available for text-embedding-ada-002 I've added a manual check to prevent, but I feel it could be implemented in a more idiomatic rust
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: Gosti <gostitsog@gmail.com>
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
2024-02-07 16:20:15 +00:00
Louis Dureuil
a1caac9bfb
Correct distribution shifts for new models
2024-02-07 15:09:16 +01:00
Louis Dureuil
88d03c56ab
Don't accept dimensions of 0 (ever) or dimensions greater than the default dimensions of the model
2024-02-07 11:52:09 +01:00
Louis Dureuil
32ee05ccef
Fix default dimensions for models
2024-02-07 11:52:09 +01:00
Louis Dureuil
74c180267e
pass dimensions only when defined
2024-02-07 11:52:08 +01:00
Louis Dureuil
517f5332d6
Allow actually passing dimensions
for OpenAI source
...
-> make sure the settings change is rejected or the settings task fails when the specified model doesn't support
overriding `dimensions` and the passed `dimensions` differs from the model's default dimensions.
2024-02-07 11:51:44 +01:00
Louis Dureuil
9ac5750096
Retrieve the overriden dimensions from the configuration when fetching settings
2024-02-07 11:51:44 +01:00
Louis Dureuil
7ae4013478
Make sure the overriden dimensions are always used when embedding
2024-02-07 11:51:44 +01:00
Gosti
fb705116a6
feat: add new models and ability to override dimensions
2024-02-07 11:51:42 +01:00
Clément Renault
053306c0e7
Try with 500MiB
2024-02-07 11:24:43 +01:00
meili-bors[bot]
84235a63df
Merge #4360
...
4360: fix readme broken links r=curquiza a=Elliot67
# Pull Request
## What does this PR do?
- fix some links in the readme
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Co-authored-by: Elliot Lintz <45725915+Elliot67@users.noreply.github.com>
Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
2024-02-06 16:00:16 +00:00
gui machiavelli
29f8300ac7
Update README.md
2024-02-06 16:49:29 +01:00
Louis Dureuil
05edd85d75
Stabilize scoreDetails
2024-02-06 11:15:19 +01:00
Clément Renault
9eeb75d501
Clamp the max memory of the grenad sorters to a reasonable maximum
2024-02-06 10:47:04 +01:00
meili-bors[bot]
4792651462
Merge #4384
...
4384: Bump peter-evans/repository-dispatch from 2 to 3 r=curquiza a=dependabot[bot]
Bumps [peter-evans/repository-dispatch](https://github.com/peter-evans/repository-dispatch ) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/repository-dispatch/releases ">peter-evans/repository-dispatch's releases</a>.</em></p>
<blockquote>
<h2>Repository Dispatch v3.0.0</h2>
<p>⚙️ Updated runtime to Node.js 20</p>
<ul>
<li>The action now requires a minimum version of <a href="https://github.com/actions/runner/releases/tag/v2.308.0 ">v2.308.0</a> for the Actions runner. Update self-hosted runners to v2.308.0 or later to ensure compatibility.</li>
</ul>
<h2>What's Changed</h2>
<ul>
<li>Bump prettier to fix deps by <a href="https://github.com/peter-evans "><code>`@peter-evans</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/255 ">peter-evans/repository-dispatch#255</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.17.12 to 18.17.14 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/257 ">peter-evans/repository-dispatch#257</a></li>
<li>build(deps-dev): bump <code>`@vercel/ncc</code>` from 0.36.1 to 0.38.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/258 ">peter-evans/repository-dispatch#258</a></li>
<li>build(deps): bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/259 ">peter-evans/repository-dispatch#259</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.17.14 to 18.17.16 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/261 ">peter-evans/repository-dispatch#261</a></li>
<li>build(deps): bump <code>`@actions/core</code>` from 1.10.0 to 1.10.1 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/262 ">peter-evans/repository-dispatch#262</a></li>
<li>build(deps-dev): bump jest-circus from 29.6.4 to 29.7.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/263 ">peter-evans/repository-dispatch#263</a></li>
<li>build(deps-dev): bump eslint from 8.48.0 to 8.49.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/264 ">peter-evans/repository-dispatch#264</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot "><code>`@actions-bot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/265 ">peter-evans/repository-dispatch#265</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.17.16 to 18.17.18 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/266 ">peter-evans/repository-dispatch#266</a></li>
<li>build(deps-dev): bump eslint-plugin-github from 4.10.0 to 4.10.1 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/267 ">peter-evans/repository-dispatch#267</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.17.18 to 18.18.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/268 ">peter-evans/repository-dispatch#268</a></li>
<li>build(deps-dev): bump eslint from 8.49.0 to 8.50.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/269 ">peter-evans/repository-dispatch#269</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.0 to 18.18.3 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/271 ">peter-evans/repository-dispatch#271</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.0.0 to 5.0.1 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/275 ">peter-evans/repository-dispatch#275</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.3 to 18.18.5 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/274 ">peter-evans/repository-dispatch#274</a></li>
<li>build(deps-dev): bump eslint from 8.50.0 to 8.51.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/276 ">peter-evans/repository-dispatch#276</a></li>
<li>build(deps-dev): bump <code>`@babel/traverse</code>` from 7.16.3 to 7.23.2 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/278 ">peter-evans/repository-dispatch#278</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.5 to 18.18.6 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/279 ">peter-evans/repository-dispatch#279</a></li>
<li>build(deps-dev): bump <code>`@vercel/ncc</code>` from 0.38.0 to 0.38.1 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/280 ">peter-evans/repository-dispatch#280</a></li>
<li>build(deps-dev): bump eslint from 8.51.0 to 8.52.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/281 ">peter-evans/repository-dispatch#281</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.6 to 18.18.7 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/282 ">peter-evans/repository-dispatch#282</a></li>
<li>build(deps): bump actions/setup-node from 3 to 4 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/283 ">peter-evans/repository-dispatch#283</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.7 to 18.18.8 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/284 ">peter-evans/repository-dispatch#284</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.8 to 18.18.9 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/285 ">peter-evans/repository-dispatch#285</a></li>
<li>build(deps-dev): bump eslint from 8.52.0 to 8.53.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/286 ">peter-evans/repository-dispatch#286</a></li>
<li>build(deps-dev): bump prettier from 3.0.3 to 3.1.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/287 ">peter-evans/repository-dispatch#287</a></li>
<li>build(deps-dev): bump eslint from 8.53.0 to 8.54.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/289 ">peter-evans/repository-dispatch#289</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.9 to 18.18.13 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/290 ">peter-evans/repository-dispatch#290</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.18.13 to 18.19.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/291 ">peter-evans/repository-dispatch#291</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.19.0 to 18.19.3 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/292 ">peter-evans/repository-dispatch#292</a></li>
<li>build(deps-dev): bump eslint from 8.54.0 to 8.55.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/293 ">peter-evans/repository-dispatch#293</a></li>
<li>build(deps-dev): bump prettier from 3.1.0 to 3.1.1 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/296 ">peter-evans/repository-dispatch#296</a></li>
<li>build(deps): bump actions/upload-artifact from 3 to 4 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/295 ">peter-evans/repository-dispatch#295</a></li>
<li>build(deps-dev): bump eslint from 8.55.0 to 8.56.0 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/297 ">peter-evans/repository-dispatch#297</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.0.1 to 5.1.1 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/298 ">peter-evans/repository-dispatch#298</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.1.1 to 5.1.2 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/299 ">peter-evans/repository-dispatch#299</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.19.3 to 18.19.4 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/300 ">peter-evans/repository-dispatch#300</a></li>
<li>build(deps-dev): bump eslint-plugin-prettier from 5.1.2 to 5.1.3 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/301 ">peter-evans/repository-dispatch#301</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.19.4 to 18.19.6 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/302 ">peter-evans/repository-dispatch#302</a></li>
<li>build(deps-dev): bump prettier from 3.1.1 to 3.2.4 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/303 ">peter-evans/repository-dispatch#303</a></li>
<li>build(deps-dev): bump <code>`@types/node</code>` from 18.19.6 to 18.19.8 by <a href="https://github.com/dependabot "><code>`@dependabot</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/304 ">peter-evans/repository-dispatch#304</a></li>
<li>feat: update runtime to node 20 by <a href="https://github.com/peter-evans "><code>`@peter-evans</code></a>` in <a href="https://redirect.github.com/peter-evans/repository-dispatch/pull/305 ">peter-evans/repository-dispatch#305</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ff45666b94
"><code>ff45666</code></a> feat: update runtime to node 20 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/305 ">#305</a>)</li>
<li><a href="a4a90276d0
"><code>a4a9027</code></a> build(deps-dev): bump <code>`@types/node</code>` from 18.19.6 to 18.19.8 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/304 ">#304</a>)</li>
<li><a href="2605253283
"><code>2605253</code></a> build(deps-dev): bump prettier from 3.1.1 to 3.2.4 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/303 ">#303</a>)</li>
<li><a href="ab3258eeef
"><code>ab3258e</code></a> build(deps-dev): bump <code>`@types/node</code>` from 18.19.4 to 18.19.6 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/302 ">#302</a>)</li>
<li><a href="240bc73193
"><code>240bc73</code></a> build(deps-dev): bump eslint-plugin-prettier from 5.1.2 to 5.1.3 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/301 ">#301</a>)</li>
<li><a href="8aa15c54a0
"><code>8aa15c5</code></a> build(deps-dev): bump <code>`@types/node</code>` from 18.19.3 to 18.19.4 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/300 ">#300</a>)</li>
<li><a href="22aa07cf23
"><code>22aa07c</code></a> build(deps-dev): bump eslint-plugin-prettier from 5.1.1 to 5.1.2 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/299 ">#299</a>)</li>
<li><a href="ba0298574b
"><code>ba02985</code></a> build(deps-dev): bump eslint-plugin-prettier from 5.0.1 to 5.1.1 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/298 ">#298</a>)</li>
<li><a href="accfd7b5bf
"><code>accfd7b</code></a> build(deps-dev): bump eslint from 8.55.0 to 8.56.0 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/297 ">#297</a>)</li>
<li><a href="3c7d964ae9
"><code>3c7d964</code></a> build(deps): bump actions/upload-artifact from 3 to 4 (<a href="https://redirect.github.com/peter-evans/repository-dispatch/issues/295 ">#295</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/peter-evans/repository-dispatch/compare/v2...v3 ">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/repository-dispatch&package-manager=github_actions&previous-version=2&new-version=3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-05 14:13:35 +00:00
dependabot[bot]
58c3501b54
Bump peter-evans/repository-dispatch from 2 to 3
...
Bumps [peter-evans/repository-dispatch](https://github.com/peter-evans/repository-dispatch ) from 2 to 3.
- [Release notes](https://github.com/peter-evans/repository-dispatch/releases )
- [Commits](https://github.com/peter-evans/repository-dispatch/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: peter-evans/repository-dispatch
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-02-01 17:05:50 +00:00
meili-bors[bot]
ff76d8f21a
Merge #4382
...
4382: Bring back changes from `release-v1.6.1` into `main` r=curquiza a=dureuill
Bring back changes from release-v1.6.1 into main
Supersedes https://github.com/meilisearch/meilisearch/pull/4380 and #4381
Third time's the charm
Co-authored-by: curquiza <curquiza@users.noreply.github.com>
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Morgane Dubus <30866152+mdubus@users.noreply.github.com>
2024-02-01 11:16:31 +00:00
Louis Dureuil
698ea5139d
Update Cargo.lock
2024-02-01 10:40:23 +01:00
Morgane Dubus
880e790bff
Update Cargo.toml
2024-02-01 10:33:27 +01:00
Louis Dureuil
fbf5f2a392
Don't use a runtime in extract_embedder, use it only for OpenAI
2024-02-01 10:33:27 +01:00
Louis Dureuil
1555870088
Truncate HuggingFace vectors that are too long
2024-02-01 10:33:27 +01:00
Tamo
9f8f3105d5
make clippy happy
2024-02-01 10:33:27 +01:00
Tamo
318843aacd
add a bunch of tests and fix the error message when adding the geosearch as filterable/sortable while there is malformed documents in the DB
2024-02-01 10:33:27 +01:00
Louis Dureuil
6d111139b5
Add test
2024-02-01 10:33:27 +01:00
Louis Dureuil
dff2707471
Use MatchingWords from keyword search instead of the one from vector search
2024-02-01 10:33:27 +01:00
curquiza
c57f7f7379
Update version for the next release (v1.6.1) in Cargo.toml
2024-02-01 10:33:26 +01:00
meili-bors[bot]
b968616a99
Merge #4364
...
4364: Revert "Remove panic on the geosearch" r=curquiza a=irevoire
After more thought about it, we want to fix this bug in a patch release instead of `main`.
I revert this PR for now, but the fix will still land on `main` once we bring back the change of the `v1.6.1` on `main`.
Reverts meilisearch/meilisearch#4337
Co-authored-by: Tamo <irevoire@protonmail.ch>
2024-01-25 18:01:08 +00:00
Tamo
c1bf33a112
Revert "Remove panic on the geosearch"
2024-01-25 18:51:19 +01:00
Elliot Lintz
ddc2b7129a
fix readme broken links
2024-01-24 22:50:18 +01:00
meili-bors[bot]
b6fc181993
Merge #4304
...
4304: Add CUDA GPU support for Hugging Face embedders r=Kerollmops a=dureuill
Adds a "cuda" feature to `milli`.
Compiling with this feature requires that the CUDA support library be installed (see "with CUDA support" paragraph in https://huggingface.github.io/candle/guide/installation.html ), and adds CUDA support to the `huggingFace` embedder.
To enable GPU support, users will need to:
1. Have a compatible NVidia GPU under Linux
2. Follow [the guide](https://huggingface.github.io/candle/guide/installation.html ) to install the CUDA dependencies
3. Compile Meilisearch with the `cuda` feature: `cargo build --release --features cuda`
# Impact
Enabling the CUDA feature allows to use an available GPU to compute embeddings with a `huggingFace` embedder.
On an AWS Graviton 2, this yields a x3 - x5 improvement on indexing time.
# Technical details
- I had to change the CI so that the cuda feature is not included in the `Tests all features` workflow
- To achieve that, I had to add a binary following the `cargo xtask` design pattern, to list all features excepted the cuda one.
- I then changed the workflow accordingly (renamed to "Tests almost all features" 😉 )
- A test run of the new feature was done on a temporary version of this PR that had it enabled for PRs: [See the results here](https://github.com/meilisearch/meilisearch/actions/runs/7461331929/job/20301216732 )
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
2024-01-22 13:55:04 +00:00