bors[bot]
66f55e3e6a
Merge #255
...
255: Fix facet distribution error r=Kerollmops a=Kerollmops
This PR fixes two invalid behaviors and fixes #253 :
- We were ignoring the list of fields for which the user wanted a facet distribution.
- We were not raising any error for when a non-filterable field was requested a facet distribution.
~For the latter behavior I need the help of @curquiza to help me choose the right error type.~
Co-authored-by: Kerollmops <clement@meilisearch.com>
2021-06-23 12:03:05 +00:00
Kerollmops
a6218a20ae
Introduce a new InvalidFacetsDistribution user error
2021-06-23 13:56:19 +02:00
Kerollmops
2364777838
Return an error for when a field distribution cannot be done
2021-06-23 11:50:49 +02:00
Kerollmops
aeaac743ff
Replace an if let some by a match
2021-06-23 11:33:30 +02:00
bors[bot]
28197b2435
Merge #252
...
252: Run the formatter on the whole project a second time r=Kerollmops a=irevoire
Co-authored-by: Tamo <tamo@meilisearch.com>
2021-06-22 13:56:09 +00:00
Tamo
8d2a0b43ff
run the formatter on the whole project a second time
2021-06-22 15:36:22 +02:00
bors[bot]
634201244c
Merge #250 #251
...
250: Add the limit field to http-ui r=Kerollmops a=irevoire
251: Fix the limit r=Kerollmops a=irevoire
There was no check on the limit and thus if a user specified a very large number this line could cause a panic.
Co-authored-by: Tamo <tamo@meilisearch.com>
2021-06-22 13:00:52 +00:00
Tamo
3d90b03d7b
fix the limit
...
There was no check on the limit and thus, if a user especified a very large number this line could causes a panic
2021-06-22 14:52:13 +02:00
Tamo
81643e6d70
add the limit field to http-ui
2021-06-22 14:47:23 +02:00
bors[bot]
5aea8dd75b
Merge #249
...
249: Enable the jemallocator dependencies only when we are running on linux r=Kerollmops a=irevoire
Co-authored-by: Tamo <tamo@meilisearch.com>
2021-06-22 12:32:44 +00:00
Tamo
77eb37934f
add jemalloc to http-ui and the benchmarks
2021-06-22 14:17:56 +02:00
bors[bot]
5b6adc6d96
Merge #245
...
245: Warn for when a key is too large for LMDB r=Kerollmops a=Kerollmops
Closes #191 , and resolves #140 .
Co-authored-by: Kerollmops <clement@meilisearch.com>
2021-06-22 12:10:52 +00:00
Tamo
d53df8a002
enable the jemallocator dependencies only when we are running on linux
2021-06-22 14:04:16 +02:00
bors[bot]
ca9fa329d1
Merge #247
...
247: Return a `MissingDocumentId` error when a document doesn't have one r=Kerollmops a=Kerollmops
We were wrongly returning a `MissingPrimaryKey` instead of a `MissingDocumentId` error for when a document was missing a document id. We also improved the error message for when a document id is invalid (wrong type or wrong format).
Co-authored-by: Kerollmops <clement@meilisearch.com>
2021-06-22 10:07:54 +00:00
Kerollmops
51dbb2e06d
Warn for when a key is too large for LMDB
2021-06-22 11:51:36 +02:00
Kerollmops
aecbd14761
Improve the error message for InvalidDocumentId
2021-06-22 11:31:58 +02:00
Kerollmops
0cca2ea24f
Return a MissingDocumentId when a document doesn't have one
2021-06-22 11:22:33 +02:00
Kerollmops
481b0bf277
Warn for when a facet key is too large for LMDB
2021-06-22 10:57:46 +02:00
bors[bot]
b073fd49ea
Merge #244
...
244: Update version for the next release (v0.5.0) r=Kerollmops a=curquiza
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-21 14:27:10 +00:00
bors[bot]
be2ebdd395
Merge #243
...
243: Rename FieldsDistribution into FieldDistribution r=Kerollmops a=curquiza
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-21 14:00:35 +00:00
Clémentine Urquizar
320670f8fe
Update version for the next release (v0.5.0)
2021-06-21 15:59:17 +02:00
Clémentine Urquizar
daef43f504
Rename FieldsDistribution into FieldDistribution
2021-06-21 15:57:41 +02:00
bors[bot]
b120c32cad
Merge #242
...
242: Update version for the next release (v0.4.2) r=Kerollmops a=curquiza
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-21 09:01:42 +00:00
Clémentine Urquizar
35fcc351a0
Update version for the next release (v0.4.2)
2021-06-20 17:37:24 +02:00
bors[bot]
5b19dd23d9
Merge #240
...
240: Field distribution r=Kerollmops a=irevoire
closes #199
closes #198
Co-authored-by: Tamo <tamo@meilisearch.com>
2021-06-19 10:14:25 +00:00
Tamo
d08cfda796
convert the field_distribution to a BTreeMap and avoid counting twice the same documents
2021-06-17 18:31:54 +02:00
bors[bot]
a9e552ab18
Merge #238
...
238: Integration tests on filters and distinct r=Kerollmops a=ManyTheFish
Fix #216
Fix #120
Co-authored-by: many <maxime@meilisearch.com>
2021-06-17 15:00:51 +00:00
many
6cb1102bdb
Fix PR comments
2021-06-17 15:19:03 +02:00
Tamo
969adaefdf
rename fields_distribution in field_distribution
2021-06-17 15:16:20 +02:00
bors[bot]
a67ccfdf3a
Merge #239
...
239: Update version to the next release (0.4.1) r=Kerollmops a=Kerollmops
Co-authored-by: Kerollmops <clement@meilisearch.com>
2021-06-17 13:02:37 +00:00
Kerollmops
ccd6f13793
Update version to the next release (0.4.1)
2021-06-17 15:01:20 +02:00
many
f496cd320d
Add distinct integration tests
2021-06-17 14:33:18 +02:00
many
9f4184208e
Add test on filters
2021-06-17 13:56:09 +02:00
bors[bot]
bb89ef9fc0
Merge #237
...
237: change sub errors visibility r=Kerollmops a=MarinPostma
re-export sub-error types so they can be matched upon outside of milli.
Co-authored-by: marin postma <postma.marin@protonmail.com>
Co-authored-by: marin <postma.marin@protonmail.com>
2021-06-17 09:51:18 +00:00
marin
70bee7d405
re-export remaining error types
...
Co-authored-by: Clément Renault <clement@meilisearch.com>
2021-06-17 11:49:03 +02:00
marin postma
abbebad669
change sub errors visibility
2021-06-17 11:44:01 +02:00
bors[bot]
1bcf43baac
Merge #236
...
236: Format the whole project r=Kerollmops a=irevoire
I need to add `cargo fmt` in the CI before closing #231
Co-authored-by: Tamo <tamo@meilisearch.com>
2021-06-16 18:05:40 +00:00
Tamo
9716fb3b36
format the whole project
2021-06-16 18:33:33 +02:00
bors[bot]
ba30cef987
Merge #234
...
234: Revert "Enable optimization in every profile" r=Kerollmops a=ManyTheFish
compiling tests in release takes too much time.
Reverts meilisearch/milli#224
Fix #233
Co-authored-by: Many <legendre.maxime.isn@gmail.com>
2021-06-16 13:38:58 +00:00
Many
41bdc90f46
Revert "Enable optimization in every profile"
2021-06-16 14:17:02 +02:00
bors[bot]
3bd4cf94cc
Merge #235
...
235: Update version for the next release (v0.4.0) r=Kerollmops a=curquiza
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-16 12:02:40 +00:00
Clémentine Urquizar
f5ff3e8e19
Update version for the next release (v0.4.0)
2021-06-16 14:01:05 +02:00
bors[bot]
02e0271e44
Merge #225
...
225: Introduce the error handler r=ManyTheFish a=Kerollmops
Fixes #109 .
Co-authored-by: Kerollmops <clement@meilisearch.com>
Co-authored-by: many <maxime@meilisearch.com>
2021-06-16 09:46:23 +00:00
many
ce0315a10f
Close write transaction in test
2021-06-16 11:03:37 +02:00
Kerollmops
7ac441e473
Fix small typos
2021-06-16 11:03:37 +02:00
Kerollmops
adf0c389c5
Rename FilterParsing into InvalidFilter
2021-06-16 11:03:36 +02:00
Kerollmops
8cfe3e1ec0
Rename DatabaseSizeReached into MaxDatabaseSizeReached
2021-06-16 11:03:36 +02:00
Kerollmops
4eda438f6f
Add a new Error for when a user use a non-filtered attribute in a filter
2021-06-16 11:03:36 +02:00
Kerollmops
713acc408b
Introduce the primary key to the Settings builder structure
2021-06-16 11:03:36 +02:00
Kerollmops
a7d6930905
Replace the panicking expect by tracked Errors
2021-06-15 11:51:32 +02:00
