ManyTheFish
b6e6a08f7d
Fix CI test
2022-08-16 15:14:01 +02:00
ManyTheFish
ae174c2cca
Fix task serialization
2022-08-11 13:35:35 +02:00
ManyTheFish
3a48de136e
Add autobatching test
2022-08-10 17:02:29 +02:00
Kerollmops
e3426d5b7a
Improve the tasks error reporting
2022-07-28 15:12:54 +02:00
Clémentine Urquizar - curqui
8e370ed9ab
Merge branch 'main' into stable
2022-07-11 14:41:15 +02:00
bors[bot]
755b1a59a2
Merge #2584
...
2584: Format API keys in hexa instead of base64 r=curquiza a=ManyTheFish
This PR:
- Changes API key generation and formatting to ease the generation of the key made by our users
- updates the `uuid` crate version
The API key can now be generated in bash as below:
```sh
echo -n $HYPHENATED_UUID | openssl dgst -sha256 -hmac $MASTER_KEY
```
fixes the issue raised in [product/discussion#421 ](https://github.com/meilisearch/product/discussions/421#discussioncomment-3079410 ), this should not impact anything in documentation nor integration but ease the key generation on the user sides.
poke `@gmourier`
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-07-06 12:49:04 +00:00
Kerollmops
d56bf66022
Make clippy happy
2022-07-05 17:48:44 +02:00
ManyTheFish
a146fd45b9
Format API keys in hexa instead of base64
2022-07-05 16:14:18 +02:00
Phillip Davis
be1c6f9dc4
Update tests to include .* permissions for tasks, indexes, dumps, stats, and settings
2022-07-04 21:38:54 -04:00
bors[bot]
c1ad56281d
Merge #2545 #2556 #2568 #2573 #2574 #2575
...
2545: meilisearch-lib was missing a feature in its cargo.toml r=Kerollmops a=irevoire
Meilisearch-lib was missing a feature to compile on its own
2556: chore: `meilisearch-http` readability improvements r=curquiza a=ryanrussell
## What does this PR do?
Readability improvements in `meilisearch-http`.
Believe these are pretty straightforward; let me know if anything needs adjusted or reverted :)
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
2568: Improve manifest for dependabot r=curquiza a=curquiza
Improve dependabot manifest
- `rebase-strategy: disabled` -> avoid issues with bors we had in the past with the integration team. The automatic rebase of dependabot does not fit with the rebase bors will try to do
- `labels` -> better triage for when I create the release changelogs
2573: Bump docker/login-action from 1 to 2 r=curquiza a=dependabot[bot]
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1 to 2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/login-action/releases ">docker/login-action's releases</a>.</em></p>
<blockquote>
<h2>v2.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a>)</li>
<li>Bump <code>`@actions/exec</code>` from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/167 ">#167</a>)</li>
<li>Bump <code>`@actions/io</code>` from 1.1.1 to 1.1.2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/168 ">#168</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a>)</li>
<li>Bump https-proxy-agent from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 ">https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 </a></p>
<h2>v1.14.1</h2>
<ul>
<li>Revert to Node 12 as default runtime to fix issue for GHE users (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/160 ">#160</a>)</li>
</ul>
<h2>v1.14.0</h2>
<ul>
<li>Update to node 16 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/158 ">#158</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr</code>` from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/157 ">#157</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr-public</code>` from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/156 ">#156</a>)</li>
</ul>
<h2>v1.13.0</h2>
<ul>
<li>Handle proxy settings for aws-sdk (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/152 ">#152</a>)</li>
<li>Workload identity based authentication docs for GCR and GAR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/112 ">#112</a>)</li>
<li>Test login against ACR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/49 ">#49</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr</code>` from 3.44.0 to 3.45.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/132 ">#132</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr-public</code>` from 3.43.0 to 3.45.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/131 ">#131</a>)</li>
</ul>
<h2>v1.12.0</h2>
<ul>
<li>ECR: only set credentials if username and password are specified (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/128 ">#128</a>)</li>
<li>Refactor to use aws-sdk v3 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/128 ">#128</a>)</li>
</ul>
<h2>v1.11.0</h2>
<ul>
<li>ECR: switch implementation to use the AWS SDK (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/126 ">#126</a>)</li>
<li><code>ecr</code> input to specify whether the given registry is ECR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/123 ">#123</a>)</li>
<li>Test against Windows runner (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/126 ">#126</a>)</li>
<li>Update instructions for Google registry (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/127 ">#127</a>)</li>
<li>Update dev workflow (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/111 ">#111</a>)</li>
<li>Small changes for GHCR doc (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/86 ">#86</a>)</li>
<li>Update dev dependencies (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/85 ">#85</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/101 ">#101</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/100 ">#100</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.4.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/94 ">#94</a> <a href="https://github-redirect.dependabot.com/docker/login-action/issues/103 ">#103</a>)</li>
<li>Bump codecov/codecov-action from 1 to 2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/88 ">#88</a>)</li>
<li>Bump hosted-git-info from 2.8.8 to 2.8.9 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/83 ">#83</a>)</li>
<li>Bump node-notifier from 8.0.0 to 8.0.2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/82 ">#82</a>)</li>
<li>Bump ws from 7.3.1 to 7.5.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/81 ">#81</a>)</li>
<li>Bump lodash from 4.17.20 to 4.17.21 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/80 ">#80</a>)</li>
<li>Bump y18n from 4.0.0 to 4.0.3 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/79 ">#79</a>)</li>
</ul>
<h2>v1.10.0</h2>
<ul>
<li>GitHub Packages Docker Registry deprecated (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/78 ">#78</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="49ed152c8ehttps://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a> from crazy-max/node16-runtime</li>
<li><a href="b61a9ce7bd3a136a8631https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a> from docker/dependabot/npm_and_yarn/https-proxy-agent...</li>
<li><a href="b312880b69795794e0811edf6180e0https://github-redirect.dependabot.com/docker/login-action/issues/179 ">#179</a> from docker/dependabot/github_actions/codecov/codecov...</li>
<li><a href="8e66ad40897c79b598eahttps://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a> from docker/dependabot/npm_and_yarn/minimist-1.2.6</li>
<li><a href="24a38e0d6d70e1ff84cbhttps://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a> from crazy-max/eslint</li>
<li>Additional commits viewable in <a href="https://github.com/docker/login-action/compare/v1...v2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2574: Bump Swatinem/rust-cache from 1.3.0 to 1.4.0 r=curquiza a=dependabot[bot]
Bumps [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache ) from 1.3.0 to 1.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/releases ">Swatinem/rust-cache's releases</a>.</em></p>
<blockquote>
<h2>v1.4.0</h2>
<ul>
<li>Clean both debug and release target directories.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/blob/v1/CHANGELOG.md ">Swatinem/rust-cache's changelog</a>.</em></p>
<blockquote>
<h2>1.4.0</h2>
<ul>
<li>Clean both <code>debug</code> and <code>release</code> target directories.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="cb2cf0cc7c74e8e24b6df8f67b75155b2b053862https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/49 ">#49</a>)</li>
<li><a href="3bb3a9a087d127014599801365cd81https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/34 ">#34</a>)</li>
<li><a href="c5ed9ba6b7536c94f32chttps://github-redirect.dependabot.com/Swatinem/rust-cache/issues/22 ">#22</a>)</li>
<li>See full diff in <a href="https://github.com/Swatinem/rust-cache/compare/v1.3.0...v1.4.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2575: Bump docker/build-push-action from 2 to 3 r=curquiza a=dependabot[bot]
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases ">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>Standalone mode support by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a>)</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/571 ">#571</a>)</li>
<li>Bump <code>`@actions/exec</code>` from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/573 ">#573</a>)</li>
<li>Bump <code>`@actions/github</code>` from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/582 ">#582</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/584 ">#584</a>)</li>
<li>Bump semver from 7.3.5 to 7.3.7 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/595 ">#595</a>)</li>
<li>Bump csv-parse from 4.16.3 to 5.0.4 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 ">https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 </a></p>
<h2>v2.10.0</h2>
<ul>
<li>Add <code>imageid</code> output and use metadata to set <code>digest</code> output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/569 ">#569</a>)</li>
<li>Add <code>build-contexts</code> input (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/563 ">#563</a>)</li>
<li>Enhance outputs display (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/559 ">#559</a>)</li>
</ul>
<h2>v2.9.0</h2>
<ul>
<li><code>add-hosts</code> input (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/553 ">#553</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/555 ">#555</a>)</li>
<li>Fix git context subdir example and improve README (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/552 ">#552</a>)</li>
<li>Add e2e tests for ACR (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/548 ">#548</a>)</li>
<li>Add description on <code>github-token</code> option to README (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/544 ">#544</a>)</li>
<li>Bump node-fetch from 2.6.1 to 2.6.7 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/549 ">#549</a>)</li>
</ul>
<h2>v2.8.0</h2>
<ul>
<li>Allow specifying subdirectory with default git context (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/531 ">#531</a>)</li>
<li>Add <code>cgroup-parent</code>, <code>shm-size</code>, <code>ulimit</code> inputs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/501 ">#501</a>)</li>
<li>Don't set outputs if empty or nil (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/470 ">#470</a>)</li>
<li>docs: example to sanitize tags with metadata-action (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/476 ">#476</a>)</li>
<li>docs: wrong syntax to sanitize repo slug (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/475 ">#475</a>)</li>
<li>docs: test before pushing your image (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/455 ">#455</a>)</li>
<li>readme: remove v1 section (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/500 ">#500</a>)</li>
<li>ci: virtual env file system info (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/510 ">#510</a>)</li>
<li>dev: update workflow (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/499 ">#499</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.5.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/160 ">#160</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/469 ">#469</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/465 ">#465</a>)</li>
<li>Bump csv-parse from 4.16.0 to 4.16.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/451 ">#451</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/459 ">#459</a>)</li>
</ul>
<h2>v2.7.0</h2>
<ul>
<li>Add <code>metadata</code> output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/412 ">#412</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.4.0 to 1.5.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/439 ">#439</a>)</li>
<li>Add note to sanitize tags (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/426 ">#426</a>)</li>
<li>Cache backend API docs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/406 ">#406</a>)</li>
<li>Git context now supports subdir (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/407 ">#407</a>)</li>
<li>Bump codecov/codecov-action from 1 to 2 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/415 ">#415</a>)</li>
</ul>
<h2>v2.6.1</h2>
<ul>
<li>Small typo and ensure trimmed output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/400 ">#400</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e551b19e49https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a> from crazy-max/node-16</li>
<li><a href="3554377aa3https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a> from crazy-max/ci-fix-test</li>
<li><a href="a62bc1b22bc2085839e1https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> from crazy-max/standalone-mode</li>
<li><a href="fcd91249e5https://github-redirect.dependabot.com/docker/build-push-action/issues/607 ">#607</a> from docker/dependabot/github_actions/docker/metadata...</li>
<li><a href="0ebe720aed38b45804b5ba317382dchttps://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a> from docker/dependabot/npm_and_yarn/csv-parse-5.0.4</li>
<li><a href="43721d23465ea21bf2bahttps://github.com/docker/build-push-action/compare/v2...v3 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Ryan Russell <git@ryanrussell.org>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-04 12:13:46 +00:00
Kerollmops
aff8cd1774
Make clippy happy
2022-07-04 13:36:56 +02:00
Ryan Russell
28609c4176
chore(auth test): Correct compute_authorized_search macro
...
Signed-off-by: Ryan Russell <git@ryanrussell.org>
2022-06-28 18:09:26 -05:00
Ryan Russell
a626cf4c99
chore: test comment readability improvements
...
Signed-off-by: Ryan Russell <git@ryanrussell.org>
2022-06-28 18:09:25 -05:00
bors[bot]
4862993482
Merge #2525
...
2525: Auth: Provide all document related permissions for action document.* r=Kerollmops a=janithpet
Added a `Action::DocumentsAll` identifier as [suggested](https://github.com/meilisearch/meilisearch/issues/2080#issuecomment-1022952486 ), along with the other necessary changes in `action.rs`.
Inside `store.rs`, added an extra condition in `HeedAuthStore::put_api_key` to append all document related permissions if `key.actions.contains(&DocumentsAll)`.
Updated the tests as [suggested](https://github.com/meilisearch/meilisearch/issues/2080#issuecomment-1022952486 ).
I am quite new to Rust, so please let me know if I had made any mistakes; have I written the code in the most idiomatic/efficient way? I am aware that the way I append the document permissions could create duplicates in the `actions` vector, but I am not sure how fix that in a simple way (other than using other dependencies like [itertools](https://github.com/rust-itertools/itertools ), for example).
## What does this PR do?
Fixes #2080
## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue?
- [ x] Have you read the contributing guidelines?
- [ x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: janithPet <jpetangoda@gmail.com>
2022-06-28 14:02:06 +00:00
Irevoire
05ee2eff01
add more tests on the formatted route
2022-06-28 13:17:55 +02:00
bors[bot]
9e261b996f
Merge #2543
...
2543: fix all the array on the search get route and improve the tests r=curquiza a=irevoire
fix #2527
Co-authored-by: Tamo <tamo@meilisearch.com>
2022-06-23 14:51:36 +00:00
Kerollmops
dad86fc3d6
Make the changes necessary to use milli 0.31.1
2022-06-23 10:47:49 +02:00
Loïc Lecrenier
f8aa21bc16
Fix content of dump/assets for testing
...
Some contained settings with the criterion desc(fame), which is invalid
for a v3 or higher dump.
The change took place in the updates.json file inside the decompressed
.dump files. Instances of desc(field) or asc(field) were changed to
field:desc and field:asc
2022-06-22 14:51:52 +02:00
Tamo
c47369b502
fix all the array on the search get route and improve the tests
2022-06-22 14:33:44 +02:00
janithPet
4016161035
Provide all document related permissions for action document.*
2022-06-15 16:11:39 +01:00
Kerollmops
9d692ba1c6
Add more tests for the pagination and faceting subsettings routes
2022-06-15 15:53:43 +02:00
bors[bot]
053071d866
Merge #2502
...
2502: test dump v5 r=ManyTheFish a=MarinPostma
this PR adds a test for dump v5
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-06-13 10:11:22 +00:00
ad hoc
97daea5a66
ignore dump test on windows
2022-06-13 09:16:36 +01:00
ad hoc
1425d62a31
test dump v5
2022-06-09 18:35:17 +02:00
pierre-l
b8745420da
Use the IndexUid and StarOr in meilisearch_auth::Key
...
Move `meilisearch_http::routes::StarOr` to `meilisearch_types::star_or`
Fixes #2158
2022-06-09 16:14:15 +02:00
pierre-l
36cb09eb25
Add a new meilisearch_types crate
...
Move `meilisearch_error` to `meilisearch_types::error`
Move `meilisearch_lib::index_resolver::IndexUid` to `meilisearch_types::index_uid`
Add a new `InvalidIndexUid` error in `meilisearch_types::index_uid`
2022-06-09 16:14:13 +02:00
Kerollmops
6f0d3472b1
Change the test for the new pagination.limited_to setting
2022-06-09 10:56:43 +02:00
Kerollmops
5cd13cc303
Add a test to validate the faceting.max_values_per_facet setting
2022-06-09 10:56:42 +02:00
Kerollmops
1e3dcbea3f
Plug the pagination.limited_to setting
2022-06-09 10:56:42 +02:00
Kerollmops
b96399d24b
Plug the faceting.max_values_per_facet setting
2022-06-09 10:56:42 +02:00
bors[bot]
6171f17f1d
Merge #2468
...
2468: Update milli 0.29 r=Kerollmops a=ManyTheFish
- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test
fixes #2375
fixes #2144
fixes #2417
fixes #2407
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-06-08 14:29:20 +00:00
ManyTheFish
55169ff914
Fix test get_document_s_nested_attributes_to_retrieve
2022-06-08 15:56:06 +02:00
ManyTheFish
0a16f71563
Increase wait_task wainting time
2022-06-08 15:56:03 +02:00
ManyTheFish
17f30c2b2d
Fix(auth): Authorization test were not testing keys unrestricted on index
2022-06-08 14:52:32 +02:00
ManyTheFish
09938c9b6f
Patch ranking rules error test
2022-06-08 14:38:09 +02:00
ManyTheFish
6ffa222218
feat(auth): Paginate API keys listing
...
- [x] Update tests
- [x] Use Pagination helpers to paginate API keys
fixes #2442
2022-06-07 17:37:48 +02:00
bors[bot]
79e67df73d
Merge #2474
...
2474: feat(auth): remove `dumps.get` action from keys r=ManyTheFish a=ManyTheFish
- [x] Update tests
- [x] Remove `dumps.get` action
related to: #2430
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-06-07 15:03:41 +00:00
ManyTheFish
a7bff35e49
fix(test): Reduce default index size in tests
2022-06-07 15:16:34 +02:00
ManyTheFish
3b01ed4fe8
feat(auth): remove dumps.get action from keys
2022-06-07 10:49:28 +02:00
bors[bot]
b83455f345
Merge #2454
...
2454: Unify the pagination of the index and documents route behind a common type r=curquiza a=irevoire
`@MarinPostma` wdyt of keeping the `auto_paginate_sized` until we implement the pagination on every route that needs it just to see if it could be useful to something else
Co-authored-by: Tamo <tamo@meilisearch.com>
2022-06-02 15:01:43 +00:00
bors[bot]
8ac8fcb0c9
Merge #2433
...
2433: Fix the documents route r=Kerollmops a=irevoire
fix #2428
Co-authored-by: Irevoire <tamo@meilisearch.com>
2022-06-02 13:25:34 +00:00
Irevoire
4667c9fe1a
fix(http): Fix the query parameter in the Documents route
2022-06-02 14:10:44 +02:00
Tamo
12b5eabd5d
chore(http): unify the pagination of the index and documents route behind a common type
2022-06-02 14:06:56 +02:00
bors[bot]
cf2d8de48a
Merge #2452
...
2452: Change http verbs r=ManyTheFish a=Kerollmops
This PR fixes #2419 by updating the HTTP verbs used to update the settings and every single setting parameter.
- [x] `PATCH /indexes/{indexUid}` instead of `PUT`
- [x] `PATCH /indexes/{indexUid}/settings` instead of `POST`
- [x] `PATCH /indexes/{indexUid}/settings/typo-tolerance` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/displayed-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/distinct-attribute` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/filterable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/ranking-rules` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/searchable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/sortable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/stop-words` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/synonyms` instead of `POST`
Co-authored-by: Kerollmops <clement@meilisearch.com>
2022-06-02 11:46:17 +00:00
Kerollmops
419922e475
Make clippy happy
2022-06-02 13:38:23 +02:00
bors[bot]
c9cd1738a5
Merge #2445
...
2445: Seek-based tasks list r=Kerollmops a=Kerollmops
This PR implements the seek-based pagination for the tasks list following [the spec](https://github.com/meilisearch/specifications/pull/115 ).
Co-authored-by: Kerollmops <clement@meilisearch.com>
2022-06-02 10:25:54 +00:00
Kerollmops
0258659278
Fix the get_settings tests
2022-06-02 12:24:27 +02:00
Kerollmops
ce37f53a16
Add typo-tolerance to the authorization tests
2022-06-02 12:17:53 +02:00
Kerollmops
bcb51905d7
Fix the authorization tests
2022-06-02 12:16:46 +02:00
bors[bot]
7e3d5ebc8e
Merge #2451
...
2451: feat(API-keys): Change immutable_field error message r=Kerollmops a=ManyTheFish
Change the immutable_field error message to fit the recent changes in the spec:
aa0a148ee3..84a9baff68
2022-06-02 09:26:36 +00:00
ManyTheFish
9eea142e2b
feat(API-keys): Change immutable_field error message
...
Change the immutable_field error message to fit the recent changes in the spec:
aa0a148ee3..84a9baff68
2022-06-02 11:11:07 +02:00
bors[bot]
8b8c3e32f0
Merge #2450
...
2450: Bump the dependencies r=ManyTheFish a=Kerollmops
In order to use [the latest version of grenad](https://docs.rs/grenad ) I bump the dependencies here. We also use the latest versions of all our other dependencies now.
Co-authored-by: Kerollmops <clement@meilisearch.com>
2022-06-02 08:53:12 +00:00
Kerollmops
ac9e7bdbe3
Fix a test that was depending on the speed of the CPU
2022-06-02 10:21:19 +02:00
ManyTheFish
4512eed8f5
Fix PR comments
2022-06-01 18:06:20 +02:00
Kerollmops
0656df3a6d
Fix the dumps tests
2022-06-01 17:14:13 +02:00
ManyTheFish
94b32cce01
Patch errors
2022-06-01 16:17:47 +02:00
ManyTheFish
b2e2dc8558
Re-authorize master_key to access to all routes
2022-06-01 16:17:47 +02:00
ManyTheFish
c295924ea2
Patch tests
2022-06-01 16:08:42 +02:00
ManyTheFish
1f62e83267
Remove error_add_api_key_invalid_index_uid_format
2022-06-01 16:08:42 +02:00
ManyTheFish
e2c204cf86
Update tests to fit to the new requirements
2022-06-01 16:07:44 +02:00
Kerollmops
004c8b6be3
Add the new limit and after fields in the dump tests
2022-06-01 12:09:52 +02:00
bors[bot]
e81c7aa2e6
Merge #2423
...
2423: Paginate the index resource r=MarinPostma a=irevoire
Fix #2373
Co-authored-by: Irevoire <tamo@meilisearch.com>
2022-05-31 19:25:25 +00:00
bors[bot]
47007fa71b
Merge #2446
...
2446: rename Succeded to Succeeded r=irevoire a=MarinPostma
this pr renames `TaskEvent::Succeded` to `TaskEvent::Succeeded` and apply the migration to the dumps
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-05-31 18:27:02 +00:00
Irevoire
627f13df85
feat(http): paginate the index resource
...
Fix #2373
2022-05-31 18:11:45 +02:00
ad hoc
446f1f31e0
rename Succeded to Succeeded
2022-05-31 17:22:37 +02:00
Irevoire
ddad6cc069
feat(http): update the documents resource
...
- Return Documents API resources on `/documents` in an array in the the results field.
- Add limit, offset and total in the response body.
- Rename `attributesToRetrieve` into `fields` (only for the `/documents` endpoints, not for the `/search` ones).
- The `displayedAttributes` settings does not impact anymore the displayed fields returned in the `/documents` endpoints. These settings only impacts the `/search` endpoint.
Fix #2372
2022-05-31 16:40:40 +02:00
Kerollmops
8800b348f0
Implement the StarOr on all the tasks filters
2022-05-31 11:33:21 +02:00
Kerollmops
b82c86c8f5
Allow users to filter indexUid with a *
2022-05-31 11:33:20 +02:00
Kerollmops
3f80468f18
Rename the Tasks Types
2022-05-31 11:33:20 +02:00
Kerollmops
8509243e68
Implement the status and type filtering on the tasks route
2022-05-31 11:33:20 +02:00
Kerollmops
3684c822f1
Add indexUid filtering on the /tasks route
2022-05-31 11:33:20 +02:00
Kerollmops
d2f457a076
Rename the uid to taskUid in asynchronous response
2022-05-31 11:33:20 +02:00
ad hoc
986a99296d
remove useless dump test
2022-05-25 11:25:11 +02:00
ad hoc
0f9c134114
fix tests
2022-05-25 11:13:35 +02:00
bors[bot]
341756a0eb
Merge #2357
...
2357: chore(dump): add dump tests r=Kerollmops a=irevoire
Add tests on the import of dump v1, v2, v3 and v4.
Since the dumps are slow to decompress, I made the `flate2` crate always compile in optimized.
And since they're also slow to index, I also made the `milli` crate always compile in optimized. What do you think of this `@MarinPostma?`
Should we keep milli unoptimized in case it could help us debug some things? 👀
Co-authored-by: Tamo <tamo@meilisearch.com>
2022-05-24 12:24:29 +00:00
Tamo
5f0e9b63d2
chore(dump): add tests
2022-05-24 14:21:56 +02:00
Irevoire
4e9accdeb7
chore(search): rename in the search endpoint
...
Fix ##2376
2022-05-19 16:31:37 +02:00
ManyTheFish
3517eae47f
Fix tests
2022-05-18 18:45:53 +02:00
ManyTheFish
0250ea9157
Intergrate smart crop in Meilisearch
2022-05-18 18:35:51 +02:00
Tamo
85d19bfb3e
chore: bump milli
2022-05-16 18:43:35 +02:00
Kerollmops
5c4c38c79c
Fix the tests about the nested fields
2022-05-04 12:10:52 +02:00
Irevoire
58a1124e9a
fix(search): formatted field
2022-04-20 11:30:01 +02:00
Tamo
69d312209e
feat(search): Implements the nested fields
...
See https://github.com/meilisearch/specifications/pull/121
2022-04-07 19:47:20 +02:00
bors[bot]
013fe4cbc9
Merge #2297
...
2297: Feat(Search): Enhance formating search results r=ManyTheFish a=ManyTheFish
Add new settings and change crop_len behavior to count words instead of characters.
- [x] `highlightPreTag`
- [x] `highlightPostTag`
- [x] `cropMarker`
- [x] `cropLength` count word instead of chars
- [x] `cropLength` 0 is now considered as no `cropLength`
- [ ] ~smart crop finding the best matches interval~ (postponed)
Partially fixes #2214 . (no smart crop)
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-04-07 13:29:56 +00:00
ManyTheFish
dc2cc1ee89
Feat(Search): Enhance formating search results
2022-04-07 15:04:08 +02:00
ad hoc
981fba5b44
feat(all): introduce disable typos
2022-04-06 15:47:48 +02:00
bors[bot]
9e344f6576
Merge #2207
...
2207: Fix: avoid embedding the user input into the error response. r=Kerollmops a=CNLHC
# Pull Request
## What does this PR do?
Fix #2107 .
The problem is meilisearch embeds the user input to the error message.
The reason for this problem is `milli` throws a `serde_json: Error` whose `Display` implementation will do this embedding.
I tried to solve this problem in this PR by manually implementing the `Display` trait for `DocumentFormatError` instead of deriving automatically.
<!-- Please link the issue you're trying to fix with this PR, if none then please create an issue first. -->
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: Liu Hancheng <cn_lhc@qq.com>
Co-authored-by: LiuHanCheng <2463765697@qq.com>
2022-04-04 17:35:17 +00:00
bors[bot]
09a72cee03
Merge #2281
...
2281: Hard limit the number of results returned by a search r=Kerollmops a=Kerollmops
This PR fixes #2133 by hard-limiting the number of results that a search request can return at any time. I would like the guidance of `@MarinPostma` to test that, should I use a mocking test here? Or should I do anything else?
I talked about touching the _nb_hits_ value with `@qdequele` and we concluded that it was not correct to do so.
Could you please confirm that it is the right place to change that?
Co-authored-by: Kerollmops <clement@meilisearch.com>
2022-04-04 17:19:05 +00:00
LiuHanCheng
6fc6b83632
Update meilisearch-http/tests/documents/add_documents.rs
...
Co-authored-by: Clément Renault <renault.cle@gmail.com>
2022-04-01 09:30:40 +08:00
LiuHanCheng
eee2cd5abf
Update meilisearch-http/tests/documents/add_documents.rs
...
Co-authored-by: Clément Renault <renault.cle@gmail.com>
2022-04-01 09:30:32 +08:00
Liu Hancheng
7ece7a9d9e
change truncate strategy and coresponding test
2022-03-31 10:39:21 +08:00
LiuHanCheng
403f03cb2c
Update meilisearch-http/tests/documents/add_documents.rs
...
Co-authored-by: Clément Renault <renault.cle@gmail.com>
2022-03-31 10:14:22 +08:00
Kerollmops
ffafd5b976
Add tests for the hard limit
2022-03-30 16:36:02 -07:00
shiori
9f1c88680d
Fix my mistake when resolving conflicts
2022-03-31 02:48:41 +09:00
shiori
9edd407a88
Merge branch 'main' into add-instance-options
2022-03-31 02:38:07 +09:00
Kerollmops
891d042164
Remove the memory limit to let Windows tests pass
2022-03-29 11:37:08 -07:00
Kerollmops
acdb10a307
Remove some useless indexer options
2022-03-29 11:37:08 -07:00
Kerollmops
8fecc6238d
Make the test use the default CLI options
2022-03-29 11:37:08 -07:00
Liu Hancheng
ce12000af3
add some comments
2022-03-25 21:33:47 +08:00
Liu Hancheng
3c72f4dc51
fix test and add truncate test.
2022-03-25 21:31:23 +08:00
