Commit Graph

266 Commits

Author SHA1 Message Date
mpostma
56ad400c49 update heed 2020-12-09 11:27:38 +01:00
bors[bot]
f564a9ce51
Merge #849
849: Update nbHits count with filtered documents r=MarinPostma a=balajisivaraman

Closes #764 
close #1039

After discussing with @MarinPostma on Slack, this is my first attempt at implementing this for the basic flow that will go through `bucket_sort_with_distinct`.

A few thoughts here: 

- For getting the count of filtered documents alone, I originally thought of using `filter_map.values().filter(|&&v| !v).count()`. In a few cases, this was the same as what I have now implemented. But I realised I couldn't do something similar for `distinct`. So for being consistent, I have implemented both in a similar fashion.
- I also needed the `contains_key` check to ensure we're not counting the same document ID twice.

@MarinPostma also mentioned that this will be an approximation since the sort is lazy. In the test example that I've updated, the actual filtered count will be just 19 (for `male` records), but due to the `limit` in play, it returns 32 (filtering out 11 records overall).

Please let me know if this is the kind of fix we are looking for, and I can implement it in the placeholder search also.

Co-authored-by: Balaji Sivaraman <balaji@balajisivaraman.com>
2020-11-26 09:53:13 +00:00
Balaji Sivaraman
75e22fc7f5 feat(search): update nbHits count with filtered docs for placeholder search 2020-11-19 21:02:47 +05:30
Balaji Sivaraman
43df4a56c4 feat(search): update nbHits count with filtered docs for core flow 2020-11-19 19:35:37 +05:30
mpostma
3a0861694d fix clear document bug 2020-11-19 14:04:07 +01:00
mpostma
a8ab15d65d Revert "Merge #1001"
This reverts commit 690eab4a25, reversing
changes made to 086020e543.

update changelog
2020-11-02 15:10:09 +01:00
mpostma
190b78b7be Revert "Merge #1037"
This reverts commit 257f9fb2b2, reversing
changes made to 9bae7a35bf.
2020-10-27 17:27:47 +01:00
mpostma
d35a104ad3 requested changes 2020-10-27 11:53:24 +01:00
mpostma
33c7c5a7e3 remove del_synonyms function 2020-10-26 21:33:39 +01:00
mpostma
f9ab85adbe deunicase synonyms 2020-10-26 17:47:55 +01:00
many
50f0fbb05c
remove useless function after health route refacto #1026 2020-10-20 16:21:46 +02:00
mpostma
dc2e5ceed2 fix bug 2020-10-16 14:16:12 +02:00
many
1639a7338d add test to reproduce #891 bug report
fix bug
2020-10-16 13:35:11 +02:00
mpostma
ac7226bb27 fix deserializer 2020-10-16 13:02:44 +02:00
bors[bot]
f359b64d59
Merge #946
946: Sort displayedAttributes field r=MarinPostma a=gorogoroumaru

Fix #943

displayedAttributes use the HashSet struct which is an unsorted structure, so I changed the implementation from HashSet into BTreeSet.

Co-authored-by: gorogoroumaru <zokutyou2@gmail.com>
2020-10-13 14:37:47 +00:00
qdequele
704defea78 fix clippy 2020-10-13 10:01:57 +02:00
gorogoroumaru
f4d918d22a
Merge branch 'master' into issue943 2020-10-02 21:01:31 +09:00
gorogoroumaru
5ef3a01b6c Merge branch 'issue943' of https://github.com/gorogoroumaru/MeiliSearch into issue943 2020-10-02 20:01:13 +09:00
gorogoroumaru
5a98f1f076 sort facetsDistribution attribute 2020-10-02 20:00:55 +09:00
bors[bot]
32f6a9a457
Merge #976
976: Revert 944 r=MarinPostma a=MarinPostma

revert #944 
@bidoubiwa  @curquiza @eskombro, this was a misunderstanding from our side. Doing this would in fact be an error, and would prevent us to do this: https://github.com/meilisearch/MeiliSearch/issues/945#issuecomment-685526678, which is what we are really after. We are resetting this to its default behaviour before it goes in prodution. Sorry for the confusion.

Co-authored-by: mpostma <postma.marin@protonmail.com>
2020-09-28 13:38:46 +00:00
many
c254320860
Implement backups
* trigger backup importation via http route
* follow backup advancement with status route
* import backup via a command line
* let user choose batch size of documents to import (command lines)

closes #884
closes #840
2020-09-28 14:40:06 +02:00
mpostma
d8d29d3615 Revert "fix facet count bug"
This reverts commit 733c02dd7c.
2020-09-24 16:39:42 +02:00
Clément Renault
84a3e95fa4
Merge branch 'stable' 2020-09-11 12:08:20 +02:00
many
b43137b508
add version guard in copy_and_compact_to_path function 2020-09-07 18:21:04 +02:00
gorogoroumaru
0ca44b6a82
Merge branch 'master' into issue943 2020-09-02 13:09:37 +09:00
gorogoroumaru
e47b4acd08 changed the implementation of displayedAttributes from HashSet into BtreeSet 2020-09-02 11:13:16 +09:00
mpostma
733c02dd7c fix facet count bug 2020-09-01 10:12:00 +02:00
mpostma
2a79dc9ded log error on unwrap error 2020-08-17 16:32:40 +02:00
mpostma
5ed62dbf76 fix unwrap bug 2020-08-14 12:16:48 +02:00
mpostma
75c3cb4bb6 fix compile error 2020-08-12 10:31:11 +02:00
marin
bfd0f806f8 requested changed
Co-authored-by: Clément Renault <renault.cle@gmail.com>
2020-08-12 10:31:11 +02:00
mpostma
afab8a7846 clean facet result types 2020-08-12 10:31:11 +02:00
mpostma
afacdbc7a0 update tests for facets distribution case 2020-08-12 10:31:11 +02:00
mpostma
18a50b4dac fix facet distribution case 2020-08-12 10:31:10 +02:00
Takayuki Maeda
750e7382c6 fix clippy warnings 2020-07-29 11:32:34 +09:00
Thomas Payet
c39b358518
Update error.rs 2020-07-20 14:42:47 +02:00
mpostma
d114250ebb requested changes 2020-07-16 16:19:15 +02:00
mpostma
4b5437a882 fix displayed attrs empty array bug 2020-07-15 19:25:24 +02:00
mpostma
de4caef468 test reset attributes to wildcard 2020-07-15 18:56:19 +02:00
mpostma
51b7cb2722 remove accept new fields / add indexed * 2020-07-15 18:56:19 +02:00
mpostma
7f5fb50307 add displayed attributes wildcard 2020-07-15 18:56:19 +02:00
mpostma
5773c5c865 check version file against regex 2020-07-13 16:06:28 +02:00
mpostma
51d7c84e73 better exit on error
Update meilisearch-core/src/database.rs

Co-authored-by: Clément Renault <renault.cle@gmail.com>

Update meilisearch-core/src/database.rs

Co-authored-by: Clément Renault <renault.cle@gmail.com>
2020-07-13 16:06:28 +02:00
mpostma
f5a936614a error on meili database version mismatch 2020-07-13 16:05:08 +02:00
bors[bot]
308630c094
Merge #841
841: Unique docid bugfix r=LegendreM a=MarinPostma

fix #827 

Co-authored-by: mpostma <postma.marin@protonmail.com>
2020-07-13 13:36:32 +00:00
mpostma
f54397e0cf test unique document id bug 2020-07-13 15:14:07 +02:00
mpostma
754efe1f42 fix document id uniqueness bug 2020-07-13 15:14:07 +02:00
mpostma
99e8d4adae fix missing primary key 2020-07-13 14:54:25 +02:00
mpostma
bbe3a10107 implement placeholder search 2020-07-03 17:17:28 +02:00
mpostma
41707e3245 fix error on missing document id in document 2020-07-02 15:18:30 +02:00