Tamo
35d5556f1f
prefix all the metrics by meilisearch_
2023-05-25 17:41:53 +02:00
Tamo
c433bdd1cd
add a view for the task queue in the metrics
2023-05-25 12:58:13 +02:00
Tamo
9111f5176f
get rid of the invalid document delete filter in favor of the invalid document filter
2023-05-24 11:53:16 +02:00
Tamo
b9dd092a62
make the details return null in the originalFilter field if no filter was provided + add a big test on the details
2023-05-24 11:48:22 +02:00
Tamo
ca99bc3188
implement the missing document filter error code when deleting documents
2023-05-24 11:29:20 +02:00
Tamo
57d53de402
Increase the number of buckets
2023-05-24 10:47:15 +02:00
meili-bors[bot]
6ce1ce77e6
Merge #3738
...
3738: Add analytics on the get documents resource r=dureuill a=irevoire
# Pull Request
## Related issue
Fixes https://github.com/meilisearch/meilisearch/issues/3737
Related spec https://github.com/meilisearch/specifications/pull/234
## What does this PR do?
Add the analytics for the following routes:
- `GET` - `/indexes/:uid/documents`
- `GET` - `/indexes/:uid/documents/:doc_id`
- `POST` - `/indexes/:uid/documents/fetch`
These analytics are aggregated between two events:
- `Documents Fetched GET`
- `Documents Fetched POST`
That shares the same payload:
Property name | Description | Example |
|---------------|-------------|---------|
| `requests.total_received` | Total number of request received in this batch | 325 |
| `per_document_id` | `false` | false |
| `per_filter` | `true` if `POST /indexes/:indexUid/documents/fetch` endpoint was used with a filter in this batch, otherwise `false` | false |
| `pagination.max_limit` | Highest value given for the `limit` parameter in this batch | 60 |
| `pagination.max_offset` | Highest value given for the `offset` parameter in this batch | 1000 |
Co-authored-by: Tamo <tamo@meilisearch.com>
2023-05-16 19:37:41 +00:00
Tamo
96da5130a4
fix the error code in case of not filterable attributes on the get / delete documents by filter routes
2023-05-16 13:56:18 +02:00
Tamo
d08f8690d2
add analytics on the get documents resource
2023-05-10 14:28:30 +02:00
Tamo
11e394dba1
merge the document fetch and get error codes
2023-05-04 15:39:49 +02:00
Tamo
469d2f2a9c
fix the fields field of the POST fetch document API
2023-05-04 15:34:09 +02:00
Tamo
ed3dfbe729
add error codes and tests
2023-05-04 15:34:08 +02:00
Louis Dureuil
441641397b
Implement document get with filters
2023-05-04 15:32:34 +02:00
Louis Dureuil
d5059520aa
Fix typo
2023-05-03 22:27:03 +02:00
Tamo
b5fe0b2b07
fix the details
2023-05-03 17:41:50 +02:00
Tamo
0548ab9038
create and use the error code
2023-05-03 17:41:50 +02:00
Tamo
143acb9cdc
update the tests
2023-05-03 17:41:49 +02:00
Tamo
4b92f1b269
wip
2023-05-03 17:41:49 +02:00
Louis Dureuil
732c52093d
Processing time without autobatching implementation
2023-05-03 17:41:48 +02:00
Louis Dureuil
05cc463fbc
Draft implementation of filter support for /delete-by-batch route
2023-05-03 17:41:48 +02:00
Tamo
4d308d5237
Improve the health route by ensuring lmdb is not down
...
And refactorize slightly the auth controller.
2023-04-06 15:31:42 +02:00
Louis Dureuil
2f5b9fbbd8
Restore contribution of the index sizes to the db size
...
- the index size now contributes to the db size even if the index is not authorized
2023-03-07 14:05:27 +01:00
Louis Dureuil
076a3d371c
Eagerly compute stats as fallback to the cache.
...
- Refactor all around to avoid spawning indexes more times than necessary
2023-03-06 16:57:31 +01:00
Tamo
fd5c48941a
Add cache on the indexes stats
2023-03-06 16:57:31 +01:00
Louis Dureuil
d4d4702f1b
Rephrase hint message
2023-02-27 13:46:16 +01:00
Tamo
dc533584c6
Forbid the usage of the metrics route if your API key have a limitation on the indexes
2023-02-23 17:13:22 +01:00
bors[bot]
89ac1015f3
Merge #3524
...
3524: Update the metrics route r=irevoire a=irevoire
Fixes #3523
Make the metrics available by default without a feature flag.
+ Rename the cli-flag to `experimental-enable-metrics`.
Co-authored-by: Tamo <tamo@meilisearch.com>
2023-02-23 15:11:10 +00:00
Tamo
8a1b1a95f3
comment the right of the metrics
2023-02-23 13:59:01 +01:00
Tamo
8d47d2d018
update the auth api after the rebase
2023-02-23 13:15:51 +01:00
Tamo
68e30214ca
remove the feature flag and reorganize the module slightly
2023-02-23 12:26:21 +01:00
Louis Dureuil
3db613ff77
Don't iterate all indexes manually
2023-02-23 11:29:09 +01:00
bors[bot]
f62703cd67
Merge #3534
...
3534: Update the csv error code from InvalidIndexCsvDelimiter to InvalidDocumentCsvDelimiter r=Kerollmops a=irevoire
Fixes #3533
Co-authored-by: Tamo <tamo@meilisearch.com>
2023-02-23 07:05:12 +00:00
Tamo
76f82c880d
update the csv error code from InvalidIndexCsvDelimiter to InvalidDocumentCsvDelimiter
2023-02-22 19:26:48 +01:00
Louis Dureuil
a23fbf6c7b
multi-search: Add search with an array of indexes
2023-02-22 17:04:12 +01:00
Louis Dureuil
14c4a222da
Authentication: AuthFilter::allow_index_creation both check that the index is authorized and the IndexCreate action
2023-02-22 16:37:13 +01:00
Louis Dureuil
690bb2e5cc
Authentication: Make allow_index_creation a private field
2023-02-22 16:35:52 +01:00
Louis Dureuil
42577403d8
Authentication: Directly pass the authfilter to the index scheduler
2023-02-22 16:35:52 +01:00
Louis Dureuil
c8c5944094
Authentication: is_index_authorized takes into account API key indexes even with a tenant token
2023-02-22 16:35:52 +01:00
Tamo
1479050f7a
apply review suggestions
2023-02-20 14:53:37 +01:00
Tamo
e79f6f87f6
make cargo fmt&clippy happy
2023-02-16 18:00:40 +01:00
Tamo
8c074f5028
implements the csv delimiter without tests
...
Co-authored-by: Maxi Barmetler <maxi.barmetler@gmail.com>
2023-02-16 17:35:36 +01:00
Tamo
42a3cdca66
get rids of the unwrap_any function in favor of take_cf_content
2023-02-14 20:06:31 +01:00
Tamo
a43765d454
use the pre-defined deserr extractors
2023-02-14 20:05:30 +01:00
Tamo
769576fd94
get rids of the whole error_message module since it has been integrated into the last version of deserr
2023-02-14 20:05:27 +01:00
Tamo
8fb7b1d10f
bump deserr
2023-02-14 20:04:30 +01:00
Clément Renault
4570d5bf3a
Merge remote-tracking branch 'origin/main' into temp-wildcard
2023-02-09 13:14:05 +01:00
Kerollmops
184b8afd9e
Make it work in the CreateApiKey struct
2023-01-25 15:01:50 +01:00
Tamo
a858531574
apply review comments
2023-01-25 14:51:36 +01:00
Tamo
c92948b143
Compute the size of the auth-controller, index-scheduler and all update files in the global stats
2023-01-25 11:25:02 +01:00
bors[bot]
8fb685f5aa
Merge #3401
...
3401: improve the error messages for the immutable fields r=dureuill a=irevoire
Fix https://github.com/meilisearch/meilisearch/issues/3400
Co-authored-by: Tamo <tamo@meilisearch.com>
2023-01-19 15:52:50 +00:00
Tamo
e3742a38d4
improve the error messages for the immutable fields
2023-01-19 16:49:44 +01:00
Louis Dureuil
72e2b220ed
Fix tests
2023-01-19 15:48:20 +01:00
Tamo
a4476c20f8
fix a wrong error code and add tests on the document resource
2023-01-18 15:28:02 +01:00
Loïc Lecrenier
e225608337
Use invalid_index_uid error code in more places
2023-01-17 15:28:06 +01:00
Loïc Lecrenier
56e79fa850
Update task snapshot test and clean up details
2023-01-17 13:19:04 +01:00
Loïc Lecrenier
b781f9a0f9
cargo fmt
2023-01-17 11:07:07 +01:00
Loïc Lecrenier
9194508a0f
Refactor query parameter deserialisation logic
2023-01-17 11:07:07 +01:00
Loïc Lecrenier
766dd830ae
Update deserr to latest version + add new error codes for missing fields
...
- missing_api_key_indexes
- missing_api_key_actions
- missing_api_key_expires_at
- missing_swap_indexes_indexes
2023-01-17 09:43:07 +01:00
Loïc Lecrenier
436ae4e466
Improve error messages generated by deserr
...
Split Json and Query Parameter error types
2023-01-17 09:43:07 +01:00
bors[bot]
a5c4fbbcea
Merge #3334
...
3334: Add specific error codes `immutable_...` r=irevoire a=loiclec
Add the following error codes:
When an immutable field of API key is sent to the `PATCH /keys` route:
- `ImmutableApiKeyUid`
- `ImmutableApiKeyKey`
- `ImmutableApiKeyActions`
- `ImmutableApiKeyIndexes`
- `ImmutableApiKeyExpiresAt`
- `ImmutableApiKeyCreatedAt`
- `ImmutableApiKeyUpdatedAt`
When an immutable field of Index is sent to the `PATCH /indexes/{uid}` route:
- `ImmutableIndexUid`
- `ImmutableIndexCreatedAt`
- `ImmutableIndexUpdatedAt`
Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
2023-01-12 15:31:38 +00:00
Tamo
21b8cd53b7
reformat
2023-01-12 16:20:24 +01:00
Loïc Lecrenier
7f80b116bc
Add specific immutable_field error codes
2023-01-12 16:20:14 +01:00
Tamo
705fcaa3b8
reformat the imports
2023-01-12 14:09:15 +01:00
Loïc Lecrenier
a09b6a341d
Move tasks route to deserr
2023-01-12 13:57:29 +01:00
Tamo
387874ea26
test the error codes on the task routes
2023-01-12 13:46:19 +01:00
Tamo
a68ac3a1dc
reformat the headers
2023-01-11 19:08:39 +01:00
Loïc Lecrenier
b0b7ad7caf
Apply review suggestions
2023-01-11 19:08:39 +01:00
Loïc Lecrenier
1fc11264e8
Refactor deserr integration
2023-01-11 19:08:39 +01:00
Loïc Lecrenier
9ab791bedc
Update error codes on the api key routes
2023-01-09 12:30:25 +01:00
Loïc Lecrenier
96105a5e8d
Update error codes on the documents/ routes
2023-01-09 12:30:25 +01:00
Tamo
50ce0409bc
Integrate deserr on the most important routes
2023-01-05 20:48:29 +01:00
Kerollmops
7b2f2a4f9c
Do only one convertion to u64
2022-12-13 15:31:55 +01:00
Kerollmops
5d5615ef45
Rename the ReceivePayload error variant
2022-12-13 15:07:35 +01:00
jiangbo212
23c1b223b3
Merge branch 'fix-3037' of github.com:jiangbo212/meilisearch into fix-3037
2022-12-13 10:41:50 +08:00
jiangbo212
87ae0032bf
review change
2022-12-13 10:41:43 +08:00
jiangbo212
7c24fea9f2
Merge branch 'main' into fix-3037
2022-12-13 05:16:03 +08:00
jiangbo212
fa46dfb7bb
fmt fix
2022-12-12 22:02:56 +08:00
jiangbo212
169682d3ec
Merge branch 'main' into fix-3037-new
2022-12-12 21:36:10 +08:00
Colby Allen
ad2b1467da
Renames meilisearch-http to meilisearch
2022-12-08 08:22:53 -07:00
