From 781691191a49eb989f55b95a4c766365aca101db Mon Sep 17 00:00:00 2001 From: curquiza Date: Thu, 2 Feb 2023 15:22:58 +0100 Subject: [PATCH 1/4] Pin Rust version in Clippy job --- .github/workflows/rust.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index cec364eef..1752739bc 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -100,7 +100,7 @@ jobs: - uses: actions-rs/toolchain@v1 with: profile: minimal - toolchain: stable + toolchain: 1.67.0 override: true components: clippy # - name: Cache dependencies From a11d992923a0654e547355b195592d9275db56f2 Mon Sep 17 00:00:00 2001 From: curquiza Date: Thu, 2 Feb 2023 15:33:38 +0100 Subject: [PATCH 2/4] Update issue description for the dependency updates --- .github/workflows/create-issue-dependencies.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/create-issue-dependencies.yml b/.github/workflows/create-issue-dependencies.yml index f6b9c018c..160ddc0a9 100644 --- a/.github/workflows/create-issue-dependencies.yml +++ b/.github/workflows/create-issue-dependencies.yml @@ -15,9 +15,13 @@ jobs: github_token: ${{ secrets.MEILI_BOT_GH_PAT }} title: Upgrade dependencies body: | - We need to update the dependencies of the Meilisearch repository, and, if possible, the dependencies of all the engine-team repositories that Meilisearch depends on (charabia, heed...). + This issue is about updating Meilisearch dependencies: + - [ ] Cargo toml dependencies of Meilisearch; but also the main engine-team repositories that Meilisearch depends on (charabia, heed...) + - [ ] If new Rust versions has been release, update the Rust version in the Clippy job of this [GitHub Action file](./.github/workflows/rust.yml) - ⚠️ This issue should only be done at the beginning of the sprint! + ⚠️ To avoid last minute bugs, this issue should only be done at the beginning of the sprint! + + The GitHub action dependencies are managed by [Dependabot](./.github/dependabot.yml) labels: | dependencies maintenance From 1ca7778e6ac46cdec814e27dd1849e8ae105037f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Urquizar=20-=20curqui?= Date: Thu, 2 Feb 2023 15:54:33 +0100 Subject: [PATCH 3/4] Update .github/workflows/create-issue-dependencies.yml Co-authored-by: Louis Dureuil --- .github/workflows/create-issue-dependencies.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/create-issue-dependencies.yml b/.github/workflows/create-issue-dependencies.yml index 160ddc0a9..006af6833 100644 --- a/.github/workflows/create-issue-dependencies.yml +++ b/.github/workflows/create-issue-dependencies.yml @@ -17,7 +17,7 @@ jobs: body: | This issue is about updating Meilisearch dependencies: - [ ] Cargo toml dependencies of Meilisearch; but also the main engine-team repositories that Meilisearch depends on (charabia, heed...) - - [ ] If new Rust versions has been release, update the Rust version in the Clippy job of this [GitHub Action file](./.github/workflows/rust.yml) + - [ ] If new Rust versions have been released, update the Rust version in the Clippy job of this [GitHub Action file](./.github/workflows/rust.yml) ⚠️ To avoid last minute bugs, this issue should only be done at the beginning of the sprint! From 69fcd3d05ed05b36babe59e5a1a26af519058b2d Mon Sep 17 00:00:00 2001 From: curquiza Date: Thu, 2 Feb 2023 15:58:03 +0100 Subject: [PATCH 4/4] Add comment information about the cron job --- .github/workflows/create-issue-dependencies.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/create-issue-dependencies.yml b/.github/workflows/create-issue-dependencies.yml index 006af6833..3ad1be910 100644 --- a/.github/workflows/create-issue-dependencies.yml +++ b/.github/workflows/create-issue-dependencies.yml @@ -1,6 +1,7 @@ name: Create issue to upgrade dependencies on: schedule: + # Run the first of the month, every 3 month - cron: '0 0 1 */3 *' workflow_dispatch: