From f54397e0cfba5ce54a11e385ed788c3b751c5704 Mon Sep 17 00:00:00 2001 From: mpostma Date: Tue, 7 Jul 2020 15:12:27 +0200 Subject: [PATCH] test unique document id bug --- meilisearch-core/src/update/helpers.rs | 2 +- meilisearch-http/tests/documents_add.rs | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/meilisearch-core/src/update/helpers.rs b/meilisearch-core/src/update/helpers.rs index 1942c322c..1aad1f505 100644 --- a/meilisearch-core/src/update/helpers.rs +++ b/meilisearch-core/src/update/helpers.rs @@ -6,7 +6,7 @@ use meilisearch_types::DocumentId; use ordered_float::OrderedFloat; use serde_json::Value; -use crate::{Number, FstMapCow}; +use crate::Number; use crate::raw_indexer::RawIndexer; use crate::serde::SerializerError; use crate::store::DiscoverIds; diff --git a/meilisearch-http/tests/documents_add.rs b/meilisearch-http/tests/documents_add.rs index 994fd55e5..fae29f15e 100644 --- a/meilisearch-http/tests/documents_add.rs +++ b/meilisearch-http/tests/documents_add.rs @@ -195,3 +195,23 @@ async fn add_document_with_long_field() { let (response, _status) = server.search_post(json!({ "q": "request_buffering" })).await; assert!(!response["hits"].as_array().unwrap().is_empty()); } + +#[actix_rt::test] +async fn documents_with_same_id_are_overwritten() { + let mut server = common::Server::with_uid("test"); + server.create_index(json!({ "uid": "test"})).await; + let documents = json!([ + { + "id": 1, + "content": "test1" + }, + { + "id": 1, + "content": "test2" + }, + ]); + server.add_or_replace_multiple_documents(documents).await; + let (response, _status) = server.get_all_documents().await; + assert_eq!(response.as_array().unwrap().len(), 1); + assert_eq!(response.as_array().unwrap()[0].as_object().unwrap()["content"], "test2"); +}