From f27b33dabe79f73a5eadc950700c8f047b49092d Mon Sep 17 00:00:00 2001 From: michascant <89426143+MichaScant@users.noreply.github.com> Date: Mon, 16 Dec 2024 13:27:57 -0500 Subject: [PATCH] undid changes from the pull 1.12.0 branch --- .github/workflows/bench-pr.yml | 2 +- .github/workflows/benchmarks-pr.yml | 2 +- BENCHMARKS.md | 21 --------------------- 3 files changed, 2 insertions(+), 23 deletions(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 632c86d4e..128b513bd 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -55,7 +55,7 @@ jobs: reaction-type: "rocket" repo-token: ${{ env.GH_TOKEN }} - - uses: xt0rted/pull-request-comment-branch@v3 + - uses: xt0rted/pull-request-comment-branch@v2 id: comment-branch with: repo_token: ${{ env.GH_TOKEN }} diff --git a/.github/workflows/benchmarks-pr.yml b/.github/workflows/benchmarks-pr.yml index 7c081932a..a083baa3c 100644 --- a/.github/workflows/benchmarks-pr.yml +++ b/.github/workflows/benchmarks-pr.yml @@ -56,7 +56,7 @@ jobs: reaction-type: "eyes" repo-token: ${{ env.GH_TOKEN }} - - uses: xt0rted/pull-request-comment-branch@v3 + - uses: xt0rted/pull-request-comment-branch@v2 id: comment-branch with: repo_token: ${{ env.GH_TOKEN }} diff --git a/BENCHMARKS.md b/BENCHMARKS.md index 6cabb11b5..6d2cc6100 100644 --- a/BENCHMARKS.md +++ b/BENCHMARKS.md @@ -48,27 +48,6 @@ cargo xtask bench --no-dashboard -- workloads/my_workload_1.json workloads/my_wo For processing the results, look at [Looking at benchmark results/Without dashboard](#without-dashboard). -#### Sending a workload by hand - -Sometimes you want to visualize the metrics of a worlkoad that comes from a custom report. -It is not quite easy to trick the benchboard in thinking that your report is legitimate but here are the commands you can run to upload your firefox report on a running benchboard. - -```bash -# Name this hostname whatever you want -echo '{ "hostname": "the-best-place" }' | xh PUT 'http://127.0.0.1:9001/api/v1/machine' - -# You'll receive an UUID from this command that we will call $invocation_uuid -echo '{ "commit": { "sha1": "1234567", "commit_date": "2024-09-05 12:00:12.0 +00:00:00", "message": "A cool message" }, "machine_hostname": "the-best-place", "max_workloads": 1 }' | xh PUT 'http://127.0.0.1:9001/api/v1/invocation' - -# Just use UUID from the previous command -# and you'll receive another UUID that we will call $workload_uuid -echo '{ "invocation_uuid": "$invocation_uuid", "name": "toto", "max_runs": 1 }' | xh PUT 'http://127.0.0.1:9001/api/v1/workload' - -# And now use your $workload_uuid and the content of your firefox report -# but don't forget to convert your firefox report from JSONLines into an object -echo '{ "workload_uuid": "$workload_uuid", "data": $REPORT_JSON_DATA }' | xh PUT 'http://127.0.0.1:9001/api/v1/run' -``` - ### In CI We have dedicated runners to run workloads on CI. Currently, there are three ways of running the CI: