From e9b90d5380be9a89a31637898bd15d5fb33f102d Mon Sep 17 00:00:00 2001 From: mpostma Date: Mon, 8 Mar 2021 13:51:33 +0100 Subject: [PATCH] fixes from review --- meilisearch-http/src/data/mod.rs | 2 +- meilisearch-http/src/data/search.rs | 1 - meilisearch-http/tests/settings/get_settings.rs | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/meilisearch-http/src/data/mod.rs b/meilisearch-http/src/data/mod.rs index 2904bb67f..05a29381a 100644 --- a/meilisearch-http/src/data/mod.rs +++ b/meilisearch-http/src/data/mod.rs @@ -109,7 +109,7 @@ impl Data { let criteria = index .criteria(&txn)? .into_iter() - .map(|v| format!("{}", v)) + .map(|v| v.to_string()) .collect(); Ok(Settings { diff --git a/meilisearch-http/src/data/search.rs b/meilisearch-http/src/data/search.rs index a721a8200..7692417ed 100644 --- a/meilisearch-http/src/data/search.rs +++ b/meilisearch-http/src/data/search.rs @@ -62,7 +62,6 @@ impl SearchQuery { documents_ids, matching_words, candidates, - .. } = search.execute()?; let mut documents = Vec::new(); diff --git a/meilisearch-http/tests/settings/get_settings.rs b/meilisearch-http/tests/settings/get_settings.rs index 25d46b961..d1ce6ea5d 100644 --- a/meilisearch-http/tests/settings/get_settings.rs +++ b/meilisearch-http/tests/settings/get_settings.rs @@ -8,7 +8,6 @@ async fn get_settings_unexisting_index() { assert_eq!(code, 400) } -// test broken, should be fixed with milli#101 #[actix_rt::test] async fn get_settings() { let server = Server::new().await;