searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-01-09 21:14:30 +01:00
Code Issues Releases Wiki Activity

When spilling on the next fid, no longer ignore children

Browse Source
This commit is contained in:
Louis Dureuil 2025-01-08 16:50:05 +01:00
parent 7ec7200378
commit e83c021755
No known key found for this signature in database
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
crates/milli/src/update/facet/new_incremental.rs
View File

@ -144,12 +144,26 @@ impl FacetsUpdateIncrementalInner {
.prefix_iter_mut(wtxn, &parent_level_left_bound)?; .prefix_iter_mut(wtxn, &parent_level_left_bound)?;
match parent_it.next() { match parent_it.next() {
// 1. left of the current left bound, or // 1. left of the current left bound, or
Some(Ok((first_key, _first_value))) => 'change_left_bound: { Some(Ok((first_key, _first_value))) => {
// make sure we don't spill on the neighboring fid (level also included defensively) // make sure we don't spill on the neighboring fid (level also included defensively)
if first_key.field_id != self.field_id if first_key.field_id != self.field_id
|| first_key.level != parent_level || first_key.level != parent_level
{ {
break 'change_left_bound; // max level reached, exit
drop(parent_it);
self.compute_parent_group(
wtxn,
child_level,
child.facet_value,
)?;
for child in child_it.by_ref() {
self.compute_parent_group(
wtxn,
child_level,
child.facet_value,
)?;
}
return Ok(());
} }
// remove old left bound // remove old left bound
unsafe { parent_it.del_current()? }; unsafe { parent_it.del_current()? };
@ -170,8 +184,6 @@ impl FacetsUpdateIncrementalInner {
child.facet_value, child.facet_value,
)?; )?;
} }
break 'current_level;
} }
Some(Err(err)) => return Err(err.into()), Some(Err(err)) => return Err(err.into()),
// 2. max level reached, exit // 2. max level reached, exit