From e7244aa4851e67b729bddc436a222ec8de8eccb2 Mon Sep 17 00:00:00 2001 From: Tamo Date: Mon, 30 Oct 2023 11:00:46 +0100 Subject: [PATCH] fix warnings --- meilisearch/tests/common/mod.rs | 2 ++ milli/src/search/facet/filter.rs | 2 +- milli/src/search/mod.rs | 2 +- milli/src/search/new/ranking_rule_graph/mod.rs | 2 +- milli/src/update/index_documents/helpers/mod.rs | 2 +- milli/src/update/index_documents/mod.rs | 5 +---- 6 files changed, 7 insertions(+), 8 deletions(-) diff --git a/meilisearch/tests/common/mod.rs b/meilisearch/tests/common/mod.rs index 9ee9b755e..d7888b7db 100644 --- a/meilisearch/tests/common/mod.rs +++ b/meilisearch/tests/common/mod.rs @@ -5,9 +5,11 @@ pub mod service; use std::fmt::{self, Display}; +#[allow(unused)] pub use index::{GetAllDocumentsOptions, GetDocumentOptions}; use meili_snap::json_string; use serde::{Deserialize, Serialize}; +#[allow(unused)] pub use server::{default_settings, Server}; #[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)] diff --git a/milli/src/search/facet/filter.rs b/milli/src/search/facet/filter.rs index fac7b68ea..c4cdb37e6 100644 --- a/milli/src/search/facet/filter.rs +++ b/milli/src/search/facet/filter.rs @@ -3,7 +3,7 @@ use std::fmt::{Debug, Display}; use std::ops::Bound::{self, Excluded, Included}; use either::Either; -pub use filter_parser::{Condition, Error as FPError, FilterCondition, Span, Token}; +pub use filter_parser::{Condition, Error as FPError, FilterCondition, Token}; use roaring::RoaringBitmap; use serde_json::Value; diff --git a/milli/src/search/mod.rs b/milli/src/search/mod.rs index 2c78acfdf..786b565ae 100644 --- a/milli/src/search/mod.rs +++ b/milli/src/search/mod.rs @@ -11,7 +11,7 @@ use once_cell::sync::Lazy; use roaring::bitmap::RoaringBitmap; pub use self::facet::{FacetDistribution, Filter, OrderBy, DEFAULT_VALUES_PER_FACET}; -pub use self::new::matches::{FormatOptions, MatchBounds, Matcher, MatcherBuilder, MatchingWords}; +pub use self::new::matches::{FormatOptions, MatchBounds, MatcherBuilder, MatchingWords}; use self::new::PartialSearchResult; use crate::error::UserError; use crate::heed_codec::facet::{FacetGroupKey, FacetGroupValue}; diff --git a/milli/src/search/new/ranking_rule_graph/mod.rs b/milli/src/search/new/ranking_rule_graph/mod.rs index 209ec91de..c1b8df1b7 100644 --- a/milli/src/search/new/ranking_rule_graph/mod.rs +++ b/milli/src/search/new/ranking_rule_graph/mod.rs @@ -29,7 +29,7 @@ use std::hash::Hash; pub use cheapest_paths::PathVisitor; pub use condition_docids_cache::ConditionDocIdsCache; pub use dead_ends_cache::DeadEndsCache; -pub use exactness::{ExactnessCondition, ExactnessGraph}; +pub use exactness::ExactnessGraph; pub use fid::{FidCondition, FidGraph}; pub use position::{PositionCondition, PositionGraph}; pub use proximity::{ProximityCondition, ProximityGraph}; diff --git a/milli/src/update/index_documents/helpers/mod.rs b/milli/src/update/index_documents/helpers/mod.rs index d59a3bc08..c403f9e3d 100644 --- a/milli/src/update/index_documents/helpers/mod.rs +++ b/milli/src/update/index_documents/helpers/mod.rs @@ -14,7 +14,7 @@ pub use grenad_helpers::{ }; pub use merge_functions::{ concat_u32s_array, keep_first, keep_latest_obkv, merge_btreeset_string, - merge_cbo_roaring_bitmaps, merge_obkvs_and_operations, merge_roaring_bitmaps, merge_two_obkvs, + merge_cbo_roaring_bitmaps, merge_obkvs_and_operations, merge_roaring_bitmaps, serialize_roaring_bitmap, MergeFn, }; diff --git a/milli/src/update/index_documents/mod.rs b/milli/src/update/index_documents/mod.rs index 52aa1113e..b3e7e203e 100644 --- a/milli/src/update/index_documents/mod.rs +++ b/milli/src/update/index_documents/mod.rs @@ -20,10 +20,7 @@ use slice_group_by::GroupBy; use typed_chunk::{write_typed_chunk_into_index, TypedChunk}; use self::enrich::enrich_documents_batch; -pub use self::enrich::{ - extract_finite_float_from_value, validate_document_id, validate_document_id_value, - validate_geo_from_json, DocumentId, -}; +pub use self::enrich::{extract_finite_float_from_value, DocumentId}; pub use self::helpers::{ as_cloneable_grenad, create_sorter, create_writer, fst_stream_into_hashset, fst_stream_into_vec, merge_btreeset_string, merge_cbo_roaring_bitmaps, merge_roaring_bitmaps,